| Message ID | 20230506074037.522961-4-haibo.chen@nxp.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | cd/wp code clean up for i.MX USDHC | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 06/05/2023 09:40, haibo.chen@nxp.com wrote: > From: Haibo Chen <haibo.chen@nxp.com> > > Driver do not use this property, so remove it here. You still need to expand the commit msg and justify why this property is being removed. "Driver" is vague, as it can be BSD driver which also might use this binding. Instead describe why this property should be removed, so we can understand also ABI implications. > > Signed-off-by: Haibo Chen <haibo.chen@nxp.com> > > --- > v2: > -fix dt-binding-check issue, also remove "fsl,wp-controller" in examples. > --- > Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml | 6 ------ > 1 file changed, 6 deletions(-) Best regards, Krzysztof
On 5/6/2023 6:59 PM, Krzysztof Kozlowski wrote: > Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the message using the 'Report this email' button > > > On 06/05/2023 09:40, haibo.chen@nxp.com wrote: >> From: Haibo Chen <haibo.chen@nxp.com> >> >> Driver do not use this property, so remove it here. > > You still need to expand the commit msg and justify why this property is > being removed. "Driver" is vague, as it can be BSD driver which also > might use this binding. Instead describe why this property should be > removed, so we can understand also ABI implications. The better approach would be mark it as deprecated. Regards, Peng. > >> >> Signed-off-by: Haibo Chen <haibo.chen@nxp.com> >> >> --- >> v2: >> -fix dt-binding-check issue, also remove "fsl,wp-controller" in examples. >> --- >> Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml | 6 ------ >> 1 file changed, 6 deletions(-) > > Best regards, > Krzysztof >
On Tue, May 23, 2023 at 10:03:08AM +0800, Peng Fan wrote: > > > On 5/6/2023 6:59 PM, Krzysztof Kozlowski wrote: > > Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the message using the 'Report this email' button > > > > > > On 06/05/2023 09:40, haibo.chen@nxp.com wrote: > > > From: Haibo Chen <haibo.chen@nxp.com> > > > > > > Driver do not use this property, so remove it here. > > > > You still need to expand the commit msg and justify why this property is > > being removed. "Driver" is vague, as it can be BSD driver which also > > might use this binding. Instead describe why this property should be > > removed, so we can understand also ABI implications. > > The better approach would be mark it as deprecated. Sure, but still need to say why. Rob
diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml index fbfd822b9270..e34b4fb4778a 100644 --- a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml +++ b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml @@ -96,11 +96,6 @@ properties: interrupts: maxItems: 1 - fsl,wp-controller: - description: | - boolean, if present, indicate to use controller internal write protection. - type: boolean - fsl,delay-line: $ref: /schemas/types.yaml#/definitions/uint32 description: | @@ -190,7 +185,6 @@ examples: compatible = "fsl,imx51-esdhc"; reg = <0x70004000 0x4000>; interrupts = <1>; - fsl,wp-controller; }; mmc@70008000 {