| Message ID | 20230506-msm8226-ocmem-v2-4-177d697e43a9@z3ntu.xyz |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Add MSM8226 OCMEM support plus some extra OCMEM driver fixes | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Tue, May 23, 2023 at 10:55:11PM +0200, Luca Weiss wrote: > Add the compatible for the OCMEM found on msm8226 which compared to > msm8974 only has a core clock and no iface clock. > > Signed-off-by: Luca Weiss <luca@z3ntu.xyz> Could you please either send me the cover-letter or include the changelog in the patch under the ---? Otherwise, Reviewed-by: Conor Dooley <conor.dooley@microchip.com> Thanks, Conor.
On Wed, May 24, 2023 at 09:34:06PM +0100, Conor Dooley wrote: > On Tue, May 23, 2023 at 10:55:11PM +0200, Luca Weiss wrote: > > Add the compatible for the OCMEM found on msm8226 which compared to > > msm8974 only has a core clock and no iface clock. > > > > Signed-off-by: Luca Weiss <luca@z3ntu.xyz> > > Could you please either send me the cover-letter or include the > changelog in the patch under the ---? Apparently I did get the cover, but in another mailbox for IDK what reason. Sorry! > > Otherwise, > Reviewed-by: Conor Dooley <conor.dooley@microchip.com> > > Thanks, > Conor.
On 23/05/2023 22:55, Luca Weiss wrote: > Add the compatible for the OCMEM found on msm8226 which compared to > msm8974 only has a core clock and no iface clock. > > Signed-off-by: Luca Weiss <luca@z3ntu.xyz> > --- > .../devicetree/bindings/sram/qcom,ocmem.yaml | 20 +++++++++++++++++++- > 1 file changed, 19 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/sram/qcom,ocmem.yaml b/Documentation/devicetree/bindings/sram/qcom,ocmem.yaml > index 4bbf6db0b6bd..02e4da9649fd 100644 > --- a/Documentation/devicetree/bindings/sram/qcom,ocmem.yaml > +++ b/Documentation/devicetree/bindings/sram/qcom,ocmem.yaml > @@ -15,7 +15,9 @@ description: | > > properties: > compatible: > - const: qcom,msm8974-ocmem > + enum: > + - qcom,msm8226-ocmem # v1.1.0 > + - qcom,msm8974-ocmem # v1.4.0 > > reg: > items: > @@ -28,11 +30,13 @@ properties: > - const: mem > > clocks: > + minItems: 1 > items: > - description: Core clock > - description: Interface clock > > clock-names: > + minItems: 1 > items: > - const: core > - const: iface > @@ -58,6 +62,20 @@ required: > > additionalProperties: false > > +allOf: > + - if: > + properties: > + compatible: > + contains: > + enum: > + - qcom,msm8974-ocmem > + then: > + properties: > + clocks: > + minItems: 2 > + clock-names: > + minItems: 2 else: maxItems: 1? Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/sram/qcom,ocmem.yaml b/Documentation/devicetree/bindings/sram/qcom,ocmem.yaml index 4bbf6db0b6bd..02e4da9649fd 100644 --- a/Documentation/devicetree/bindings/sram/qcom,ocmem.yaml +++ b/Documentation/devicetree/bindings/sram/qcom,ocmem.yaml @@ -15,7 +15,9 @@ description: | properties: compatible: - const: qcom,msm8974-ocmem + enum: + - qcom,msm8226-ocmem # v1.1.0 + - qcom,msm8974-ocmem # v1.4.0 reg: items: @@ -28,11 +30,13 @@ properties: - const: mem clocks: + minItems: 1 items: - description: Core clock - description: Interface clock clock-names: + minItems: 1 items: - const: core - const: iface @@ -58,6 +62,20 @@ required: additionalProperties: false +allOf: + - if: + properties: + compatible: + contains: + enum: + - qcom,msm8974-ocmem + then: + properties: + clocks: + minItems: 2 + clock-names: + minItems: 2 + patternProperties: "-sram@[0-9a-f]+$": type: object
Add the compatible for the OCMEM found on msm8226 which compared to msm8974 only has a core clock and no iface clock. Signed-off-by: Luca Weiss <luca@z3ntu.xyz> --- .../devicetree/bindings/sram/qcom,ocmem.yaml | 20 +++++++++++++++++++- 1 file changed, 19 insertions(+), 1 deletion(-)