| Message ID | 20230503084608.14008-4-biju.das.jz@bp.renesas.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | Add Renesas PMIC RAA215300 and built-in RTC support | expand |
| Context | Check | Description |
|---|---|---|
| robh/patch-applied | success | |
| robh/checkpatch | warning | total: 0 errors, 2 warnings, 74 lines checked |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
Hi all, > -----Original Message----- > From: Biju Das <biju.das.jz@bp.renesas.com> > Sent: Wednesday, May 3, 2023 9:46 AM > To: Alessandro Zummo <a.zummo@towertech.it>; Alexandre Belloni > <alexandre.belloni@bootlin.com>; Rob Herring <robh+dt@kernel.org>; Krzysztof > Kozlowski <krzysztof.kozlowski+dt@linaro.org> > Cc: Biju Das <biju.das.jz@bp.renesas.com>; Trent Piepho > <tpiepho@impinj.com>; linux-rtc@vger.kernel.org; devicetree@vger.kernel.org; > Geert Uytterhoeven <geert+renesas@glider.be>; Fabrizio Castro > <fabrizio.castro.jz@renesas.com>; linux-renesas-soc@vger.kernel.org > Subject: [PATCH RFC 3/6] dt-bindings: rtc: isl1208: Convert to json-schema > > Convert the isl1208 RTC device tree binding documentation to json-schema. > > Update the example to match reality. > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > --- > .../devicetree/bindings/rtc/isil,isl1208.txt | 38 ---------- > .../devicetree/bindings/rtc/isil,isl1208.yaml | 74 +++++++++++++++++++ > 2 files changed, 74 insertions(+), 38 deletions(-) delete mode 100644 > Documentation/devicetree/bindings/rtc/isil,isl1208.txt > create mode 100644 Documentation/devicetree/bindings/rtc/isil,isl1208.yaml > > diff --git a/Documentation/devicetree/bindings/rtc/isil,isl1208.txt > b/Documentation/devicetree/bindings/rtc/isil,isl1208.txt > deleted file mode 100644 > index 51f003006f04..000000000000 > --- a/Documentation/devicetree/bindings/rtc/isil,isl1208.txt > +++ /dev/null > @@ -1,38 +0,0 @@ > -Intersil ISL1209/19 I2C RTC/Alarm chip with event in > - > -ISL12X9 have additional pins EVIN and #EVDET for tamper detection, while > the > -ISL1208 and ISL1218 do not. They are all use the same driver with the > bindings -described here, with chip specific properties as noted. > - > -Required properties supported by the device: > - - "compatible": Should be one of the following: > - - "isil,isl1208" > - - "isil,isl1209" > - - "isil,isl1218" > - - "isil,isl1219" > - - "reg": I2C bus address of the device > - > -Optional properties: > - - "interrupt-names": list which may contains "irq" and "evdet" > - evdet applies to isl1209 and isl1219 only > - - "interrupts": list of interrupts for "irq" and "evdet" > - evdet applies to isl1209 and isl1219 only > - - "isil,ev-evienb": Enable or disable internal pull on EVIN pin > - Applies to isl1209 and isl1219 only > - Possible values are 0 and 1 > - Value 0 enables internal pull-up on evin pin, 1 disables it. > - Default will leave the non-volatile configuration of the pullup > - as is. > - > -Example isl1219 node with #IRQ pin connected to SoC gpio1 pin12 and #EVDET > pin -connected to SoC gpio2 pin 24 and internal pull-up enabled in EVIN pin. > - > - isl1219: rtc@68 { > - compatible = "isil,isl1219"; > - reg = <0x68>; > - interrupt-names = "irq", "evdet"; > - interrupts-extended = <&gpio1 12 IRQ_TYPE_EDGE_FALLING>, > - <&gpio2 24 IRQ_TYPE_EDGE_FALLING>; > - isil,ev-evienb = <1>; > - }; > - > diff --git a/Documentation/devicetree/bindings/rtc/isil,isl1208.yaml > b/Documentation/devicetree/bindings/rtc/isil,isl1208.yaml > new file mode 100644 > index 000000000000..04d51887855f > --- /dev/null > +++ b/Documentation/devicetree/bindings/rtc/isil,isl1208.yaml > @@ -0,0 +1,74 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 > +--- > +$id: > +https://jpn01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevice > +tree.org%2Fschemas%2Frtc%2Fisil%2Cisl1208.yaml%23&data=05%7C01%7Cbiju.d > +as.jz%40bp.renesas.com%7C369929b1ce554af8b10008db4bb2e184%7C53d82571da1 > +947e49cb4625a166a4a2a%7C0%7C0%7C638187003880337413%7CUnknown%7CTWFpbGZs > +b3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D% > +7C3000%7C%7C%7C&sdata=hhWJWxRzJEgudMmnw%2Fl9DgpL0%2BaPRWfWDK2mGqztl3c%3 > +D&reserved=0 > +$schema: > +https://jpn01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevice > +tree.org%2Fmeta-schemas%2Fcore.yaml%23&data=05%7C01%7Cbiju.das.jz%40bp. > +renesas.com%7C369929b1ce554af8b10008db4bb2e184%7C53d82571da1947e49cb462 > +5a166a4a2a%7C0%7C0%7C638187003880337413%7CUnknown%7CTWFpbGZsb3d8eyJWIjo > +iMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7 > +C%7C&sdata=figbanniGklELxfV4t10SVsg4i0X%2Bozm68rxXy4pupg%3D&reserved=0 > + > +title: Intersil ISL12{08,09,18,19} I2C RTC/Alarm chip > + > +maintainers: > + - Biju Das <biju.das.jz@bp.renesas.com> > + - Trent Piepho <tpiepho@impinj.com> > + > +properties: > + compatible: > + oneOf: > + - enum: > + - isil,isl1208 > + - isil,isl1209 > + - isil,isl1218 > + - isil,isl1219 > + > + reg: > + maxItems: 1 > + > + interrupts: > + minItems: 1 > + maxItems: 2 > + > + interrupt-names: > + items: > + - const: irq > + - const: evdet > + > + isil,ev-evienb: > + $ref: /schemas/types.yaml#/definitions/uint32 > + enum: [ 0, 1 ] > + default: 0 Not sure, default should be removes as per [1]? [1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/rtc/isil,isl1208.txt?h=next-20230428#n20 Cheers, Biju > + description: | > + Enable or disable internal pull on EVIN pin: > + <0> : Enable internal pull-up > + <1> : Disable internal pull-up > + > +required: > + - compatible > + - reg > + > +allOf: > + - $ref: rtc.yaml# > + - if: > + properties: > + compatible: > + contains: > + enum: > + - isil,isl1209 > + - isil,isl1219 > + then: > + required: > + - interrupts-extended > + - interrupt-names > + - isil,ev-evienb > + > +unevaluatedProperties: false > + > +examples: > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + rtc_twi: rtc@6f { > + compatible = "isil,isl1208"; > + reg = <0x6f>; > + }; > + }; > -- > 2.25.1
Hi Biju, On Wed, May 3, 2023 at 10:46 AM Biju Das <biju.das.jz@bp.renesas.com> wrote: > Convert the isl1208 RTC device tree binding documentation to json-schema. > > Update the example to match reality. > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> Thanks for your patch! > --- a/Documentation/devicetree/bindings/rtc/isil,isl1208.txt > +++ /dev/null > @@ -1,38 +0,0 @@ > -Intersil ISL1209/19 I2C RTC/Alarm chip with event in > - > -ISL12X9 have additional pins EVIN and #EVDET for tamper detection, while the > -ISL1208 and ISL1218 do not. They are all use the same driver with the bindings > -described here, with chip specific properties as noted. > - > -Required properties supported by the device: > - - "compatible": Should be one of the following: > - - "isil,isl1208" > - - "isil,isl1209" > - - "isil,isl1218" > - - "isil,isl1219" > - - "reg": I2C bus address of the device > - > -Optional properties: > - - "interrupt-names": list which may contains "irq" and "evdet" > - evdet applies to isl1209 and isl1219 only > - - "interrupts": list of interrupts for "irq" and "evdet" > - evdet applies to isl1209 and isl1219 only > - - "isil,ev-evienb": Enable or disable internal pull on EVIN pin > - Applies to isl1209 and isl1219 only > - Possible values are 0 and 1 > - Value 0 enables internal pull-up on evin pin, 1 disables it. > - Default will leave the non-volatile configuration of the pullup > - as is. > - > -Example isl1219 node with #IRQ pin connected to SoC gpio1 pin12 and #EVDET pin > -connected to SoC gpio2 pin 24 and internal pull-up enabled in EVIN pin. > - > - isl1219: rtc@68 { > - compatible = "isil,isl1219"; > - reg = <0x68>; > - interrupt-names = "irq", "evdet"; > - interrupts-extended = <&gpio1 12 IRQ_TYPE_EDGE_FALLING>, > - <&gpio2 24 IRQ_TYPE_EDGE_FALLING>; > - isil,ev-evienb = <1>; > - }; > - > diff --git a/Documentation/devicetree/bindings/rtc/isil,isl1208.yaml b/Documentation/devicetree/bindings/rtc/isil,isl1208.yaml > new file mode 100644 > index 000000000000..04d51887855f > --- /dev/null > +++ b/Documentation/devicetree/bindings/rtc/isil,isl1208.yaml > @@ -0,0 +1,74 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/rtc/isil,isl1208.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Intersil ISL12{08,09,18,19} I2C RTC/Alarm chip > + > +maintainers: > + - Biju Das <biju.das.jz@bp.renesas.com> > + - Trent Piepho <tpiepho@impinj.com> > + > +properties: > + compatible: > + oneOf: > + - enum: > + - isil,isl1208 > + - isil,isl1209 > + - isil,isl1218 > + - isil,isl1219 > + > + reg: > + maxItems: 1 > + > + interrupts: > + minItems: 1 > + maxItems: 2 > + > + interrupt-names: > + items: > + - const: irq > + - const: evdet > + > + isil,ev-evienb: > + $ref: /schemas/types.yaml#/definitions/uint32 > + enum: [ 0, 1 ] > + default: 0 > + description: | > + Enable or disable internal pull on EVIN pin: > + <0> : Enable internal pull-up > + <1> : Disable internal pull-up > + > +required: > + - compatible > + - reg > + > +allOf: > + - $ref: rtc.yaml# > + - if: > + properties: > + compatible: > + contains: > + enum: > + - isil,isl1209 > + - isil,isl1219 > + then: > + required: > + - interrupts-extended interrupts (-extended is handled by the tooling) > + - interrupt-names > + - isil,ev-evienb else interrupts maxitems 1? > + > +unevaluatedProperties: false > + > +examples: > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + rtc_twi: rtc@6f { > + compatible = "isil,isl1208"; > + reg = <0x6f>; > + }; Is there any specific reason you changed the example from the most complex to the most simplest case? > + }; > -- > 2.25.1 Gr{oetje,eeting}s, Geert
CC Trent's latest address On Wed, May 3, 2023 at 11:25 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > Hi Biju, > > On Wed, May 3, 2023 at 10:46 AM Biju Das <biju.das.jz@bp.renesas.com> wrote: > > Convert the isl1208 RTC device tree binding documentation to json-schema. > > > > Update the example to match reality. > > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > Thanks for your patch! > > > --- a/Documentation/devicetree/bindings/rtc/isil,isl1208.txt > > +++ /dev/null > > @@ -1,38 +0,0 @@ > > -Intersil ISL1209/19 I2C RTC/Alarm chip with event in > > - > > -ISL12X9 have additional pins EVIN and #EVDET for tamper detection, while the > > -ISL1208 and ISL1218 do not. They are all use the same driver with the bindings > > -described here, with chip specific properties as noted. > > - > > -Required properties supported by the device: > > - - "compatible": Should be one of the following: > > - - "isil,isl1208" > > - - "isil,isl1209" > > - - "isil,isl1218" > > - - "isil,isl1219" > > - - "reg": I2C bus address of the device > > - > > -Optional properties: > > - - "interrupt-names": list which may contains "irq" and "evdet" > > - evdet applies to isl1209 and isl1219 only > > - - "interrupts": list of interrupts for "irq" and "evdet" > > - evdet applies to isl1209 and isl1219 only > > - - "isil,ev-evienb": Enable or disable internal pull on EVIN pin > > - Applies to isl1209 and isl1219 only > > - Possible values are 0 and 1 > > - Value 0 enables internal pull-up on evin pin, 1 disables it. > > - Default will leave the non-volatile configuration of the pullup > > - as is. > > - > > -Example isl1219 node with #IRQ pin connected to SoC gpio1 pin12 and #EVDET pin > > -connected to SoC gpio2 pin 24 and internal pull-up enabled in EVIN pin. > > - > > - isl1219: rtc@68 { > > - compatible = "isil,isl1219"; > > - reg = <0x68>; > > - interrupt-names = "irq", "evdet"; > > - interrupts-extended = <&gpio1 12 IRQ_TYPE_EDGE_FALLING>, > > - <&gpio2 24 IRQ_TYPE_EDGE_FALLING>; > > - isil,ev-evienb = <1>; > > - }; > > - > > diff --git a/Documentation/devicetree/bindings/rtc/isil,isl1208.yaml b/Documentation/devicetree/bindings/rtc/isil,isl1208.yaml > > new file mode 100644 > > index 000000000000..04d51887855f > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/rtc/isil,isl1208.yaml > > @@ -0,0 +1,74 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/rtc/isil,isl1208.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Intersil ISL12{08,09,18,19} I2C RTC/Alarm chip > > + > > +maintainers: > > + - Biju Das <biju.das.jz@bp.renesas.com> > > + - Trent Piepho <tpiepho@impinj.com> > > + > > +properties: > > + compatible: > > + oneOf: > > + - enum: > > + - isil,isl1208 > > + - isil,isl1209 > > + - isil,isl1218 > > + - isil,isl1219 > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + minItems: 1 > > + maxItems: 2 > > + > > + interrupt-names: > > + items: > > + - const: irq > > + - const: evdet > > + > > + isil,ev-evienb: > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + enum: [ 0, 1 ] > > + default: 0 > > + description: | > > + Enable or disable internal pull on EVIN pin: > > + <0> : Enable internal pull-up > > + <1> : Disable internal pull-up > > + > > +required: > > + - compatible > > + - reg > > + > > +allOf: > > + - $ref: rtc.yaml# > > + - if: > > + properties: > > + compatible: > > + contains: > > + enum: > > + - isil,isl1209 > > + - isil,isl1219 > > + then: > > + required: > > + - interrupts-extended > > interrupts (-extended is handled by the tooling) > > > + - interrupt-names > > + - isil,ev-evienb > > else interrupts maxitems 1? > > > + > > +unevaluatedProperties: false > > + > > +examples: > > + - | > > + i2c { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + rtc_twi: rtc@6f { > > + compatible = "isil,isl1208"; > > + reg = <0x6f>; > > + }; > > Is there any specific reason you changed the example from the most > complex to the most simplest case? > > > + }; > > -- > > 2.25.1 > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
Hi Geert, Thanks for the feedback. > Subject: Re: [PATCH RFC 3/6] dt-bindings: rtc: isl1208: Convert to json- > schema > > Hi Biju, > > On Wed, May 3, 2023 at 10:46 AM Biju Das <biju.das.jz@bp.renesas.com> wrote: > > Convert the isl1208 RTC device tree binding documentation to json-schema. > > > > Update the example to match reality. > > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > Thanks for your patch! > > > --- a/Documentation/devicetree/bindings/rtc/isil,isl1208.txt > > +++ /dev/null > > @@ -1,38 +0,0 @@ > > -Intersil ISL1209/19 I2C RTC/Alarm chip with event in > > - > > -ISL12X9 have additional pins EVIN and #EVDET for tamper detection, > > while the > > -ISL1208 and ISL1218 do not. They are all use the same driver with > > the bindings -described here, with chip specific properties as noted. > > - > > -Required properties supported by the device: > > - - "compatible": Should be one of the following: > > - - "isil,isl1208" > > - - "isil,isl1209" > > - - "isil,isl1218" > > - - "isil,isl1219" > > - - "reg": I2C bus address of the device > > - > > -Optional properties: > > - - "interrupt-names": list which may contains "irq" and "evdet" > > - evdet applies to isl1209 and isl1219 only > > - - "interrupts": list of interrupts for "irq" and "evdet" > > - evdet applies to isl1209 and isl1219 only > > - - "isil,ev-evienb": Enable or disable internal pull on EVIN pin > > - Applies to isl1209 and isl1219 only > > - Possible values are 0 and 1 > > - Value 0 enables internal pull-up on evin pin, 1 disables it. > > - Default will leave the non-volatile configuration of the pullup > > - as is. > > - > > -Example isl1219 node with #IRQ pin connected to SoC gpio1 pin12 and > > #EVDET pin -connected to SoC gpio2 pin 24 and internal pull-up enabled in > EVIN pin. > > - > > - isl1219: rtc@68 { > > - compatible = "isil,isl1219"; > > - reg = <0x68>; > > - interrupt-names = "irq", "evdet"; > > - interrupts-extended = <&gpio1 12 IRQ_TYPE_EDGE_FALLING>, > > - <&gpio2 24 IRQ_TYPE_EDGE_FALLING>; > > - isil,ev-evienb = <1>; > > - }; > > - > > diff --git a/Documentation/devicetree/bindings/rtc/isil,isl1208.yaml > > b/Documentation/devicetree/bindings/rtc/isil,isl1208.yaml > > new file mode 100644 > > index 000000000000..04d51887855f > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/rtc/isil,isl1208.yaml > > @@ -0,0 +1,74 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 > > +--- > > +$id: > > +https://jpn01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi > > +cetree.org%2Fschemas%2Frtc%2Fisil%2Cisl1208.yaml%23&data=05%7C01%7Cbi > > +ju.das.jz%40bp.renesas.com%7C321f62730bc24f076af608db4bb861fa%7C53d82 > > +571da1947e49cb4625a166a4a2a%7C0%7C0%7C638187027511491836%7CUnknown%7C > > +TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXV > > +CI6Mn0%3D%7C3000%7C%7C%7C&sdata=wzxyh4VtGR8ZHpirUIX04Zo7aaj6jaScAvD0U > > +8sfoXg%3D&reserved=0 > > +$schema: > > +https://jpn01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi > > +cetree.org%2Fmeta-schemas%2Fcore.yaml%23&data=05%7C01%7Cbiju.das.jz%4 > > +0bp.renesas.com%7C321f62730bc24f076af608db4bb861fa%7C53d82571da1947e4 > > +9cb4625a166a4a2a%7C0%7C0%7C638187027511491836%7CUnknown%7CTWFpbGZsb3d > > +8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7 > > +C3000%7C%7C%7C&sdata=4wWCv23cLyO%2BSDa4Ng4ptuciHZ%2BNo%2FozoRLKIbUtnM > > +A%3D&reserved=0 > > + > > +title: Intersil ISL12{08,09,18,19} I2C RTC/Alarm chip > > + > > +maintainers: > > + - Biju Das <biju.das.jz@bp.renesas.com> > > + - Trent Piepho <tpiepho@impinj.com> > > + > > +properties: > > + compatible: > > + oneOf: > > + - enum: > > + - isil,isl1208 > > + - isil,isl1209 > > + - isil,isl1218 > > + - isil,isl1219 > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + minItems: 1 > > + maxItems: 2 > > + > > + interrupt-names: > > + items: > > + - const: irq > > + - const: evdet > > + > > + isil,ev-evienb: > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + enum: [ 0, 1 ] > > + default: 0 > > + description: | > > + Enable or disable internal pull on EVIN pin: > > + <0> : Enable internal pull-up > > + <1> : Disable internal pull-up > > + > > +required: > > + - compatible > > + - reg > > + > > +allOf: > > + - $ref: rtc.yaml# > > + - if: > > + properties: > > + compatible: > > + contains: > > + enum: > > + - isil,isl1209 > > + - isil,isl1219 > > + then: > > + required: > > + - interrupts-extended > > interrupts (-extended is handled by the tooling) I got binding check warning for the example, where I used example with complex case with interrupts-extended property. > > > + - interrupt-names > > + - isil,ev-evienb > > else interrupts maxitems 1? OK I will add it in next version. Most of the dts doesn't define interrupts. Since it is optional It is Ok. > > > + > > +unevaluatedProperties: false > > + > > +examples: > > + - | > > + i2c { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + rtc_twi: rtc@6f { > > + compatible = "isil,isl1208"; > > + reg = <0x6f>; > > + }; > > Is there any specific reason you changed the example from the most complex > to the most simplest case? I did not find actual dts with complex use case in the kernel tree. Cheers, Biju > > > + }; > > -- > > 2.25.1 > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux- > m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like > that. > -- Linus Torvalds
Hi All, > Subject: RE: [PATCH RFC 3/6] dt-bindings: rtc: isl1208: Convert to json- > schema > > > > > > -----Original Message----- > > From: Biju Das <biju.das.jz@bp.renesas.com> > > Sent: Wednesday, May 3, 2023 9:46 AM > > To: Alessandro Zummo <a.zummo@towertech.it>; Alexandre Belloni > > <alexandre.belloni@bootlin.com>; Rob Herring <robh+dt@kernel.org>; > > Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> > > Cc: Biju Das <biju.das.jz@bp.renesas.com>; Trent Piepho > > <tpiepho@impinj.com>; linux-rtc@vger.kernel.org; > > devicetree@vger.kernel.org; Geert Uytterhoeven > > <geert+renesas@glider.be>; Fabrizio Castro > > <fabrizio.castro.jz@renesas.com>; linux-renesas-soc@vger.kernel.org > > Subject: [PATCH RFC 3/6] dt-bindings: rtc: isl1208: Convert to > > json-schema > > > > Convert the isl1208 RTC device tree binding documentation to json-schema. > > > > Update the example to match reality. > > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > --- > > .../devicetree/bindings/rtc/isil,isl1208.txt | 38 ---------- > > .../devicetree/bindings/rtc/isil,isl1208.yaml | 74 +++++++++++++++++++ > > 2 files changed, 74 insertions(+), 38 deletions(-) delete mode > > 100644 Documentation/devicetree/bindings/rtc/isil,isl1208.txt > > create mode 100644 > > Documentation/devicetree/bindings/rtc/isil,isl1208.yaml > > > > diff --git a/Documentation/devicetree/bindings/rtc/isil,isl1208.txt > > b/Documentation/devicetree/bindings/rtc/isil,isl1208.txt > > deleted file mode 100644 > > index 51f003006f04..000000000000 > > --- a/Documentation/devicetree/bindings/rtc/isil,isl1208.txt > > +++ /dev/null > > @@ -1,38 +0,0 @@ > > -Intersil ISL1209/19 I2C RTC/Alarm chip with event in > > - > > -ISL12X9 have additional pins EVIN and #EVDET for tamper detection, > > while the > > -ISL1208 and ISL1218 do not. They are all use the same driver with > > the bindings -described here, with chip specific properties as noted. > > - > > -Required properties supported by the device: > > - - "compatible": Should be one of the following: > > - - "isil,isl1208" > > - - "isil,isl1209" > > - - "isil,isl1218" > > - - "isil,isl1219" > > - - "reg": I2C bus address of the device > > - > > -Optional properties: > > - - "interrupt-names": list which may contains "irq" and "evdet" > > - evdet applies to isl1209 and isl1219 only > > - - "interrupts": list of interrupts for "irq" and "evdet" > > - evdet applies to isl1209 and isl1219 only > > - - "isil,ev-evienb": Enable or disable internal pull on EVIN pin > > - Applies to isl1209 and isl1219 only > > - Possible values are 0 and 1 > > - Value 0 enables internal pull-up on evin pin, 1 disables it. > > - Default will leave the non-volatile configuration of the pullup > > - as is. > > - > > -Example isl1219 node with #IRQ pin connected to SoC gpio1 pin12 and > > #EVDET pin -connected to SoC gpio2 pin 24 and internal pull-up enabled in > EVIN pin. > > - > > - isl1219: rtc@68 { > > - compatible = "isil,isl1219"; > > - reg = <0x68>; > > - interrupt-names = "irq", "evdet"; > > - interrupts-extended = <&gpio1 12 IRQ_TYPE_EDGE_FALLING>, > > - <&gpio2 24 IRQ_TYPE_EDGE_FALLING>; > > - isil,ev-evienb = <1>; > > - }; > > - > > diff --git a/Documentation/devicetree/bindings/rtc/isil,isl1208.yaml > > b/Documentation/devicetree/bindings/rtc/isil,isl1208.yaml > > new file mode 100644 > > index 000000000000..04d51887855f > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/rtc/isil,isl1208.yaml > > @@ -0,0 +1,74 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 > > +--- > > +$id: > > +https://jpn01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi > > +ce > > +tree.org%2Fschemas%2Frtc%2Fisil%2Cisl1208.yaml%23&data=05%7C01%7Cbiju > > +.d > > +as.jz%40bp.renesas.com%7C369929b1ce554af8b10008db4bb2e184%7C53d82571d > > +a1 > > +947e49cb4625a166a4a2a%7C0%7C0%7C638187003880337413%7CUnknown%7CTWFpbG > > +Zs > > +b3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3 > > +D% > > +7C3000%7C%7C%7C&sdata=hhWJWxRzJEgudMmnw%2Fl9DgpL0%2BaPRWfWDK2mGqztl3c > > +%3 > > +D&reserved=0 > > +$schema: > > +https://jpn01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi > > +ce > > +tree.org%2Fmeta-schemas%2Fcore.yaml%23&data=05%7C01%7Cbiju.das.jz%40bp. > > +renesas.com%7C369929b1ce554af8b10008db4bb2e184%7C53d82571da1947e49cb4 > > +62 > > +5a166a4a2a%7C0%7C0%7C638187003880337413%7CUnknown%7CTWFpbGZsb3d8eyJWI > > +jo > > +iMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C > > +%7 > > +C%7C&sdata=figbanniGklELxfV4t10SVsg4i0X%2Bozm68rxXy4pupg%3D&reserved= > > +0 > > + > > +title: Intersil ISL12{08,09,18,19} I2C RTC/Alarm chip > > + > > +maintainers: > > + - Biju Das <biju.das.jz@bp.renesas.com> > > + - Trent Piepho <tpiepho@impinj.com> > > + > > +properties: > > + compatible: > > + oneOf: > > + - enum: > > + - isil,isl1208 > > + - isil,isl1209 > > + - isil,isl1218 > > + - isil,isl1219 > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + minItems: 1 > > + maxItems: 2 > > + > > + interrupt-names: > > + items: > > + - const: irq > > + - const: evdet > > + > > + isil,ev-evienb: > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + enum: [ 0, 1 ] > > + default: 0 > > Not sure, default should be removed as per [1]? > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux- > next.git/tree/Documentation/devicetree/bindings/rtc/isil,isl1208.txt?h=next- > 20230428#n20 Or as per HW data sheet[1], the reset value is 0, so we should keep the default value. [2] https://www.renesas.com/us/en/document/dst/isl1219-datasheet Cheers, Biju > > > + description: | > > + Enable or disable internal pull on EVIN pin: > > + <0> : Enable internal pull-up > > + <1> : Disable internal pull-up > > + > > +required: > > + - compatible > > + - reg > > + > > +allOf: > > + - $ref: rtc.yaml# > > + - if: > > + properties: > > + compatible: > > + contains: > > + enum: > > + - isil,isl1209 > > + - isil,isl1219 > > + then: > > + required: > > + - interrupts-extended > > + - interrupt-names > > + - isil,ev-evienb > > + > > +unevaluatedProperties: false > > + > > +examples: > > + - | > > + i2c { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + rtc_twi: rtc@6f { > > + compatible = "isil,isl1208"; > > + reg = <0x6f>; > > + }; > > + }; > > -- > > 2.25.1
Hi Krzysztof Kozlowski and Rob, > > > <fabrizio.castro.jz@renesas.com>; linux-renesas-soc@vger.kernel.org > > > Subject: [PATCH RFC 3/6] dt-bindings: rtc: isl1208: Convert to > > > json-schema > > > > > > Convert the isl1208 RTC device tree binding documentation to json- > schema. > > > > > > Update the example to match reality. > > > > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > > --- > > > .../devicetree/bindings/rtc/isil,isl1208.txt | 38 ---------- > > > .../devicetree/bindings/rtc/isil,isl1208.yaml | 74 > > > +++++++++++++++++++ > > > 2 files changed, 74 insertions(+), 38 deletions(-) delete mode > > > 100644 Documentation/devicetree/bindings/rtc/isil,isl1208.txt > > > create mode 100644 > > > Documentation/devicetree/bindings/rtc/isil,isl1208.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/rtc/isil,isl1208.txt > > > b/Documentation/devicetree/bindings/rtc/isil,isl1208.txt > > > deleted file mode 100644 > > > index 51f003006f04..000000000000 > > > --- a/Documentation/devicetree/bindings/rtc/isil,isl1208.txt > > > +++ /dev/null > > > @@ -1,38 +0,0 @@ > > > -Intersil ISL1209/19 I2C RTC/Alarm chip with event in > > > - > > > -ISL12X9 have additional pins EVIN and #EVDET for tamper detection, > > > while the > > > -ISL1208 and ISL1218 do not. They are all use the same driver with > > > the bindings -described here, with chip specific properties as noted. > > > - > > > -Required properties supported by the device: > > > - - "compatible": Should be one of the following: > > > - - "isil,isl1208" > > > - - "isil,isl1209" > > > - - "isil,isl1218" > > > - - "isil,isl1219" > > > - - "reg": I2C bus address of the device > > > - > > > -Optional properties: > > > - - "interrupt-names": list which may contains "irq" and "evdet" > > > - evdet applies to isl1209 and isl1219 only > > > - - "interrupts": list of interrupts for "irq" and "evdet" > > > - evdet applies to isl1209 and isl1219 only > > > - - "isil,ev-evienb": Enable or disable internal pull on EVIN pin > > > - Applies to isl1209 and isl1219 only > > > - Possible values are 0 and 1 > > > - Value 0 enables internal pull-up on evin pin, 1 disables it. > > > - Default will leave the non-volatile configuration of the pullup > > > - as is. > > > - > > > -Example isl1219 node with #IRQ pin connected to SoC gpio1 pin12 and > > > #EVDET pin -connected to SoC gpio2 pin 24 and internal pull-up > > > enabled in > > EVIN pin. > > > - > > > - isl1219: rtc@68 { > > > - compatible = "isil,isl1219"; > > > - reg = <0x68>; > > > - interrupt-names = "irq", "evdet"; > > > - interrupts-extended = <&gpio1 12 IRQ_TYPE_EDGE_FALLING>, > > > - <&gpio2 24 IRQ_TYPE_EDGE_FALLING>; > > > - isil,ev-evienb = <1>; > > > - }; > > > - > > > diff --git a/Documentation/devicetree/bindings/rtc/isil,isl1208.yaml > > > b/Documentation/devicetree/bindings/rtc/isil,isl1208.yaml > > > new file mode 100644 > > > index 000000000000..04d51887855f > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/rtc/isil,isl1208.yaml > > > @@ -0,0 +1,74 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 > > > +--- > > > +$id: > > > + > > > +title: Intersil ISL12{08,09,18,19} I2C RTC/Alarm chip > > > + > > > +maintainers: > > > + - Biju Das <biju.das.jz@bp.renesas.com> > > > + - Trent Piepho <tpiepho@impinj.com> > > > + > > > +properties: > > > + compatible: > > > + oneOf: > > > + - enum: > > > + - isil,isl1208 > > > + - isil,isl1209 > > > + - isil,isl1218 > > > + - isil,isl1219 > > > + > > > + reg: > > > + maxItems: 1 > > > + > > > + interrupts: > > > + minItems: 1 > > > + maxItems: 2 > > > + > > > + interrupt-names: > > > + items: > > > + - const: irq > > > + - const: evdet > > > + > > > + isil,ev-evienb: > > > + $ref: /schemas/types.yaml#/definitions/uint32 > > > + enum: [ 0, 1 ] > > > + default: 0 What is your thoughts on this? we should keep default or we should remove? As per HW data sheet[1], the reset value is 0, [1] https://www.renesas.com/us/en/document/dst/isl1219-datasheet But as per text version of bindings [2], Looks like default is not needed. [2] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/rtc/isil,isl1208.txt?h=next-20230428#n20 Cheers, Biju
On 04/05/2023 18:22, Biju Das wrote: > Hi Krzysztof Kozlowski and Rob, > >>>> <fabrizio.castro.jz@renesas.com>; linux-renesas-soc@vger.kernel.org >>>> Subject: [PATCH RFC 3/6] dt-bindings: rtc: isl1208: Convert to >>>> json-schema >>>> >>>> Convert the isl1208 RTC device tree binding documentation to json- >> schema. >>>> >>>> Update the example to match reality. >>>> >>>> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> >>>> --- >>>> .../devicetree/bindings/rtc/isil,isl1208.txt | 38 ---------- >>>> .../devicetree/bindings/rtc/isil,isl1208.yaml | 74 >>>> +++++++++++++++++++ >>>> 2 files changed, 74 insertions(+), 38 deletions(-) delete mode >>>> 100644 Documentation/devicetree/bindings/rtc/isil,isl1208.txt >>>> create mode 100644 >>>> Documentation/devicetree/bindings/rtc/isil,isl1208.yaml >>>> >>>> diff --git a/Documentation/devicetree/bindings/rtc/isil,isl1208.txt >>>> b/Documentation/devicetree/bindings/rtc/isil,isl1208.txt >>>> deleted file mode 100644 >>>> index 51f003006f04..000000000000 >>>> --- a/Documentation/devicetree/bindings/rtc/isil,isl1208.txt >>>> +++ /dev/null >>>> @@ -1,38 +0,0 @@ >>>> -Intersil ISL1209/19 I2C RTC/Alarm chip with event in >>>> - >>>> -ISL12X9 have additional pins EVIN and #EVDET for tamper detection, >>>> while the >>>> -ISL1208 and ISL1218 do not. They are all use the same driver with >>>> the bindings -described here, with chip specific properties as noted. >>>> - >>>> -Required properties supported by the device: >>>> - - "compatible": Should be one of the following: >>>> - - "isil,isl1208" >>>> - - "isil,isl1209" >>>> - - "isil,isl1218" >>>> - - "isil,isl1219" >>>> - - "reg": I2C bus address of the device >>>> - >>>> -Optional properties: >>>> - - "interrupt-names": list which may contains "irq" and "evdet" >>>> - evdet applies to isl1209 and isl1219 only >>>> - - "interrupts": list of interrupts for "irq" and "evdet" >>>> - evdet applies to isl1209 and isl1219 only >>>> - - "isil,ev-evienb": Enable or disable internal pull on EVIN pin >>>> - Applies to isl1209 and isl1219 only >>>> - Possible values are 0 and 1 >>>> - Value 0 enables internal pull-up on evin pin, 1 disables it. >>>> - Default will leave the non-volatile configuration of the pullup >>>> - as is. >>>> - >>>> -Example isl1219 node with #IRQ pin connected to SoC gpio1 pin12 and >>>> #EVDET pin -connected to SoC gpio2 pin 24 and internal pull-up >>>> enabled in >>> EVIN pin. >>>> - >>>> - isl1219: rtc@68 { >>>> - compatible = "isil,isl1219"; >>>> - reg = <0x68>; >>>> - interrupt-names = "irq", "evdet"; >>>> - interrupts-extended = <&gpio1 12 IRQ_TYPE_EDGE_FALLING>, >>>> - <&gpio2 24 IRQ_TYPE_EDGE_FALLING>; >>>> - isil,ev-evienb = <1>; >>>> - }; >>>> - >>>> diff --git a/Documentation/devicetree/bindings/rtc/isil,isl1208.yaml >>>> b/Documentation/devicetree/bindings/rtc/isil,isl1208.yaml >>>> new file mode 100644 >>>> index 000000000000..04d51887855f >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/rtc/isil,isl1208.yaml >>>> @@ -0,0 +1,74 @@ >>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 >>>> +--- >>>> +$id: >>>> + >>>> +title: Intersil ISL12{08,09,18,19} I2C RTC/Alarm chip >>>> + >>>> +maintainers: >>>> + - Biju Das <biju.das.jz@bp.renesas.com> >>>> + - Trent Piepho <tpiepho@impinj.com> >>>> + >>>> +properties: >>>> + compatible: >>>> + oneOf: >>>> + - enum: >>>> + - isil,isl1208 >>>> + - isil,isl1209 >>>> + - isil,isl1218 >>>> + - isil,isl1219 >>>> + >>>> + reg: >>>> + maxItems: 1 >>>> + >>>> + interrupts: >>>> + minItems: 1 >>>> + maxItems: 2 >>>> + >>>> + interrupt-names: >>>> + items: >>>> + - const: irq >>>> + - const: evdet >>>> + >>>> + isil,ev-evienb: >>>> + $ref: /schemas/types.yaml#/definitions/uint32 >>>> + enum: [ 0, 1 ] >>>> + default: 0 > > > What is your thoughts on this? we should keep default or we should remove? > > As per HW data sheet[1], the reset value is 0, > [1] https://www.renesas.com/us/en/document/dst/isl1219-datasheet > > But as per text version of bindings [2], Looks like default is not needed. Missing value has different meaning in original binding, so default is wrong here and you should explain that meaning in description. Best regards, Krzysztof
Hi Krzysztof Kozlowski, > Subject: Re: [PATCH RFC 3/6] dt-bindings: rtc: isl1208: Convert to json- > schema > > On 04/05/2023 18:22, Biju Das wrote: > > Hi Krzysztof Kozlowski and Rob, > > > >>>> <fabrizio.castro.jz@renesas.com>; linux-renesas-soc@vger.kernel.org > >>>> Subject: [PATCH RFC 3/6] dt-bindings: rtc: isl1208: Convert to > >>>> json-schema > >>>> > >>>> Convert the isl1208 RTC device tree binding documentation to json- > >> schema. > >>>> > >>>> Update the example to match reality. > >>>> > >>>> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > >>>> --- > >>>> .../devicetree/bindings/rtc/isil,isl1208.txt | 38 ---------- > >>>> .../devicetree/bindings/rtc/isil,isl1208.yaml | 74 > >>>> +++++++++++++++++++ > >>>> 2 files changed, 74 insertions(+), 38 deletions(-) delete mode > >>>> 100644 Documentation/devicetree/bindings/rtc/isil,isl1208.txt > >>>> create mode 100644 > >>>> Documentation/devicetree/bindings/rtc/isil,isl1208.yaml > >>>> > >>>> diff --git a/Documentation/devicetree/bindings/rtc/isil,isl1208.txt > >>>> b/Documentation/devicetree/bindings/rtc/isil,isl1208.txt > >>>> deleted file mode 100644 > >>>> index 51f003006f04..000000000000 > >>>> --- a/Documentation/devicetree/bindings/rtc/isil,isl1208.txt > >>>> +++ /dev/null > >>>> @@ -1,38 +0,0 @@ > >>>> -Intersil ISL1209/19 I2C RTC/Alarm chip with event in > >>>> - > >>>> -ISL12X9 have additional pins EVIN and #EVDET for tamper detection, > >>>> while the > >>>> -ISL1208 and ISL1218 do not. They are all use the same driver with > >>>> the bindings -described here, with chip specific properties as noted. > >>>> - > >>>> -Required properties supported by the device: > >>>> - - "compatible": Should be one of the following: > >>>> - - "isil,isl1208" > >>>> - - "isil,isl1209" > >>>> - - "isil,isl1218" > >>>> - - "isil,isl1219" > >>>> - - "reg": I2C bus address of the device > >>>> - > >>>> -Optional properties: > >>>> - - "interrupt-names": list which may contains "irq" and "evdet" > >>>> - evdet applies to isl1209 and isl1219 only > >>>> - - "interrupts": list of interrupts for "irq" and "evdet" > >>>> - evdet applies to isl1209 and isl1219 only > >>>> - - "isil,ev-evienb": Enable or disable internal pull on EVIN pin > >>>> - Applies to isl1209 and isl1219 only > >>>> - Possible values are 0 and 1 > >>>> - Value 0 enables internal pull-up on evin pin, 1 disables it. > >>>> - Default will leave the non-volatile configuration of the pullup > >>>> - as is. > >>>> - > >>>> -Example isl1219 node with #IRQ pin connected to SoC gpio1 pin12 > >>>> and #EVDET pin -connected to SoC gpio2 pin 24 and internal pull-up > >>>> enabled in > >>> EVIN pin. > >>>> - > >>>> - isl1219: rtc@68 { > >>>> - compatible = "isil,isl1219"; > >>>> - reg = <0x68>; > >>>> - interrupt-names = "irq", "evdet"; > >>>> - interrupts-extended = <&gpio1 12 IRQ_TYPE_EDGE_FALLING>, > >>>> - <&gpio2 24 IRQ_TYPE_EDGE_FALLING>; > >>>> - isil,ev-evienb = <1>; > >>>> - }; > >>>> - > >>>> diff --git > >>>> a/Documentation/devicetree/bindings/rtc/isil,isl1208.yaml > >>>> b/Documentation/devicetree/bindings/rtc/isil,isl1208.yaml > >>>> new file mode 100644 > >>>> index 000000000000..04d51887855f > >>>> --- /dev/null > >>>> +++ b/Documentation/devicetree/bindings/rtc/isil,isl1208.yaml > >>>> @@ -0,0 +1,74 @@ > >>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML > >>>> +1.2 > >>>> +--- > >>>> +$id: > >>>> + > >>>> +title: Intersil ISL12{08,09,18,19} I2C RTC/Alarm chip > >>>> + > >>>> +maintainers: > >>>> + - Biju Das <biju.das.jz@bp.renesas.com> > >>>> + - Trent Piepho <tpiepho@impinj.com> > >>>> + > >>>> +properties: > >>>> + compatible: > >>>> + oneOf: > >>>> + - enum: > >>>> + - isil,isl1208 > >>>> + - isil,isl1209 > >>>> + - isil,isl1218 > >>>> + - isil,isl1219 > >>>> + > >>>> + reg: > >>>> + maxItems: 1 > >>>> + > >>>> + interrupts: > >>>> + minItems: 1 > >>>> + maxItems: 2 > >>>> + > >>>> + interrupt-names: > >>>> + items: > >>>> + - const: irq > >>>> + - const: evdet > >>>> + > >>>> + isil,ev-evienb: > >>>> + $ref: /schemas/types.yaml#/definitions/uint32 > >>>> + enum: [ 0, 1 ] > >>>> + default: 0 > > > > > > What is your thoughts on this? we should keep default or we should remove? > > > > As per HW data sheet[1], the reset value is 0, [1] > > https://www.renesas.com/us/en/document/dst/isl1219-datasheet > > > > But as per text version of bindings [2], Looks like default is not needed. > > Missing value has different meaning in original binding, so default is wrong > here and you should explain that meaning in description. OK, I will remove default and use the same description from the original bindings and send it as separate patch. Cheers, Biju
diff --git a/Documentation/devicetree/bindings/rtc/isil,isl1208.txt b/Documentation/devicetree/bindings/rtc/isil,isl1208.txt deleted file mode 100644 index 51f003006f04..000000000000 --- a/Documentation/devicetree/bindings/rtc/isil,isl1208.txt +++ /dev/null @@ -1,38 +0,0 @@ -Intersil ISL1209/19 I2C RTC/Alarm chip with event in - -ISL12X9 have additional pins EVIN and #EVDET for tamper detection, while the -ISL1208 and ISL1218 do not. They are all use the same driver with the bindings -described here, with chip specific properties as noted. - -Required properties supported by the device: - - "compatible": Should be one of the following: - - "isil,isl1208" - - "isil,isl1209" - - "isil,isl1218" - - "isil,isl1219" - - "reg": I2C bus address of the device - -Optional properties: - - "interrupt-names": list which may contains "irq" and "evdet" - evdet applies to isl1209 and isl1219 only - - "interrupts": list of interrupts for "irq" and "evdet" - evdet applies to isl1209 and isl1219 only - - "isil,ev-evienb": Enable or disable internal pull on EVIN pin - Applies to isl1209 and isl1219 only - Possible values are 0 and 1 - Value 0 enables internal pull-up on evin pin, 1 disables it. - Default will leave the non-volatile configuration of the pullup - as is. - -Example isl1219 node with #IRQ pin connected to SoC gpio1 pin12 and #EVDET pin -connected to SoC gpio2 pin 24 and internal pull-up enabled in EVIN pin. - - isl1219: rtc@68 { - compatible = "isil,isl1219"; - reg = <0x68>; - interrupt-names = "irq", "evdet"; - interrupts-extended = <&gpio1 12 IRQ_TYPE_EDGE_FALLING>, - <&gpio2 24 IRQ_TYPE_EDGE_FALLING>; - isil,ev-evienb = <1>; - }; - diff --git a/Documentation/devicetree/bindings/rtc/isil,isl1208.yaml b/Documentation/devicetree/bindings/rtc/isil,isl1208.yaml new file mode 100644 index 000000000000..04d51887855f --- /dev/null +++ b/Documentation/devicetree/bindings/rtc/isil,isl1208.yaml @@ -0,0 +1,74 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/rtc/isil,isl1208.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Intersil ISL12{08,09,18,19} I2C RTC/Alarm chip + +maintainers: + - Biju Das <biju.das.jz@bp.renesas.com> + - Trent Piepho <tpiepho@impinj.com> + +properties: + compatible: + oneOf: + - enum: + - isil,isl1208 + - isil,isl1209 + - isil,isl1218 + - isil,isl1219 + + reg: + maxItems: 1 + + interrupts: + minItems: 1 + maxItems: 2 + + interrupt-names: + items: + - const: irq + - const: evdet + + isil,ev-evienb: + $ref: /schemas/types.yaml#/definitions/uint32 + enum: [ 0, 1 ] + default: 0 + description: | + Enable or disable internal pull on EVIN pin: + <0> : Enable internal pull-up + <1> : Disable internal pull-up + +required: + - compatible + - reg + +allOf: + - $ref: rtc.yaml# + - if: + properties: + compatible: + contains: + enum: + - isil,isl1209 + - isil,isl1219 + then: + required: + - interrupts-extended + - interrupt-names + - isil,ev-evienb + +unevaluatedProperties: false + +examples: + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + + rtc_twi: rtc@6f { + compatible = "isil,isl1208"; + reg = <0x6f>; + }; + };
Convert the isl1208 RTC device tree binding documentation to json-schema. Update the example to match reality. Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> --- .../devicetree/bindings/rtc/isil,isl1208.txt | 38 ---------- .../devicetree/bindings/rtc/isil,isl1208.yaml | 74 +++++++++++++++++++ 2 files changed, 74 insertions(+), 38 deletions(-) delete mode 100644 Documentation/devicetree/bindings/rtc/isil,isl1208.txt create mode 100644 Documentation/devicetree/bindings/rtc/isil,isl1208.yaml