| Message ID | 20230418113217.781524-1-Naresh.Solanki@9elements.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | [1/2] dt-bindings: hwmon: Add binding for max6639 | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 18/04/2023 13:32, Naresh Solanki wrote: > Add Devicetree binding documentation for Maxim MAX6639 temperature > monitor with PWM fan-speed controller. Subject: drop second/last, redundant "binding for". The "dt-bindings" prefix is already stating that these are bindings. > > Signed-off-by: Naresh Solanki <Naresh.Solanki@9elements.com> > --- > .../bindings/hwmon/maxim,max6639.yaml | 55 +++++++++++++++++++ > 1 file changed, 55 insertions(+) > create mode 100644 Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml > > diff --git a/Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml b/Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml > new file mode 100644 > index 000000000000..20b28cd36555 > --- /dev/null > +++ b/Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml > @@ -0,0 +1,55 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > + Drop blank line This is v9. Where is the changelog? Where is previous authorship? At least some parts of it? Why this has less properties than old one? Why this has more mistakes than the old one? Go to previous patch... or fix everything which was already fixed. Best regards, Krzysztof
Hi Krysztof, On 18-04-2023 09:47 pm, Krzysztof Kozlowski wrote: > On 18/04/2023 13:32, Naresh Solanki wrote: >> Add Devicetree binding documentation for Maxim MAX6639 temperature >> monitor with PWM fan-speed controller. > > Subject: drop second/last, redundant "binding for". The "dt-bindings" > prefix is already stating that these are bindings. Ack > >> >> Signed-off-by: Naresh Solanki <Naresh.Solanki@9elements.com> >> --- >> .../bindings/hwmon/maxim,max6639.yaml | 55 +++++++++++++++++++ >> 1 file changed, 55 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml >> >> diff --git a/Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml b/Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml >> new file mode 100644 >> index 000000000000..20b28cd36555 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml >> @@ -0,0 +1,55 @@ >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> + > > Drop blank line Ack > > This is v9. Where is the changelog? Where is previous authorship? At > least some parts of it? Why this has less properties than old one? Why > this has more mistakes than the old one? Go to previous patch... or fix > everything which was already fixed. This patch is to add basic dt support only hence no additional properties. > > Best regards, > Krzysztof > Regards, Naresh
On 19/04/2023 11:00, Naresh Solanki wrote: > Hi Krysztof, > > On 18-04-2023 09:47 pm, Krzysztof Kozlowski wrote: >> On 18/04/2023 13:32, Naresh Solanki wrote: >>> Add Devicetree binding documentation for Maxim MAX6639 temperature >>> monitor with PWM fan-speed controller. >> >> Subject: drop second/last, redundant "binding for". The "dt-bindings" >> prefix is already stating that these are bindings. > Ack >> >>> >>> Signed-off-by: Naresh Solanki <Naresh.Solanki@9elements.com> >>> --- >>> .../bindings/hwmon/maxim,max6639.yaml | 55 +++++++++++++++++++ >>> 1 file changed, 55 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml b/Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml >>> new file mode 100644 >>> index 000000000000..20b28cd36555 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml >>> @@ -0,0 +1,55 @@ >>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> + >> >> Drop blank line > Ack >> >> This is v9. Where is the changelog? Where is previous authorship? At >> least some parts of it? Why this has less properties than old one? Why >> this has more mistakes than the old one? Go to previous patch... or fix >> everything which was already fixed. > This patch is to add basic dt support only hence no additional properties. How does that answer my questions? Best regards, Krzysztof
Hi On 19-04-2023 02:34 pm, Krzysztof Kozlowski wrote: > On 19/04/2023 11:00, Naresh Solanki wrote: >> Hi Krysztof, >> >> On 18-04-2023 09:47 pm, Krzysztof Kozlowski wrote: >>> On 18/04/2023 13:32, Naresh Solanki wrote: >>>> Add Devicetree binding documentation for Maxim MAX6639 temperature >>>> monitor with PWM fan-speed controller. >>> >>> Subject: drop second/last, redundant "binding for". The "dt-bindings" >>> prefix is already stating that these are bindings. >> Ack >>> >>>> >>>> Signed-off-by: Naresh Solanki <Naresh.Solanki@9elements.com> >>>> --- >>>> .../bindings/hwmon/maxim,max6639.yaml | 55 +++++++++++++++++++ >>>> 1 file changed, 55 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml >>>> >>>> diff --git a/Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml b/Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml >>>> new file mode 100644 >>>> index 000000000000..20b28cd36555 >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml >>>> @@ -0,0 +1,55 @@ >>>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >>>> +%YAML 1.2 >>>> +--- >>>> + >>> >>> Drop blank line >> Ack >>> >>> This is v9. Where is the changelog? Where is previous authorship? At >>> least some parts of it? Why this has less properties than old one? Why >>> this has more mistakes than the old one? Go to previous patch... or fix >>> everything which was already fixed. >> This patch is to add basic dt support only hence no additional properties. > > How does that answer my questions? This patch is intended to add dt support for the max6639 driver, and I did not take it from previous patches. As this is a basic dt binding, it has fewer properties compared to the old one. I have used v8 as a reference for this patch, and I will review it again to make sure I have not missed anything. Will ensure to fix them in the next patch. Although I cannot go back to the previous patch, I will address and fix any issues in this patchset. > > Best regards, > Krzysztof > Regards, Naresh
diff --git a/Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml b/Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml new file mode 100644 index 000000000000..20b28cd36555 --- /dev/null +++ b/Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml @@ -0,0 +1,55 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- + +$id: http://devicetree.org/schemas/hwmon/maxim,max6639.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Maxim max6639 Dual fan controller + +maintainers: + - Naresh Solanki <Naresh.Solanki@9elements.com> + +description: | + The MAX6639 is a 2-channel temperature monitor with dual, automatic, PWM + fan-speed controller. It monitors its own temperature and one external + diode-connected transistor or the temperatures of two external diode-connected + transistors, typically available in CPUs, FPGAs, or GPUs. + + Datasheets: + https://datasheets.maximintegrated.com/en/ds/MAX6639-MAX6639F.pdf + +properties: + compatible: + enum: + - maxim,max6639 + + reg: + maxItems: 1 + + '#address-cells': + const: 1 + + '#size-cells': + const: 0 + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + + max6639@10 { + compatible = "maxim,max6639"; + reg = <0x10>; + #address-cells = <1>; + #size-cells = <0>; + }; + }; +...
Add Devicetree binding documentation for Maxim MAX6639 temperature monitor with PWM fan-speed controller. Signed-off-by: Naresh Solanki <Naresh.Solanki@9elements.com> --- .../bindings/hwmon/maxim,max6639.yaml | 55 +++++++++++++++++++ 1 file changed, 55 insertions(+) create mode 100644 Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml base-commit: b8610e0fe08f1476895f141be60f8dd842f0adac