| Message ID | 20230414140203.707729-5-pan@semihalf.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Add Chameleon v3 ASoC audio | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dt-meta-schema | fail | build log |
On 14/04/2023 16:01, Paweł Anikiel wrote: > Add binding for it68051 device. > > Signed-off-by: Paweł Anikiel <pan@semihalf.com> > --- > .../bindings/sound/ite,it68051.yaml | 23 +++++++++++++++++++ > 1 file changed, 23 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/ite,it68051.yaml > > diff --git a/Documentation/devicetree/bindings/sound/ite,it68051.yaml b/Documentation/devicetree/bindings/sound/ite,it68051.yaml > new file mode 100644 > index 000000000000..341c171b8a8a > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/ite,it68051.yaml > @@ -0,0 +1,23 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/ite,it68051.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: it68051 audio codec > + > +maintainers: > + - Paweł Anikiel <pan@semihalf.com> > + > +properties: > + compatible: > + const: ite,it68051 > + No ref to common DAI properties? No sound-dai-cells? No resources? Bindings are supposed to be complete. > +required: > + - compatible > + > +examples: > + - | > + it68051: audio-codec { Drop label, you do not use it here. > + compatible = "ite,it68051"; > + }; Best regards, Krzysztof
On Fri, 14 Apr 2023 16:01:58 +0200, Paweł Anikiel wrote: > Add binding for it68051 device. > > Signed-off-by: Paweł Anikiel <pan@semihalf.com> > --- > .../bindings/sound/ite,it68051.yaml | 23 +++++++++++++++++++ > 1 file changed, 23 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/ite,it68051.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/ite,it68051.yaml: 'oneOf' conditional failed, one must be fixed: 'unevaluatedProperties' is a required property 'additionalProperties' is a required property hint: Either unevaluatedProperties or additionalProperties must be present from schema $id: http://devicetree.org/meta-schemas/core.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230414140203.707729-5-pan@semihalf.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
diff --git a/Documentation/devicetree/bindings/sound/ite,it68051.yaml b/Documentation/devicetree/bindings/sound/ite,it68051.yaml new file mode 100644 index 000000000000..341c171b8a8a --- /dev/null +++ b/Documentation/devicetree/bindings/sound/ite,it68051.yaml @@ -0,0 +1,23 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/ite,it68051.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: it68051 audio codec + +maintainers: + - Paweł Anikiel <pan@semihalf.com> + +properties: + compatible: + const: ite,it68051 + +required: + - compatible + +examples: + - | + it68051: audio-codec { + compatible = "ite,it68051"; + };
Add binding for it68051 device. Signed-off-by: Paweł Anikiel <pan@semihalf.com> --- .../bindings/sound/ite,it68051.yaml | 23 +++++++++++++++++++ 1 file changed, 23 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/ite,it68051.yaml