| Message ID | 20230412025737.20280-2-mibodhi@gmail.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Add support for Thecus N2350 board | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dt-meta-schema | fail | build log |
On 12/04/2023 04:57, Tony Dinh wrote: > Add device tree binding for Marvell Armada 38x. > > Signed-off-by: Tony Dinh <mibodhi@gmail.com> Use subject prefixes matching the subsystem (which you can get for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching). This is not DTS. These are bindings. > --- > > Changes in v2: > - Add marvell,38x.yaml. For now, add this binding to the Marvell > directory to keep it consistent with other Marvell yaml files. > At a later date and a separate patch, consolidate the Marvell > yaml files into marvell.yaml. > > .../bindings/arm/marvell/armada-38x.yaml | 27 +++++++++++++++++++ > 1 file changed, 27 insertions(+) > create mode 100644 Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml marvell,armada-38x.yaml Or just squash it with existing armada bindings... Keeping one binding per one SoC group is a bit a lot. > > diff --git a/Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml b/Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml > new file mode 100644 > index 000000000000..096bd46d932a > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml > @@ -0,0 +1,27 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/arm/marvell/marvell,38x.yaml# Does not look like you tested the bindings. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). Best regards, Krzysztof
On Tue, 11 Apr 2023 19:57:35 -0700, Tony Dinh wrote: > Add device tree binding for Marvell Armada 38x. > > Signed-off-by: Tony Dinh <mibodhi@gmail.com> > --- > > Changes in v2: > - Add marvell,38x.yaml. For now, add this binding to the Marvell > directory to keep it consistent with other Marvell yaml files. > At a later date and a separate patch, consolidate the Marvell > yaml files into marvell.yaml. > > .../bindings/arm/marvell/armada-38x.yaml | 27 +++++++++++++++++++ > 1 file changed, 27 insertions(+) > create mode 100644 Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: ./Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml: $id: relative path/filename doesn't match actual path or filename expected: http://devicetree.org/schemas/arm/marvell/armada-38x.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230412025737.20280-2-mibodhi@gmail.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
Hi Rob, Hi Krzysztof, On Wed, Apr 12, 2023 at 5:36 AM Rob Herring <robh@kernel.org> wrote: > > > On Tue, 11 Apr 2023 19:57:35 -0700, Tony Dinh wrote: > > Add device tree binding for Marvell Armada 38x. > > > > Signed-off-by: Tony Dinh <mibodhi@gmail.com> > > --- > > > > Changes in v2: > > - Add marvell,38x.yaml. For now, add this binding to the Marvell > > directory to keep it consistent with other Marvell yaml files. > > At a later date and a separate patch, consolidate the Marvell > > yaml files into marvell.yaml. > > > > .../bindings/arm/marvell/armada-38x.yaml | 27 +++++++++++++++++++ > > 1 file changed, 27 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > ./Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml: $id: relative path/filename doesn't match actual path or filename > expected: http://devicetree.org/schemas/arm/marvell/armada-38x.yaml# > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230412025737.20280-2-mibodhi@gmail.com > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema. > Thanks for the reviews. After running make dt_binding_check for it seems like hours (on a dual-core 1.8GHz ARM box), I got impatient and used make CHECK_DTBS=y armada-385-thecus-n2350.dtb I'll move this to another faster box and run make dt_binding_check. All the best, Tony
On 12/04/2023 21:05, Tony Dinh wrote: > Hi Rob, > Hi Krzysztof, > > On Wed, Apr 12, 2023 at 5:36 AM Rob Herring <robh@kernel.org> wrote: >> >> >> On Tue, 11 Apr 2023 19:57:35 -0700, Tony Dinh wrote: >>> Add device tree binding for Marvell Armada 38x. >>> >>> Signed-off-by: Tony Dinh <mibodhi@gmail.com> >>> --- >>> >>> Changes in v2: >>> - Add marvell,38x.yaml. For now, add this binding to the Marvell >>> directory to keep it consistent with other Marvell yaml files. >>> At a later date and a separate patch, consolidate the Marvell >>> yaml files into marvell.yaml. >>> >>> .../bindings/arm/marvell/armada-38x.yaml | 27 +++++++++++++++++++ >>> 1 file changed, 27 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml >>> >> >> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' >> on your patch (DT_CHECKER_FLAGS is new in v5.13): >> >> yamllint warnings/errors: >> >> dtschema/dtc warnings/errors: >> ./Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml: $id: relative path/filename doesn't match actual path or filename >> expected: http://devicetree.org/schemas/arm/marvell/armada-38x.yaml# >> >> doc reference errors (make refcheckdocs): >> >> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230412025737.20280-2-mibodhi@gmail.com >> >> The base for the series is generally the latest rc1. A different dependency >> should be noted in *this* patch. >> >> If you already ran 'make dt_binding_check' and didn't see the above >> error(s), then make sure 'yamllint' is installed and dt-schema is up to >> date: >> >> pip3 install dtschema --upgrade >> >> Please check and re-submit after running the above command yourself. Note >> that DT_SCHEMA_FILES can be set to your schema file to speed up checking >> your schema. However, it must be unset to test all examples with your schema. >> > > Thanks for the reviews. After running make dt_binding_check for it > seems like hours (on a dual-core 1.8GHz ARM box), I got impatient and > used > make CHECK_DTBS=y armada-385-thecus-n2350.dtb > > I'll move this to another faster box and run make dt_binding_check. So many questions... 1. Why do you have to run it on arm? Not on regular machine for work? No one of us does like that... 2. You are now mixing now two different commands. You were asked to run DT_SCHEMA_FILES 3. Read the provided guide how to speed it up. It runs within few seconds. Best regards, Krzysztof
Hi Krzysztof, On Thu, Apr 13, 2023 at 12:51 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 12/04/2023 21:05, Tony Dinh wrote: > > Hi Rob, > > Hi Krzysztof, > > > > On Wed, Apr 12, 2023 at 5:36 AM Rob Herring <robh@kernel.org> wrote: > >> > >> > >> On Tue, 11 Apr 2023 19:57:35 -0700, Tony Dinh wrote: > >>> Add device tree binding for Marvell Armada 38x. > >>> > >>> Signed-off-by: Tony Dinh <mibodhi@gmail.com> > >>> --- > >>> > >>> Changes in v2: > >>> - Add marvell,38x.yaml. For now, add this binding to the Marvell > >>> directory to keep it consistent with other Marvell yaml files. > >>> At a later date and a separate patch, consolidate the Marvell > >>> yaml files into marvell.yaml. > >>> > >>> .../bindings/arm/marvell/armada-38x.yaml | 27 +++++++++++++++++++ > >>> 1 file changed, 27 insertions(+) > >>> create mode 100644 Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml > >>> > >> > >> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > >> on your patch (DT_CHECKER_FLAGS is new in v5.13): > >> > >> yamllint warnings/errors: > >> > >> dtschema/dtc warnings/errors: > >> ./Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml: $id: relative path/filename doesn't match actual path or filename > >> expected: http://devicetree.org/schemas/arm/marvell/armada-38x.yaml# > >> > >> doc reference errors (make refcheckdocs): > >> > >> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230412025737.20280-2-mibodhi@gmail.com > >> > >> The base for the series is generally the latest rc1. A different dependency > >> should be noted in *this* patch. > >> > >> If you already ran 'make dt_binding_check' and didn't see the above > >> error(s), then make sure 'yamllint' is installed and dt-schema is up to > >> date: > >> > >> pip3 install dtschema --upgrade > >> > >> Please check and re-submit after running the above command yourself. Note > >> that DT_SCHEMA_FILES can be set to your schema file to speed up checking > >> your schema. However, it must be unset to test all examples with your schema. > >> > > > > Thanks for the reviews. After running make dt_binding_check for it > > seems like hours (on a dual-core 1.8GHz ARM box), I got impatient and > > used > > make CHECK_DTBS=y armada-385-thecus-n2350.dtb > > > > I'll move this to another faster box and run make dt_binding_check. > > So many questions... > 1. Why do you have to run it on arm? Not on regular machine for work? No > one of us does like that... It's just more convenient for me to run on ARM (I also build ARM kernels natively with distcc). This is not work related, so I cannot use machines at work. I can use my personal 4-core laptop, though. > 2. You are now mixing now two different commands. You were asked to run > DT_SCHEMA_FILES OK. As you can see, I have no experience with schema before. > 3. Read the provided guide how to speed it up. It runs within few seconds. Good to know there is a way. Thanks for the advice! All the best, Tony > > > Best regards, > Krzysztof >
Hi Rob, On Wed, Apr 12, 2023 at 5:36 AM Rob Herring <robh@kernel.org> wrote: > > > On Tue, 11 Apr 2023 19:57:35 -0700, Tony Dinh wrote: > > Add device tree binding for Marvell Armada 38x. > > > > Signed-off-by: Tony Dinh <mibodhi@gmail.com> > > --- > > > > Changes in v2: > > - Add marvell,38x.yaml. For now, add this binding to the Marvell > > directory to keep it consistent with other Marvell yaml files. > > At a later date and a separate patch, consolidate the Marvell > > yaml files into marvell.yaml. > > > > .../bindings/arm/marvell/armada-38x.yaml | 27 +++++++++++++++++++ > > 1 file changed, 27 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > ./Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml: $id: relative path/filename doesn't match actual path or filename > expected: http://devicetree.org/schemas/arm/marvell/armada-38x.yaml# > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230412025737.20280-2-mibodhi@gmail.com > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema. > Would dt-schema in Debian 12 work? or must it be the latest dtschema installed by pip3 or from GitHub? Thanks, Tony
On 02/05/2023 00:46, Tony Dinh wrote: > Hi Rob, > > On Wed, Apr 12, 2023 at 5:36 AM Rob Herring <robh@kernel.org> wrote: >> >> >> On Tue, 11 Apr 2023 19:57:35 -0700, Tony Dinh wrote: >>> Add device tree binding for Marvell Armada 38x. >>> >>> Signed-off-by: Tony Dinh <mibodhi@gmail.com> >>> --- >>> >>> Changes in v2: >>> - Add marvell,38x.yaml. For now, add this binding to the Marvell >>> directory to keep it consistent with other Marvell yaml files. >>> At a later date and a separate patch, consolidate the Marvell >>> yaml files into marvell.yaml. >>> >>> .../bindings/arm/marvell/armada-38x.yaml | 27 +++++++++++++++++++ >>> 1 file changed, 27 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml >>> >> >> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' >> on your patch (DT_CHECKER_FLAGS is new in v5.13): >> >> yamllint warnings/errors: >> >> dtschema/dtc warnings/errors: >> ./Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml: $id: relative path/filename doesn't match actual path or filename >> expected: http://devicetree.org/schemas/arm/marvell/armada-38x.yaml# >> >> doc reference errors (make refcheckdocs): >> >> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230412025737.20280-2-mibodhi@gmail.com >> >> The base for the series is generally the latest rc1. A different dependency >> should be noted in *this* patch. >> >> If you already ran 'make dt_binding_check' and didn't see the above >> error(s), then make sure 'yamllint' is installed and dt-schema is up to >> date: >> >> pip3 install dtschema --upgrade >> >> Please check and re-submit after running the above command yourself. Note >> that DT_SCHEMA_FILES can be set to your schema file to speed up checking >> your schema. However, it must be unset to test all examples with your schema. >> > > Would dt-schema in Debian 12 work? or must it be the latest dtschema > installed by pip3 or from GitHub? If Debian 12 has latest schema, it would work. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml b/Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml new file mode 100644 index 000000000000..096bd46d932a --- /dev/null +++ b/Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml @@ -0,0 +1,27 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/arm/marvell/marvell,38x.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Marvell Armada 38x Platforms + +maintainers: + - Gregory CLEMENT <gregory.clement@bootlin.com> + - Andrew Lunn <andrew@lunn.ch> + +properties: + $nodename: + const: '/' + compatible: + oneOf: + + - description: Armada 380 SoC + items: + - const: marvell,armada380 + + - description: Armada 385 SoC + items: + - const: marvell,armada385 + +additionalProperties: true
Add device tree binding for Marvell Armada 38x. Signed-off-by: Tony Dinh <mibodhi@gmail.com> --- Changes in v2: - Add marvell,38x.yaml. For now, add this binding to the Marvell directory to keep it consistent with other Marvell yaml files. At a later date and a separate patch, consolidate the Marvell yaml files into marvell.yaml. .../bindings/arm/marvell/armada-38x.yaml | 27 +++++++++++++++++++ 1 file changed, 27 insertions(+) create mode 100644 Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml