| Message ID | 20230406060825.103187-2-andreas@kemnade.info |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | leds: Add a driver for the BD2606MVV | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
Hi Matti, On Thu, 6 Apr 2023 11:32:42 +0300 Matti Vaittinen <mazziesaccount@gmail.com> wrote: > Hi Andreas, > > Thanks for the patch! Adding new support for devices is Much Appreciated! > > On 4/6/23 09:08, Andreas Kemnade wrote: > > Document ROHM BD2606MVV LED driver devicetree bindings. > > > > Signed-off-by: Andreas Kemnade <andreas@kemnade.info> > > --- > > .../bindings/leds/rohm,bd2606mvv.yaml | 76 +++++++++++++++++++ > > 1 file changed, 76 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/leds/rohm,bd2606mvv.yaml > > > > diff --git a/Documentation/devicetree/bindings/leds/rohm,bd2606mvv.yaml b/Documentation/devicetree/bindings/leds/rohm,bd2606mvv.yaml > > new file mode 100644 > > index 0000000000000..6d4ddd8d31162 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/leds/rohm,bd2606mvv.yaml > > @@ -0,0 +1,76 @@ > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/leds/rohm,bd2606mvv.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: BD2606MVV LED controller > > + > > +maintainers: > > + - Andreas Kemnade <andreas@kemnade.info> > > + > > +description: > > + The BD2606 MVV is a programmable LED controller connected via I2C that can > > + drive 6 separate lines. Each of them can be individually switched on and off > > + but the brightness setting is shared between two of them. > > Maybe add a link to data-sheet? > https://fscdn.rohm.com/en/products/databook/datasheet/ic/power/led_driver/bd2606mvv_1-e.pdf > Maybe also (because it has the register description): https://fscdn.rohm.com/en/products/databook/applinote/ic/power/led_driver/bd2606mvv_tsb_001_ug-e.pdf > > + > > +properties: > > + compatible: > > + const: rohm,bd2606mvv > > + > > + reg: > > + description: I2C slave address of the controller. > > + maxItems: 1 > > + > > + "#address-cells": > > + const: 1 > > + > > + "#size-cells": > > + const: 0 > > + > > +patternProperties: > > + "^led@[0-6]$": > > + type: object > > + $ref: common.yaml# > > + unevaluatedProperties: false > > + > > + properties: > > + reg: > > + minimum: 0 > > + maximum: 6 > > + > > + required: > > + - reg > > + > > +additionalProperties: false > > According to the data-sheet, BD2606 has an enable-pin. Should it be > visible in the bindings? > yes, it should. Regards, Andreas
diff --git a/Documentation/devicetree/bindings/leds/rohm,bd2606mvv.yaml b/Documentation/devicetree/bindings/leds/rohm,bd2606mvv.yaml new file mode 100644 index 0000000000000..6d4ddd8d31162 --- /dev/null +++ b/Documentation/devicetree/bindings/leds/rohm,bd2606mvv.yaml @@ -0,0 +1,76 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/leds/rohm,bd2606mvv.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: BD2606MVV LED controller + +maintainers: + - Andreas Kemnade <andreas@kemnade.info> + +description: + The BD2606 MVV is a programmable LED controller connected via I2C that can + drive 6 separate lines. Each of them can be individually switched on and off + but the brightness setting is shared between two of them. + +properties: + compatible: + const: rohm,bd2606mvv + + reg: + description: I2C slave address of the controller. + maxItems: 1 + + "#address-cells": + const: 1 + + "#size-cells": + const: 0 + +patternProperties: + "^led@[0-6]$": + type: object + $ref: common.yaml# + unevaluatedProperties: false + + properties: + reg: + minimum: 0 + maximum: 6 + + required: + - reg + +additionalProperties: false + +examples: + - | + + #include <dt-bindings/leds/common.h> + + i2c0 { + #address-cells = <1>; + #size-cells = <0>; + + led-controller@66 { + compatible = "rohm,bd2606mvv"; + #address-cells = <1>; + #size-cells = <0>; + reg = <0x66>; + + led@0 { + color = <LED_COLOR_ID_RED>; + function = LED_FUNCTION_POWER; + reg = <0x0>; + }; + + led@2 { + color = <LED_COLOR_ID_WHITE>; + function = LED_FUNCTION_STATUS; + reg = <0x2>; + }; + }; + }; + +...
Document ROHM BD2606MVV LED driver devicetree bindings. Signed-off-by: Andreas Kemnade <andreas@kemnade.info> --- .../bindings/leds/rohm,bd2606mvv.yaml | 76 +++++++++++++++++++ 1 file changed, 76 insertions(+) create mode 100644 Documentation/devicetree/bindings/leds/rohm,bd2606mvv.yaml