| Message ID | 20230404054642.5691-1-otabeknazrullaev1998@gmail.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | watchdog: dt-bindings: atmel-at91rm9200-wdt convert to json-schema | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 2 warnings, 28 lines checked |
| robh/patch-applied | success | |
| robh/dt-meta-schema | fail | build log |
On 04/04/2023 07:46, Otabek Nazrullaev wrote: > Convert atmel AT91RM9200 system timer watchdog from text bindings > to YAML format > Same comments apply as other patch. Also - subject has missing colon. ... > + compatible: > + const: atmel,at91sam9260-wdt > + > +required: > + - compatible > + > +unevaluatedProperties: false Why doing it here correctly but in the other patch differently? Best regards, Krzysztof
On 04/04/2023 07:46, Otabek Nazrullaev wrote: > Convert atmel AT91RM9200 system timer watchdog from text bindings > to YAML format ... > + > +examples: > + - | > + watchdog@fffffd00 { Drop unit address. Test your patches before sending, you should see clearly warning. Best regards, Krzysztof
On Tue, 04 Apr 2023 14:46:40 +0900, Otabek Nazrullaev wrote: > Convert atmel AT91RM9200 system timer watchdog from text bindings > to YAML format > > Signed-off-by: Otabek Nazrullaev <otabeknazrullaev1998@gmail.com> > --- > .../watchdog/atmel-at91rm9200-wdt.txt | 9 ------ > .../watchdog/atmel-at91rm9200-wdt.yaml | 28 +++++++++++++++++++ > 2 files changed, 28 insertions(+), 9 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/watchdog/atmel-at91rm9200-wdt.txt > create mode 100644 Documentation/devicetree/bindings/watchdog/atmel-at91rm9200-wdt.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: Documentation/devicetree/bindings/watchdog/atmel-at91rm9200-wdt.example.dts:18.27-20.11: Warning (unit_address_vs_reg): /example-0/watchdog@fffffd00: node has a unit name, but no reg or ranges property Documentation/devicetree/bindings/watchdog/atmel-at91rm9200-wdt.example.dtb: /example-0/watchdog@fffffd00: failed to match any schema with compatible: ['atmel,at91rm9200-wdt'] /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/watchdog/atmel,at91sam9-wdt.example.dtb: watchdog@fffffd40: Unevaluated properties are not allowed ('atmel,dbg-halt', 'atmel,idle-halt', 'atmel,max-heartbeat-sec', 'atmel,min-heartbeat-sec', 'atmel,reset-type', 'atmel,watchdog-type', 'clocks', 'interrupts', 'reg' were unexpected) From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/watchdog/atmel-at91rm9200-wdt.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230404054642.5691-1-otabeknazrullaev1998@gmail.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
diff --git a/Documentation/devicetree/bindings/watchdog/atmel-at91rm9200-wdt.txt b/Documentation/devicetree/bindings/watchdog/atmel-at91rm9200-wdt.txt deleted file mode 100644 index d4d86cf8f9eb..000000000000 --- a/Documentation/devicetree/bindings/watchdog/atmel-at91rm9200-wdt.txt +++ /dev/null @@ -1,9 +0,0 @@ -Atmel AT91RM9200 System Timer Watchdog - -Required properties: -- compatible: must be "atmel,at91sam9260-wdt". - -Example: - watchdog@fffffd00 { - compatible = "atmel,at91rm9200-wdt"; - }; diff --git a/Documentation/devicetree/bindings/watchdog/atmel-at91rm9200-wdt.yaml b/Documentation/devicetree/bindings/watchdog/atmel-at91rm9200-wdt.yaml new file mode 100644 index 000000000000..e9e14fabe0fb --- /dev/null +++ b/Documentation/devicetree/bindings/watchdog/atmel-at91rm9200-wdt.yaml @@ -0,0 +1,28 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/watchdog/atmel-at91rm9200-wdt.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#" + +maintainers: + - Otabek Nazrullaev <otabeknazrullaev1998@gmail.com> + +title: Atmel AT91RM9200 System Timer Watchdog + +allOf: + - $ref: "watchdog.yaml#" + +properties: + compatible: + const: atmel,at91sam9260-wdt + +required: + - compatible + +unevaluatedProperties: false + +examples: + - | + watchdog@fffffd00 { + compatible = "atmel,at91rm9200-wdt"; + };
Convert atmel AT91RM9200 system timer watchdog from text bindings to YAML format Signed-off-by: Otabek Nazrullaev <otabeknazrullaev1998@gmail.com> --- .../watchdog/atmel-at91rm9200-wdt.txt | 9 ------ .../watchdog/atmel-at91rm9200-wdt.yaml | 28 +++++++++++++++++++ 2 files changed, 28 insertions(+), 9 deletions(-) delete mode 100644 Documentation/devicetree/bindings/watchdog/atmel-at91rm9200-wdt.txt create mode 100644 Documentation/devicetree/bindings/watchdog/atmel-at91rm9200-wdt.yaml