| Message ID | 20230403-da9063-disable-unused-v3-3-cc4dc698864c@skidata.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | regulator: da9063: disable unused voltage monitors | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 05/04/2023 19:14, Benjamin Bara wrote: > From: Benjamin Bara <benjamin.bara@skidata.com> > > Document that the da9063 only provides under- *and* over-voltage > monitoring in one, and therefore requires both to be configured with the > same severity and value. Add an example for clarification. > > Signed-off-by: Benjamin Bara <benjamin.bara@skidata.com> This is a friendly reminder during the review process. It looks like you received a tag and forgot to add it. If you do not know the process, here is a short explanation: Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for acks received on the version they apply. https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540 If a tag was not added on purpose, please state why and what changed. Best regards, Krzysztof
On Thu, 6 Apr 2023 at 10:28, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > It looks like you received a tag and forgot to add it. > If a tag was not added on purpose, please state why and what changed. I slightly modified the description: Basically clarified that both, uv and ov, must be set to the same severity and value. I guess that wasn't very clear before. I mentioned the change in the cover letter. Maybe I should have added it here too, sorry for that. Best regards, Benjamin
On 06/04/2023 10:38, Benjamin Bara wrote: > On Thu, 6 Apr 2023 at 10:28, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: >> It looks like you received a tag and forgot to add it. >> If a tag was not added on purpose, please state why and what changed. > > I slightly modified the description: > Basically clarified that both, uv and ov, must be set to the same severity and > value. I guess that wasn't very clear before. That's not really a reason to drop tags. > > I mentioned the change in the cover letter. Maybe I should have added it here > too, sorry for that. Yes, the change was there, but nothing about dropping tags. Best regards, Krzysztof
On 05/04/2023 19:14, Benjamin Bara wrote: > From: Benjamin Bara <benjamin.bara@skidata.com> > > Document that the da9063 only provides under- *and* over-voltage > monitoring in one, and therefore requires both to be configured with the > same severity and value. Add an example for clarification. > > Signed-off-by: Benjamin Bara <benjamin.bara@skidata.com> > --- > Documentation/devicetree/bindings/mfd/dlg,da9063.yaml | 17 +++++++++++++++-- Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Wed, 05 Apr 2023, Benjamin Bara wrote: > From: Benjamin Bara <benjamin.bara@skidata.com> > > Document that the da9063 only provides under- *and* over-voltage > monitoring in one, and therefore requires both to be configured with the > same severity and value. Add an example for clarification. > > Signed-off-by: Benjamin Bara <benjamin.bara@skidata.com> > --- > Documentation/devicetree/bindings/mfd/dlg,da9063.yaml | 17 +++++++++++++++-- > 1 file changed, 15 insertions(+), 2 deletions(-) Applied, thanks
diff --git a/Documentation/devicetree/bindings/mfd/dlg,da9063.yaml b/Documentation/devicetree/bindings/mfd/dlg,da9063.yaml index e8e74e91070c..c5a7e10d7d80 100644 --- a/Documentation/devicetree/bindings/mfd/dlg,da9063.yaml +++ b/Documentation/devicetree/bindings/mfd/dlg,da9063.yaml @@ -12,6 +12,11 @@ maintainers: description: | For device-tree bindings of other sub-modules refer to the binding documents under the respective sub-system directories. + Using regulator-{uv,ov}-{warn,error,protection}-microvolt requires special + handling: First, when GP_FB2 is used, it must be ensured that there is no + moment where all voltage monitors are disabled. Next, as da9063 only supports + UV *and* OV monitoring, both must be set to the same severity and value + (0: disable, 1: enable). properties: compatible: @@ -121,11 +126,19 @@ examples: regulator-max-microamp = <2000000>; regulator-boot-on; }; + ldo6 { + /* UNUSED */ + regulator-name = "LDO_6"; + regulator-uv-protection-microvolt = <0>; + regulator-ov-protection-microvolt = <0>; + }; ldo11 { regulator-name = "LDO_11"; regulator-min-microvolt = <900000>; - regulator-max-microvolt = <3600000>; - regulator-boot-on; + regulator-max-microvolt = <900000>; + regulator-uv-protection-microvolt = <1>; + regulator-ov-protection-microvolt = <1>; + regulator-always-on; }; }; };