| Message ID | 20230401154725.1059563-2-bhupesh.sharma@linaro.org |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Enable USB SS qmp phy for Qualcomm SM6115 SoC | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Sat, 1 Apr 2023 at 18:49, Bhupesh Sharma <bhupesh.sharma@linaro.org> wrote: > > The USB3 SS (QMP) PHY found on Qualcomm SM6115 & QCM2290 SoCs is > similar to sm8150 QMP PHY in the sense that the phy subnode supports sm8150 has 5 QMP PHYs. Which one is mentioned here? > 6 regs, namely TX lane 1, RX lane 1, PCS, TX lane 2, RX lane 2 and > PCS_MISC. > > Update the dt-bindings document to reflect the same. > > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> > --- > .../devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml > index e81a38281f8c..1575dc70bcf2 100644 > --- a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml > @@ -276,7 +276,9 @@ allOf: > compatible: > contains: > enum: > + - qcom,qcm2290-qmp-usb3-phy > - qcom,sdm845-qmp-usb3-phy > + - qcom,sm6115-qmp-usb3-phy > - qcom,sm8150-qmp-usb3-phy > - qcom,sm8350-qmp-usb3-phy > - qcom,sm8450-qmp-usb3-phy > @@ -318,12 +320,10 @@ allOf: > enum: > - qcom,ipq6018-qmp-usb3-phy > - qcom,ipq8074-qmp-usb3-phy > - - qcom,qcm2290-qmp-usb3-phy > - qcom,sc7180-qmp-usb3-phy > - qcom,sc8180x-qmp-usb3-phy > - qcom,sdx55-qmp-usb3-uni-phy > - qcom,sdx65-qmp-usb3-uni-phy > - - qcom,sm6115-qmp-usb3-phy > - qcom,sm8150-qmp-usb3-uni-phy > - qcom,sm8250-qmp-usb3-phy > then: > -- > 2.38.1 >
On Sat, 1 Apr 2023 at 22:42, Dmitry Baryshkov <dmitry.baryshkov@linaro.org> wrote: > > On Sat, 1 Apr 2023 at 18:49, Bhupesh Sharma <bhupesh.sharma@linaro.org> wrote: > > > > The USB3 SS (QMP) PHY found on Qualcomm SM6115 & QCM2290 SoCs is > > similar to sm8150 QMP PHY in the sense that the phy subnode supports > > sm8150 has 5 QMP PHYs. Which one is mentioned here? 'qcom,sm8150-qmp-usb3-phy' which is named as 'usb_1_qmpphy' in sm8150.dtsi (see : <https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/arch/arm64/boot/dts/qcom/sm8150.dtsi#n3394>) and has 6 regs , namely TX lane 1, RX lane 1, PCS, TX lane 2, RX lane 2 and PCS_MISC. Regards, Bhupesh > > 6 regs, namely TX lane 1, RX lane 1, PCS, TX lane 2, RX lane 2 and > > PCS_MISC. > > > > Update the dt-bindings document to reflect the same. > > > > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> > > --- > > .../devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml > > index e81a38281f8c..1575dc70bcf2 100644 > > --- a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml > > +++ b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml > > @@ -276,7 +276,9 @@ allOf: > > compatible: > > contains: > > enum: > > + - qcom,qcm2290-qmp-usb3-phy > > - qcom,sdm845-qmp-usb3-phy > > + - qcom,sm6115-qmp-usb3-phy > > - qcom,sm8150-qmp-usb3-phy > > - qcom,sm8350-qmp-usb3-phy > > - qcom,sm8450-qmp-usb3-phy > > @@ -318,12 +320,10 @@ allOf: > > enum: > > - qcom,ipq6018-qmp-usb3-phy > > - qcom,ipq8074-qmp-usb3-phy > > - - qcom,qcm2290-qmp-usb3-phy > > - qcom,sc7180-qmp-usb3-phy > > - qcom,sc8180x-qmp-usb3-phy > > - qcom,sdx55-qmp-usb3-uni-phy > > - qcom,sdx65-qmp-usb3-uni-phy > > - - qcom,sm6115-qmp-usb3-phy > > - qcom,sm8150-qmp-usb3-uni-phy > > - qcom,sm8250-qmp-usb3-phy > > then: > > -- > > 2.38.1 > > > > > -- > With best wishes > Dmitry
On 01/04/2023 17:47, Bhupesh Sharma wrote: > The USB3 SS (QMP) PHY found on Qualcomm SM6115 & QCM2290 SoCs is > similar to sm8150 QMP PHY in the sense that the phy subnode supports > 6 regs, namely TX lane 1, RX lane 1, PCS, TX lane 2, RX lane 2 and > PCS_MISC. > > Update the dt-bindings document to reflect the same. Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Bhupesh, Can you use scripts/get_maintainers.pl to get the Cc addresses instead of writing them manually or inventing? Best regards, Krzysztof
On Wed, 5 Apr 2023 at 15:11, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 01/04/2023 17:47, Bhupesh Sharma wrote: > > The USB3 SS (QMP) PHY found on Qualcomm SM6115 & QCM2290 SoCs is > > similar to sm8150 QMP PHY in the sense that the phy subnode supports > > 6 regs, namely TX lane 1, RX lane 1, PCS, TX lane 2, RX lane 2 and > > PCS_MISC. > > > > Update the dt-bindings document to reflect the same. > > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Bhupesh, > > Can you use scripts/get_maintainers.pl to get the Cc addresses instead > of writing them manually or inventing? Sure Krzysztof, will do. Thanks, Bhupesh
diff --git a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml index e81a38281f8c..1575dc70bcf2 100644 --- a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml @@ -276,7 +276,9 @@ allOf: compatible: contains: enum: + - qcom,qcm2290-qmp-usb3-phy - qcom,sdm845-qmp-usb3-phy + - qcom,sm6115-qmp-usb3-phy - qcom,sm8150-qmp-usb3-phy - qcom,sm8350-qmp-usb3-phy - qcom,sm8450-qmp-usb3-phy @@ -318,12 +320,10 @@ allOf: enum: - qcom,ipq6018-qmp-usb3-phy - qcom,ipq8074-qmp-usb3-phy - - qcom,qcm2290-qmp-usb3-phy - qcom,sc7180-qmp-usb3-phy - qcom,sc8180x-qmp-usb3-phy - qcom,sdx55-qmp-usb3-uni-phy - qcom,sdx65-qmp-usb3-uni-phy - - qcom,sm6115-qmp-usb3-phy - qcom,sm8150-qmp-usb3-uni-phy - qcom,sm8250-qmp-usb3-phy then:
The USB3 SS (QMP) PHY found on Qualcomm SM6115 & QCM2290 SoCs is similar to sm8150 QMP PHY in the sense that the phy subnode supports 6 regs, namely TX lane 1, RX lane 1, PCS, TX lane 2, RX lane 2 and PCS_MISC. Update the dt-bindings document to reflect the same. Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> --- .../devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)