diff mbox series

[v3,5/9] media: dt-bindings: cadence-csi2rx: Add starfive compatible

Message ID 20230331121826.96973-6-jack.zhu@starfivetech.com
State Not Applicable, archived
Headers show
Series Add Starfive Camera Subsystem driver | expand

Checks

Context Check Description
robh/checkpatch success
robh/patch-applied success
robh/dtbs-check warning build log
robh/dt-meta-schema success

Commit Message

Jack Zhu March 31, 2023, 12:18 p.m. UTC
Add starfive compatible for Starfive JH7110 SoC which has a
Cadence MIPI-CSI2 RX controller.

Signed-off-by: Jack Zhu <jack.zhu@starfivetech.com>
---
 Documentation/devicetree/bindings/media/cdns,csi2rx.yaml | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

Comments

Krzysztof Kozlowski March 31, 2023, 8:14 p.m. UTC | #1
On 31/03/2023 14:18, Jack Zhu wrote:
> Add starfive compatible for Starfive JH7110 SoC which has a
> Cadence MIPI-CSI2 RX controller.
> 
> Signed-off-by: Jack Zhu <jack.zhu@starfivetech.com>
> ---


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Laurent Pinchart April 4, 2023, 4:46 a.m. UTC | #2
Hi Jack,

Thank you for the patch.

On Fri, Mar 31, 2023 at 08:18:22PM +0800, Jack Zhu wrote:
> Add starfive compatible for Starfive JH7110 SoC which has a
> Cadence MIPI-CSI2 RX controller.
> 
> Signed-off-by: Jack Zhu <jack.zhu@starfivetech.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  Documentation/devicetree/bindings/media/cdns,csi2rx.yaml | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/cdns,csi2rx.yaml b/Documentation/devicetree/bindings/media/cdns,csi2rx.yaml
> index f8da4a35e98e..30a335b10762 100644
> --- a/Documentation/devicetree/bindings/media/cdns,csi2rx.yaml
> +++ b/Documentation/devicetree/bindings/media/cdns,csi2rx.yaml
> @@ -15,7 +15,10 @@ description:
>  
>  properties:
>    compatible:
> -    const: cdns,csi2rx
> +    items:
> +      - enum:
> +          - starfive,jh7110-csi2rx
> +      - const: cdns,csi2rx
>  
>    reg:
>      maxItems: 1
> @@ -130,7 +133,7 @@ additionalProperties: false
>  examples:
>    - |
>      csi@d060000 {
> -        compatible = "cdns,csi2rx";
> +        compatible = "starfive,jh7110-csi2rx", "cdns,csi2rx";
>          reg = <0x0d060000 0x1000>;
>          clocks = <&byteclock 7>, <&byteclock 6>,
>                   <&coreclock 8>, <&coreclock 9>,
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/media/cdns,csi2rx.yaml b/Documentation/devicetree/bindings/media/cdns,csi2rx.yaml
index f8da4a35e98e..30a335b10762 100644
--- a/Documentation/devicetree/bindings/media/cdns,csi2rx.yaml
+++ b/Documentation/devicetree/bindings/media/cdns,csi2rx.yaml
@@ -15,7 +15,10 @@  description:
 
 properties:
   compatible:
-    const: cdns,csi2rx
+    items:
+      - enum:
+          - starfive,jh7110-csi2rx
+      - const: cdns,csi2rx
 
   reg:
     maxItems: 1
@@ -130,7 +133,7 @@  additionalProperties: false
 examples:
   - |
     csi@d060000 {
-        compatible = "cdns,csi2rx";
+        compatible = "starfive,jh7110-csi2rx", "cdns,csi2rx";
         reg = <0x0d060000 0x1000>;
         clocks = <&byteclock 7>, <&byteclock 6>,
                  <&coreclock 8>, <&coreclock 9>,