| Message ID | 20230328-topic-msgram_mpm-v1-1-1b788a5f5a33@linaro.org |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Resolve MPM register space situation | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Tue, Mar 28, 2023 at 12:02:52PM +0200, Konrad Dybcio wrote: > Due to the wild nature of the Qualcomm RPM Message RAM, we can't really > use 'reg' to point to the MPM's slice of Message RAM without cutting into > an already-defined RPM MSG RAM node used for GLINK and SMEM. > > Document passing the register space as a slice of SRAM through the > qcom,rpm-msg-ram property. This also makes 'reg' no longer required. > > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> > --- > .../devicetree/bindings/interrupt-controller/qcom,mpm.yaml | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml b/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml > index 509d20c091af..77fe5e0b378f 100644 > --- a/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml > +++ b/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml > @@ -30,6 +30,11 @@ properties: > description: > Specifies the base address and size of vMPM registers in RPM MSG RAM. > > + qcom,rpm-msg-ram: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: > + Phandle to the APSS MPM slice of the RPM Message RAM > + > interrupts: > maxItems: 1 > description: > @@ -64,7 +69,6 @@ properties: > > required: > - compatible > - - reg It's not my call, but I wonder if we need to maintain the 'reg' ABI at all, as there is no DTS landed so far. In either case, I suggest we update the example to adopt the new way. Shawn > - interrupts > - mboxes > - interrupt-controller > > -- > 2.40.0 >
On 28/03/2023 12:02, Konrad Dybcio wrote: > Due to the wild nature of the Qualcomm RPM Message RAM, we can't really > use 'reg' to point to the MPM's slice of Message RAM without cutting into > an already-defined RPM MSG RAM node used for GLINK and SMEM. > > Document passing the register space as a slice of SRAM through the > qcom,rpm-msg-ram property. This also makes 'reg' no longer required. > > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> > --- > .../devicetree/bindings/interrupt-controller/qcom,mpm.yaml | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml b/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml > index 509d20c091af..77fe5e0b378f 100644 > --- a/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml > +++ b/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml > @@ -30,6 +30,11 @@ properties: > description: > Specifies the base address and size of vMPM registers in RPM MSG RAM. > > + qcom,rpm-msg-ram: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: > + Phandle to the APSS MPM slice of the RPM Message RAM > + > interrupts: > maxItems: 1 > description: > @@ -64,7 +69,6 @@ properties: > > required: > - compatible > - - reg Either: 1. make reg deprecated and require qcom,rpm-msg-ram or 2. you need oneOf:required for reg and qcom,rpm-msg-ram > - interrupts > - mboxes > - interrupt-controller > Best regards, Krzysztof
On 29.03.2023 10:27, Krzysztof Kozlowski wrote: > On 28/03/2023 12:02, Konrad Dybcio wrote: >> Due to the wild nature of the Qualcomm RPM Message RAM, we can't really >> use 'reg' to point to the MPM's slice of Message RAM without cutting into >> an already-defined RPM MSG RAM node used for GLINK and SMEM. >> >> Document passing the register space as a slice of SRAM through the >> qcom,rpm-msg-ram property. This also makes 'reg' no longer required. >> >> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> >> --- >> .../devicetree/bindings/interrupt-controller/qcom,mpm.yaml | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml b/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml >> index 509d20c091af..77fe5e0b378f 100644 >> --- a/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml >> +++ b/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml >> @@ -30,6 +30,11 @@ properties: >> description: >> Specifies the base address and size of vMPM registers in RPM MSG RAM. >> >> + qcom,rpm-msg-ram: >> + $ref: /schemas/types.yaml#/definitions/phandle >> + description: >> + Phandle to the APSS MPM slice of the RPM Message RAM >> + >> interrupts: >> maxItems: 1 >> description: >> @@ -64,7 +69,6 @@ properties: >> >> required: >> - compatible >> - - reg > > Either: > 1. make reg deprecated and require qcom,rpm-msg-ram > or > 2. you need oneOf:required for reg and qcom,rpm-msg-ram Right, let's go with 1. Konrad > >> - interrupts >> - mboxes >> - interrupt-controller >> > > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml b/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml index 509d20c091af..77fe5e0b378f 100644 --- a/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml +++ b/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml @@ -30,6 +30,11 @@ properties: description: Specifies the base address and size of vMPM registers in RPM MSG RAM. + qcom,rpm-msg-ram: + $ref: /schemas/types.yaml#/definitions/phandle + description: + Phandle to the APSS MPM slice of the RPM Message RAM + interrupts: maxItems: 1 description: @@ -64,7 +69,6 @@ properties: required: - compatible - - reg - interrupts - mboxes - interrupt-controller
Due to the wild nature of the Qualcomm RPM Message RAM, we can't really use 'reg' to point to the MPM's slice of Message RAM without cutting into an already-defined RPM MSG RAM node used for GLINK and SMEM. Document passing the register space as a slice of SRAM through the qcom,rpm-msg-ram property. This also makes 'reg' no longer required. Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> --- .../devicetree/bindings/interrupt-controller/qcom,mpm.yaml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)