| Message ID | 20230323193709.5176-1-danascape@gmail.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | [v2] ASoC: dt-bindings: alc5632: Convert to dtschema | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 2 warnings, 64 lines checked |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Fri, Mar 24, 2023 at 01:07:09AM +0530, Saalim Quadri wrote: > +maintainers: > + - Leon Romanovsky <leon@leon.nu> > + - Mark Brown <broonie@kernel.org> I know nothing specific about this device so shouldn't be listed. CCing Leon for him to confirm.
On 23/03/2023 20:37, Saalim Quadri wrote: > Convert the ALC5632 audio codec bindings to DT schema. > > Signed-off-by: Saalim Quadri <danascape@gmail.com> > --- > + > +maintainers: > + - Leon Romanovsky <leon@leon.nu> Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. > + - Mark Brown <broonie@kernel.org> > + > +properties: > + compatible: > + const: realtek,alc5632 > + > + reg: > + maxItems: 1 > + > + '#gpio-cells': > + const: 2 > + > + gpio-controller: true > + > +required: > + - compatible > + - reg > + - '#gpio-cells' > + - gpio-controller > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/gpio/gpio.h> > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + alc5632: codec@1a { Drop label "alc5632". Best regards, Krzysztof
On 23/03/2023 20:37, Saalim Quadri wrote: > Convert the ALC5632 audio codec bindings to DT schema. > > Signed-off-by: Saalim Quadri <danascape@gmail.com> > --- > .../devicetree/bindings/sound/alc5632.txt | 43 ------------- > .../bindings/sound/realtek,alc5632.yaml | 64 +++++++++++++++++++ > 2 files changed, 64 insertions(+), 43 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/sound/alc5632.txt Also, do not attach your new patches to some other threads. Each patchset version is new submission and new thread. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/sound/alc5632.txt b/Documentation/devicetree/bindings/sound/alc5632.txt deleted file mode 100644 index ffd886d110bd..000000000000 --- a/Documentation/devicetree/bindings/sound/alc5632.txt +++ /dev/null @@ -1,43 +0,0 @@ -ALC5632 audio CODEC - -This device supports I2C only. - -Required properties: - - - compatible : "realtek,alc5632" - - - reg : the I2C address of the device. - - - gpio-controller : Indicates this device is a GPIO controller. - - - #gpio-cells : Should be two. The first cell is the pin number and the - second cell is used to specify optional parameters (currently unused). - -Pins on the device (for linking into audio routes): - - * SPK_OUTP - * SPK_OUTN - * HP_OUT_L - * HP_OUT_R - * AUX_OUT_P - * AUX_OUT_N - * LINE_IN_L - * LINE_IN_R - * PHONE_P - * PHONE_N - * MIC1_P - * MIC1_N - * MIC2_P - * MIC2_N - * MICBIAS1 - * DMICDAT - -Example: - -alc5632: alc5632@1e { - compatible = "realtek,alc5632"; - reg = <0x1a>; - - gpio-controller; - #gpio-cells = <2>; -}; diff --git a/Documentation/devicetree/bindings/sound/realtek,alc5632.yaml b/Documentation/devicetree/bindings/sound/realtek,alc5632.yaml new file mode 100644 index 000000000000..3de18b0fd3fd --- /dev/null +++ b/Documentation/devicetree/bindings/sound/realtek,alc5632.yaml @@ -0,0 +1,64 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/realtek,alc5632.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: ALC5632 audio CODEC + +description: | + Pins on the device (for linking into audio routes): + * SPK_OUTP + * SPK_OUTN + * HP_OUT_L + * HP_OUT_R + * AUX_OUT_P + * AUX_OUT_N + * LINE_IN_L + * LINE_IN_R + * PHONE_P + * PHONE_N + * MIC1_P + * MIC1_N + * MIC2_P + * MIC2_N + * MICBIAS1 + * DMICDAT + +maintainers: + - Leon Romanovsky <leon@leon.nu> + - Mark Brown <broonie@kernel.org> + +properties: + compatible: + const: realtek,alc5632 + + reg: + maxItems: 1 + + '#gpio-cells': + const: 2 + + gpio-controller: true + +required: + - compatible + - reg + - '#gpio-cells' + - gpio-controller + +additionalProperties: false + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + i2c { + #address-cells = <1>; + #size-cells = <0>; + alc5632: codec@1a { + compatible = "realtek,alc5632"; + reg = <0x1a>; + gpio-controller; + #gpio-cells = <2>; + }; + };
Convert the ALC5632 audio codec bindings to DT schema. Signed-off-by: Saalim Quadri <danascape@gmail.com> --- .../devicetree/bindings/sound/alc5632.txt | 43 ------------- .../bindings/sound/realtek,alc5632.yaml | 64 +++++++++++++++++++ 2 files changed, 64 insertions(+), 43 deletions(-) delete mode 100644 Documentation/devicetree/bindings/sound/alc5632.txt create mode 100644 Documentation/devicetree/bindings/sound/realtek,alc5632.yaml