Message ID | 20230323130511.16367-1-danascape@gmail.com |
---|---|
State | Changes Requested, archived |
Headers | show |
Series | ASoC: dt-bindings: alc5632: Convert to dtschema | expand |
Context | Check | Description |
---|---|---|
robh/checkpatch | warning | total: 0 errors, 2 warnings, 63 lines checked |
robh/patch-applied | success | |
robh/dtbs-check | warning | build log |
robh/dt-meta-schema | success |
On 23/03/2023 14:05, Saalim Quadri wrote: > Convert the ALC5632 audio codec bindings to DT schema. > > Signed-off-by: Saalim Quadri <danascape@gmail.com> Thank you for your patch. There is something to discuss/improve. > @@ -0,0 +1,63 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/realtek,alc5632.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: ALC5632 audio CODEC > + > +description: | > + Pins on the device (for linking into audio routes): > + * SPK_OUTP > + * SPK_OUTN > + * HP_OUT_L > + * HP_OUT_R > + * AUX_OUT_P > + * AUX_OUT_N > + * LINE_IN_L > + * LINE_IN_R > + * PHONE_P > + * PHONE_N > + * MIC1_P > + * MIC1_N > + * MIC2_P > + * MIC2_N > + * MICBIAS1 > + * DMICDAT > + > +maintainers: > + - Liam Girdwood <lgirdwood@gmail.com> This should not be subsystem maintainer but someone related to the device. It's maintainer or interested contributor. Unless that's the case here? > + > +properties: > + compatible: > + const: realtek,alc5632 > + > + reg: > + maxItems: 1 > + > + '#gpio-cells': > + const: 2 > + > + gpio-controller: true > + > +required: > + - compatible > + - reg > + - '#gpio-cells' > + - gpio-controller > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/gpio/gpio.h> > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + alc5632: alc5632@1a { Node name: codec and drop alc5632 label > + compatible = "realtek,alc5632"; > + reg = <0x1a>; > + gpio-controller; > + #gpio-cells = <2>; > + }; > + }; Best regards, Krzysztof
Hello, This is my first time using the Linux Kernel Mailing List. I apologise if I commit any mistakes. > This should not be subsystem maintainer but someone related to the > device. It's maintainer or interested contributor. Unless that's the > case here? yes it is wrong, he is not the subsystem maintainer. I will send the updated patch. I have a doubt, for the maintainers list, is it required to include all the names of the subsystem maintainer in the yaml too? As for this codec, there are 4, shall I include the names of all of them or the one to whom the module is authored to? Apologies, Saalim
On 23/03/2023 18:11, Saalim Quadri wrote: > Hello, > > This is my first time using the Linux Kernel Mailing List. I apologise if I commit any mistakes. > >> This should not be subsystem maintainer but someone related to the >> device. It's maintainer or interested contributor. Unless that's the >> case here? > > yes it is wrong, he is not the subsystem maintainer. I will send the updated patch. > > I have a doubt, for the maintainers list, is it required to include all the names of the subsystem maintainer > in the yaml too? As for this codec, there are 4, shall I include the names of all of them or the one to whom the > module is authored to? Depends, choose one or two names, maybe the most active. Best regards, Krzysztof
On Thu, Mar 23, 2023 at 08:08:33PM +0100, Krzysztof Kozlowski wrote: > On 23/03/2023 18:11, Saalim Quadri wrote: > > I have a doubt, for the maintainers list, is it required to include all the names of the subsystem maintainer > > in the yaml too? As for this codec, there are 4, shall I include the names of all of them or the one to whom the > Depends, choose one or two names, maybe the most active. Note that the binding should have maintainers for the specific binding, not the kernel subsystem.
On 23/03/2023 20:17, Mark Brown wrote: > On Thu, Mar 23, 2023 at 08:08:33PM +0100, Krzysztof Kozlowski wrote: >> On 23/03/2023 18:11, Saalim Quadri wrote: > >>> I have a doubt, for the maintainers list, is it required to include all the names of the subsystem maintainer >>> in the yaml too? As for this codec, there are 4, shall I include the names of all of them or the one to whom the > >> Depends, choose one or two names, maybe the most active. > > Note that the binding should have maintainers for the specific binding, > not the kernel subsystem. Yes. That's what I also said in the beginning, but for some reason Saalim cut this part... and re-added subsystem maintainers. Best regards, Krzysztof
> Yes. That's what I also said in the beginning, but for some reason > Saalim cut this part... and re-added subsystem maintainers. The file was last updated a few years back and it was by Mark, so I added him as well, while the original binding was written by Leon only, so I added him as well. Regards, Saalim
diff --git a/Documentation/devicetree/bindings/sound/alc5632.txt b/Documentation/devicetree/bindings/sound/alc5632.txt deleted file mode 100644 index ffd886d110bd..000000000000 --- a/Documentation/devicetree/bindings/sound/alc5632.txt +++ /dev/null @@ -1,43 +0,0 @@ -ALC5632 audio CODEC - -This device supports I2C only. - -Required properties: - - - compatible : "realtek,alc5632" - - - reg : the I2C address of the device. - - - gpio-controller : Indicates this device is a GPIO controller. - - - #gpio-cells : Should be two. The first cell is the pin number and the - second cell is used to specify optional parameters (currently unused). - -Pins on the device (for linking into audio routes): - - * SPK_OUTP - * SPK_OUTN - * HP_OUT_L - * HP_OUT_R - * AUX_OUT_P - * AUX_OUT_N - * LINE_IN_L - * LINE_IN_R - * PHONE_P - * PHONE_N - * MIC1_P - * MIC1_N - * MIC2_P - * MIC2_N - * MICBIAS1 - * DMICDAT - -Example: - -alc5632: alc5632@1e { - compatible = "realtek,alc5632"; - reg = <0x1a>; - - gpio-controller; - #gpio-cells = <2>; -}; diff --git a/Documentation/devicetree/bindings/sound/realtek,alc5632.yaml b/Documentation/devicetree/bindings/sound/realtek,alc5632.yaml new file mode 100644 index 000000000000..7c2de067fb27 --- /dev/null +++ b/Documentation/devicetree/bindings/sound/realtek,alc5632.yaml @@ -0,0 +1,63 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/realtek,alc5632.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: ALC5632 audio CODEC + +description: | + Pins on the device (for linking into audio routes): + * SPK_OUTP + * SPK_OUTN + * HP_OUT_L + * HP_OUT_R + * AUX_OUT_P + * AUX_OUT_N + * LINE_IN_L + * LINE_IN_R + * PHONE_P + * PHONE_N + * MIC1_P + * MIC1_N + * MIC2_P + * MIC2_N + * MICBIAS1 + * DMICDAT + +maintainers: + - Liam Girdwood <lgirdwood@gmail.com> + +properties: + compatible: + const: realtek,alc5632 + + reg: + maxItems: 1 + + '#gpio-cells': + const: 2 + + gpio-controller: true + +required: + - compatible + - reg + - '#gpio-cells' + - gpio-controller + +additionalProperties: false + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + i2c { + #address-cells = <1>; + #size-cells = <0>; + alc5632: alc5632@1a { + compatible = "realtek,alc5632"; + reg = <0x1a>; + gpio-controller; + #gpio-cells = <2>; + }; + };
Convert the ALC5632 audio codec bindings to DT schema. Signed-off-by: Saalim Quadri <danascape@gmail.com> --- .../devicetree/bindings/sound/alc5632.txt | 43 ------------- .../bindings/sound/realtek,alc5632.yaml | 63 +++++++++++++++++++ 2 files changed, 63 insertions(+), 43 deletions(-) delete mode 100644 Documentation/devicetree/bindings/sound/alc5632.txt create mode 100644 Documentation/devicetree/bindings/sound/realtek,alc5632.yaml