| Message ID | 20230323035531.3808192-1-peng.fan@oss.nxp.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [linux-next,V3,1/2] dt-bindings: usb: snps,dwc3: correct i.MX8MQ support | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 66 lines checked |
| robh/patch-applied | fail | build log |
On Thu, 23 Mar 2023 11:55:30 +0800, Peng Fan (OSS) wrote: > From: Peng Fan <peng.fan@nxp.com> > > The previous i.MX8MQ support breaks rockchip,dwc3 support, > so use select to restrict i.MX8MQ support and avoid break others. > > Fixes: 3754c41c7686 ("dt-bindings: usb: snps,dwc3: support i.MX8MQ") > Signed-off-by: Peng Fan <peng.fan@nxp.com> > --- > > V3: > Drop duplicated ones. with patch 2/2 there is no error anymore > V2: > Add a new yaml > > .../bindings/usb/fsl,imx8mq-dwc3.yaml | 48 +++++++++++++++++++ > .../devicetree/bindings/usb/snps,dwc3.yaml | 12 ++--- > 2 files changed, 53 insertions(+), 7 deletions(-) > create mode 100644 Documentation/devicetree/bindings/usb/fsl,imx8mq-dwc3.yaml > Reviewed-by: Rob Herring <robh@kernel.org>
On Thu, Mar 23, 2023 at 11:55:31AM +0800, Peng Fan (OSS) wrote: > From: Peng Fan <peng.fan@nxp.com> > > The property is NXP downstream property that there is no user > in upstream, drop it. > > Signed-off-by: Peng Fan <peng.fan@nxp.com> Applied, thanks!
diff --git a/Documentation/devicetree/bindings/usb/fsl,imx8mq-dwc3.yaml b/Documentation/devicetree/bindings/usb/fsl,imx8mq-dwc3.yaml new file mode 100644 index 000000000000..d2ccfb35b392 --- /dev/null +++ b/Documentation/devicetree/bindings/usb/fsl,imx8mq-dwc3.yaml @@ -0,0 +1,48 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/usb/fsl,imx8mq-dwc3.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: NXP iMX8MQ Soc USB Controller + +maintainers: + - Li Jun <jun.li@nxp.com> + - Peng Fan <peng.fan@nxp.com> + +select: + properties: + compatible: + contains: + enum: + - fsl,imx8mq-dwc3 + required: + - compatible + +properties: + compatible: + items: + - const: fsl,imx8mq-dwc3 + - const: snps,dwc3 + +allOf: + - $ref: snps,dwc3.yaml# + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/clock/imx8mq-clock.h> + #include <dt-bindings/interrupt-controller/arm-gic.h> + + usb_dwc3_1: usb@38200000 { + compatible = "fsl,imx8mq-dwc3", "snps,dwc3"; + reg = <0x38200000 0x10000>; + clocks = <&clk IMX8MQ_CLK_USB2_CTRL_ROOT>, + <&clk IMX8MQ_CLK_USB_CORE_REF>, + <&clk IMX8MQ_CLK_32K>; + clock-names = "bus_early", "ref", "suspend"; + interrupts = <GIC_SPI 41 IRQ_TYPE_LEVEL_HIGH>; + phys = <&usb3_phy1>, <&usb3_phy1>; + phy-names = "usb2-phy", "usb3-phy"; + }; diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml index 16c7d06c9172..c167fd577cae 100644 --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml @@ -30,13 +30,11 @@ allOf: properties: compatible: - oneOf: - - items: - - const: fsl,imx8mq-dwc3 - - const: snps,dwc3 - - const: snps,dwc3 - - const: synopsys,dwc3 - deprecated: true + contains: + oneOf: + - const: snps,dwc3 + - const: synopsys,dwc3 + deprecated: true reg: maxItems: 1