| Message ID | 20230321184811.3325725-1-bhupesh.sharma@linaro.org |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | [v2,1/1] dt-bindings: dma: Add support for SM6115 and QCS2290 SoCs | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 21.03.2023 19:48, Bhupesh Sharma wrote: > Add new compatible for BAM DMA engine version v1.7.4 which is > found on Qualcomm SM6115 and QCS2290 SoCs. All compatibles upstream are QCM2290-themed, let's keep it consistent. [...] > + - items: > + - enum: > + # SDM845, SM6115, SM8150, SM8250 and QRB2290 The robotics SoC is QRB2210, but this should be QCM. Konrad > + - qcom,bam-v1.7.4 > + - const: qcom,bam-v1.7.0 > > clocks: > maxItems: 1
On Wed, 22 Mar 2023 at 00:58, Konrad Dybcio <konrad.dybcio@linaro.org> wrote: > > > > On 21.03.2023 19:48, Bhupesh Sharma wrote: > > Add new compatible for BAM DMA engine version v1.7.4 which is > > found on Qualcomm SM6115 and QCS2290 SoCs. > All compatibles upstream are QCM2290-themed, let's keep it consistent. > > [...] > > > + - items: > > + - enum: > > + # SDM845, SM6115, SM8150, SM8250 and QRB2290 > The robotics SoC is QRB2210, but this should be QCM. Sure, will be addressed in v2. Thanks. > > + - qcom,bam-v1.7.4 > > + - const: qcom,bam-v1.7.0 > > > > clocks: > > maxItems: 1
diff --git a/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml b/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml index f1ddcf672261..bed966fa7653 100644 --- a/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml +++ b/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml @@ -15,13 +15,21 @@ allOf: properties: compatible: - enum: - # APQ8064, IPQ8064 and MSM8960 - - qcom,bam-v1.3.0 - # MSM8974, APQ8074 and APQ8084 - - qcom,bam-v1.4.0 - # MSM8916 and SDM845 - - qcom,bam-v1.7.0 + oneOf: + - items: + - enum: + # APQ8064, IPQ8064 and MSM8960 + - qcom,bam-v1.3.0 + # MSM8974, APQ8074 and APQ8084 + - qcom,bam-v1.4.0 + # MSM8916 + - qcom,bam-v1.7.0 + + - items: + - enum: + # SDM845, SM6115, SM8150, SM8250 and QRB2290 + - qcom,bam-v1.7.4 + - const: qcom,bam-v1.7.0 clocks: maxItems: 1
Add new compatible for BAM DMA engine version v1.7.4 which is found on Qualcomm SM6115 and QCS2290 SoCs. Since its very similar to v1.7.0 used on SM8150 like SoCs, mark the comptible scheme accordingly. While at it, also update qcom,bam-dma bindings to add comments which describe the BAM DMA versions used in SM8150 and SM8250 SoCs. This provides an easy reference for identifying the actual BAM DMA version available on Qualcomm SoCs. Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> --- Changes since v1: ~ v1 can be viewed here: https://lore.kernel.org/linux-arm-msm/20230320071211.3005769-1-bhupesh.sharma@linaro.org/ ~ Addressed Konrad's comments on v1, where he suggested how compatibles should be used for SoCs which support BAM DMA engine v1.7.4 ~ Dropped v1's [PATCH 2/2] in v2. .../devicetree/bindings/dma/qcom,bam-dma.yaml | 22 +++++++++++++------ 1 file changed, 15 insertions(+), 7 deletions(-)