| Message ID | 20230317082950.12738-2-zhuyinbo@loongson.cn |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | spi: loongson: add bus driver for the loongson spi | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dt-meta-schema | fail | build log |
On 17/03/2023 09:29, Yinbo Zhu wrote: > Add the Loongson platform spi binding with DT schema format using > json-schema. > > Signed-off-by: Yinbo Zhu <zhuyinbo@loongson.cn> > --- > .../bindings/spi/loongson,ls-spi.yaml | 44 +++++++++++++++++++ > MAINTAINERS | 6 +++ > 2 files changed, 50 insertions(+) > create mode 100644 Documentation/devicetree/bindings/spi/loongson,ls-spi.yaml > > diff --git a/Documentation/devicetree/bindings/spi/loongson,ls-spi.yaml b/Documentation/devicetree/bindings/spi/loongson,ls-spi.yaml > new file mode 100644 > index 000000000000..936b8dc82ce8 > --- /dev/null > +++ b/Documentation/devicetree/bindings/spi/loongson,ls-spi.yaml > @@ -0,0 +1,44 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > + Drop blank line above. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/spi/loongson,ls-spi.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Loongson SPI controller > + > +maintainers: > + - Yinbo Zhu <zhuyinbo@loongson.cn> > + > +allOf: > + - $ref: /schemas/spi/spi-controller.yaml# > + > +properties: > + compatible: > + enum: > + - loongson,ls2k-spi > + - loongson,ls7a-spi > + > + reg: > + maxItems: 1 > + > + clocks: > + minItems: 1 I don't understand why did you change it. I did not ask for it. Best regards, Krzysztof
在 2023/3/17 下午5:15, Krzysztof Kozlowski 写道: > On 17/03/2023 09:29, Yinbo Zhu wrote: >> Add the Loongson platform spi binding with DT schema format using >> json-schema. >> >> Signed-off-by: Yinbo Zhu <zhuyinbo@loongson.cn> >> --- >> .../bindings/spi/loongson,ls-spi.yaml | 44 +++++++++++++++++++ >> MAINTAINERS | 6 +++ >> 2 files changed, 50 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/spi/loongson,ls-spi.yaml >> >> diff --git a/Documentation/devicetree/bindings/spi/loongson,ls-spi.yaml b/Documentation/devicetree/bindings/spi/loongson,ls-spi.yaml >> new file mode 100644 >> index 000000000000..936b8dc82ce8 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/spi/loongson,ls-spi.yaml >> @@ -0,0 +1,44 @@ >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >> + > Drop blank line above. > >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/spi/loongson,ls-spi.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Loongson SPI controller >> + >> +maintainers: >> + - Yinbo Zhu <zhuyinbo@loongson.cn> >> + >> +allOf: >> + - $ref: /schemas/spi/spi-controller.yaml# >> + >> +properties: >> + compatible: >> + enum: >> + - loongson,ls2k-spi >> + - loongson,ls7a-spi >> + >> + reg: >> + maxItems: 1 >> + >> + clocks: >> + minItems: 1 > I don't understand why did you change it. I did not ask for it. > > Best regards, > Krzysztof Add clocks "minItems: 1" description is for fix yaml file compile issue.
On Fri, 17 Mar 2023 16:29:49 +0800, Yinbo Zhu wrote: > Add the Loongson platform spi binding with DT schema format using > json-schema. > > Signed-off-by: Yinbo Zhu <zhuyinbo@loongson.cn> > --- > .../bindings/spi/loongson,ls-spi.yaml | 44 +++++++++++++++++++ > MAINTAINERS | 6 +++ > 2 files changed, 50 insertions(+) > create mode 100644 Documentation/devicetree/bindings/spi/loongson,ls-spi.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: Error: Documentation/devicetree/bindings/spi/loongson,ls-spi.example.dts:22.28-29 syntax error FATAL ERROR: Unable to parse input tree make[1]: *** [scripts/Makefile.lib:419: Documentation/devicetree/bindings/spi/loongson,ls-spi.example.dtb] Error 1 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:1512: dt_binding_check] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230317082950.12738-2-zhuyinbo@loongson.cn The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On 17/03/2023 11:00, zhuyinbo wrote: >>> +properties: >>> + compatible: >>> + enum: >>> + - loongson,ls2k-spi >>> + - loongson,ls7a-spi >>> + >>> + reg: >>> + maxItems: 1 >>> + >>> + clocks: >>> + minItems: 1 >> I don't understand why did you change it. I did not ask for it. >> >> Best regards, >> Krzysztof > Add clocks "minItems: 1" description is for fix yaml file compile issue. minItems: 1 is not correct, so you cannot use incorrect code to suppress some warning. This should be list the clocks or use maxItems: 1, if you have only one clock. Best regards, Krzysztof
On 17/03/2023 16:51, Krzysztof Kozlowski wrote: > On 17/03/2023 11:00, zhuyinbo wrote: >>>> +properties: >>>> + compatible: >>>> + enum: >>>> + - loongson,ls2k-spi >>>> + - loongson,ls7a-spi >>>> + >>>> + reg: >>>> + maxItems: 1 >>>> + >>>> + clocks: >>>> + minItems: 1 >>> I don't understand why did you change it. I did not ask for it. >>> >>> Best regards, >>> Krzysztof >> Add clocks "minItems: 1" description is for fix yaml file compile issue. > > minItems: 1 is not correct, so you cannot use incorrect code to suppress > some warning. This should be list the clocks or use maxItems: 1, if you > have only one clock. BTW, as Rob's bot reports, this wasn't even tested... Please test the patches before sending them. Best regards, Krzysztof
On Fri, Mar 17, 2023 at 04:51:48PM +0100, Krzysztof Kozlowski wrote: > On 17/03/2023 16:51, Krzysztof Kozlowski wrote: > > minItems: 1 is not correct, so you cannot use incorrect code to suppress > > some warning. This should be list the clocks or use maxItems: 1, if you > > have only one clock. > BTW, as Rob's bot reports, this wasn't even tested... Please test the > patches before sending them. If they're managing to see and try to fix warnings they're doing some kinds of testing, obviously they've missed something you wanted doing but there's clearly been some testing done.
在 2023/3/17 下午10:55, Rob Herring 写道: > On Fri, 17 Mar 2023 16:29:49 +0800, Yinbo Zhu wrote: >> Add the Loongson platform spi binding with DT schema format using >> json-schema. >> >> Signed-off-by: Yinbo Zhu <zhuyinbo@loongson.cn> >> --- >> .../bindings/spi/loongson,ls-spi.yaml | 44 +++++++++++++++++++ >> MAINTAINERS | 6 +++ >> 2 files changed, 50 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/spi/loongson,ls-spi.yaml >> > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > Error: Documentation/devicetree/bindings/spi/loongson,ls-spi.example.dts:22.28-29 syntax error > FATAL ERROR: Unable to parse input tree > make[1]: *** [scripts/Makefile.lib:419: Documentation/devicetree/bindings/spi/loongson,ls-spi.example.dtb] Error 1 > make[1]: *** Waiting for unfinished jobs.... > make: *** [Makefile:1512: dt_binding_check] Error 2 Hi Rob Herring, this error happen on 22 line, this need depend on https://lore.kernel.org/all/20230307115022.12846-1-zhuyinbo@loongson.cn/ 22 clocks = <&clk LOONGSON2_BOOT_CLK>; //22 line yaml code's dtb I had add change log in cover letter patch [PATCH v2 0/2], as follows, but robot still report error What should I do next time to ensure that your robot relies on other patches before testing ? Change in v2: 1. This [PATCH v2 1/2] dt-bindings patch need depend on clk patch: https:// lore.kernel.org/all/20230307115022.12846-1-zhuyinbo@loongson.cn/ Thanks, > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230317082950.12738-2-zhuyinbo@loongson.cn > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema.
在 2023/3/17 下午11:51, Krzysztof Kozlowski 写道: > On 17/03/2023 11:00, zhuyinbo wrote: >>>> +properties: >>>> + compatible: >>>> + enum: >>>> + - loongson,ls2k-spi >>>> + - loongson,ls7a-spi >>>> + >>>> + reg: >>>> + maxItems: 1 >>>> + >>>> + clocks: >>>> + minItems: 1 >>> I don't understand why did you change it. I did not ask for it. >>> >>> Best regards, >>> Krzysztof >> Add clocks "minItems: 1" description is for fix yaml file compile issue. > minItems: 1 is not correct, so you cannot use incorrect code to suppress > some warning. This should be list the clocks or use maxItems: 1, if you > have only one clock. okay, I got it. thanks. > > Best regards, > Krzysztof
在 2023/3/18 上午12:14, Mark Brown 写道: > On Fri, Mar 17, 2023 at 04:51:48PM +0100, Krzysztof Kozlowski wrote: >> On 17/03/2023 16:51, Krzysztof Kozlowski wrote: >>> minItems: 1 is not correct, so you cannot use incorrect code to suppress >>> some warning. This should be list the clocks or use maxItems: 1, if you >>> have only one clock. >> BTW, as Rob's bot reports, this wasn't even tested... Please test the >> patches before sending them. > If they're managing to see and try to fix warnings they're doing some > kinds of testing, obviously they've missed something you wanted doing > but there's clearly been some testing done. Thanks your understanding ! I had test it and this patch need depend on a clock patch, and I had added this depend on description on changelog, but I don't know how do make the robot can depend on my clock patch after testing. Thanks!
diff --git a/Documentation/devicetree/bindings/spi/loongson,ls-spi.yaml b/Documentation/devicetree/bindings/spi/loongson,ls-spi.yaml new file mode 100644 index 000000000000..936b8dc82ce8 --- /dev/null +++ b/Documentation/devicetree/bindings/spi/loongson,ls-spi.yaml @@ -0,0 +1,44 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) + +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/spi/loongson,ls-spi.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Loongson SPI controller + +maintainers: + - Yinbo Zhu <zhuyinbo@loongson.cn> + +allOf: + - $ref: /schemas/spi/spi-controller.yaml# + +properties: + compatible: + enum: + - loongson,ls2k-spi + - loongson,ls7a-spi + + reg: + maxItems: 1 + + clocks: + minItems: 1 + +required: + - compatible + - reg + - clocks + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/clock/loongson,ls2k-clk.h> + spi0: spi@1fff0220{ + compatible = "loongson,ls2k-spi"; + reg = <0x1fff0220 0x10>; + clocks = <&clk LOONGSON2_BOOT_CLK>; + #address-cells = <1>; + #size-cells = <0>; + }; diff --git a/MAINTAINERS b/MAINTAINERS index 25a0981c74b6..9bc2158c735d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -12157,6 +12157,12 @@ S: Maintained F: Documentation/devicetree/bindings/clock/loongson,ls2k-clk.yaml F: include/dt-bindings/clock/loongson,ls2k-clk.h +LOONGSON SPI DRIVER +M: Yinbo Zhu <zhuyinbo@loongson.cn> +L: linux-spi@vger.kernel.org +S: Maintained +F: Documentation/devicetree/bindings/spi/loongson,ls-spi.yaml + LSILOGIC MPT FUSION DRIVERS (FC/SAS/SPI) M: Sathya Prakash <sathya.prakash@broadcom.com> M: Sreekanth Reddy <sreekanth.reddy@broadcom.com>
Add the Loongson platform spi binding with DT schema format using json-schema. Signed-off-by: Yinbo Zhu <zhuyinbo@loongson.cn> --- .../bindings/spi/loongson,ls-spi.yaml | 44 +++++++++++++++++++ MAINTAINERS | 6 +++ 2 files changed, 50 insertions(+) create mode 100644 Documentation/devicetree/bindings/spi/loongson,ls-spi.yaml