| Message ID | 20230313225103.30512-15-Sergey.Semin@baikalelectronics.ru |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | dt-bindings: net: dwmac: Extend clocks, props desc and constraints | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 13/03/2023 23:51, Serge Semin wrote: > Currently some of the boolean properties defined in the DT-schema are > marked to have the basic boolean type meanwhile the rest referencing the > /schemas/types.yaml#/definitions/flag schema. For the sake of unification > let's convert the first group to referencing the pre-defined flag schema. > Thus bindings will look a bit more coherent and the DT-bindings > maintainers will have a better control over the booleans defined in the > schema (if ever needed). > > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> > --- > .../devicetree/bindings/net/snps,dwmac.yaml | 45 ++++++++++++------- > 1 file changed, 30 insertions(+), 15 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > index 69be39d55403..a863b5860566 100644 > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > @@ -120,11 +120,13 @@ properties: > maximum: 12 > > snps,rx-sched-sp: > - type: boolean > + $ref: /schemas/types.yaml#/definitions/flag > description: Strict priority If ever touching this, it should be other way -> boolean. Best regards, Krzysztof
On Thu, Mar 16, 2023 at 09:09:37AM +0100, Krzysztof Kozlowski wrote: > On 13/03/2023 23:51, Serge Semin wrote: > > Currently some of the boolean properties defined in the DT-schema are > > marked to have the basic boolean type meanwhile the rest referencing the > > /schemas/types.yaml#/definitions/flag schema. For the sake of unification > > let's convert the first group to referencing the pre-defined flag schema. > > Thus bindings will look a bit more coherent and the DT-bindings > > maintainers will have a better control over the booleans defined in the > > schema (if ever needed). > > > > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> > > --- > > .../devicetree/bindings/net/snps,dwmac.yaml | 45 ++++++++++++------- > > 1 file changed, 30 insertions(+), 15 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > index 69be39d55403..a863b5860566 100644 > > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > @@ -120,11 +120,13 @@ properties: > > maximum: 12 > > > > snps,rx-sched-sp: > > - type: boolean > > + $ref: /schemas/types.yaml#/definitions/flag > > description: Strict priority > > If ever touching this, it should be other way -> boolean. Ok. I'll drop the patch then. -Serge(y) > > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml index 69be39d55403..a863b5860566 100644 --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml @@ -120,11 +120,13 @@ properties: maximum: 12 snps,rx-sched-sp: - type: boolean + $ref: /schemas/types.yaml#/definitions/flag description: Strict priority + snps,rx-sched-wsp: - type: boolean + $ref: /schemas/types.yaml#/definitions/flag description: Weighted Strict priority + allOf: - if: required: @@ -144,11 +146,13 @@ properties: type: object properties: snps,dcb-algorithm: - type: boolean + $ref: /schemas/types.yaml#/definitions/flag description: Queue to be enabled as DCB + snps,avb-algorithm: - type: boolean + $ref: /schemas/types.yaml#/definitions/flag description: Queue to be enabled as AVB + snps,map-to-dma-channel: $ref: /schemas/types.yaml#/definitions/uint32 description: DMA channel id to map @@ -156,20 +160,25 @@ properties: maximum: 15 snps,route-avcp: - type: boolean + $ref: /schemas/types.yaml#/definitions/flag description: AV Untagged Control packets + snps,route-ptp: - type: boolean + $ref: /schemas/types.yaml#/definitions/flag description: PTP Packets + snps,route-dcbcp: - type: boolean + $ref: /schemas/types.yaml#/definitions/flag description: DCB Control Packets + snps,route-up: - type: boolean + $ref: /schemas/types.yaml#/definitions/flag description: Untagged Packets + snps,route-multi-broad: - type: boolean + $ref: /schemas/types.yaml#/definitions/flag description: Multicast & Broadcast Packets + snps,priority: $ref: /schemas/types.yaml#/definitions/uint32 description: Bitmask of the tagged frames priorities assigned to the queue @@ -255,17 +264,21 @@ properties: maximum: 16 snps,tx-sched-wrr: - type: boolean + $ref: /schemas/types.yaml#/definitions/flag description: Weighted Round Robin + snps,tx-sched-wfq: - type: boolean + $ref: /schemas/types.yaml#/definitions/flag description: Weighted Fair Queuing + snps,tx-sched-dwrr: - type: boolean + $ref: /schemas/types.yaml#/definitions/flag description: Deficit Weighted Round Robin + snps,tx-sched-sp: - type: boolean + $ref: /schemas/types.yaml#/definitions/flag description: Strict priority + allOf: - if: required: @@ -311,14 +324,16 @@ properties: maximum: 0x1312D0 snps,dcb-algorithm: - type: boolean + $ref: /schemas/types.yaml#/definitions/flag description: TX queue will be working in DCB + snps,avb-algorithm: - type: boolean + $ref: /schemas/types.yaml#/definitions/flag description: TX queue will be working in AVB. Queue 0 is reserved for legacy traffic and so no AVB is available in this queue. + snps,send_slope: $ref: /schemas/types.yaml#/definitions/uint32 description:
Currently some of the boolean properties defined in the DT-schema are marked to have the basic boolean type meanwhile the rest referencing the /schemas/types.yaml#/definitions/flag schema. For the sake of unification let's convert the first group to referencing the pre-defined flag schema. Thus bindings will look a bit more coherent and the DT-bindings maintainers will have a better control over the booleans defined in the schema (if ever needed). Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> --- .../devicetree/bindings/net/snps,dwmac.yaml | 45 ++++++++++++------- 1 file changed, 30 insertions(+), 15 deletions(-)