| Message ID | 20230307-topic-dsi_qcm-v3-9-8bd7e1add38a@linaro.org |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | Fix DSI host idx detection on HW revision clash | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Tue, 07 Mar 2023 14:01:47 +0100, Konrad Dybcio wrote: > Add a compatible for the DSI on SM6115. > > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> > --- > .../devicetree/bindings/display/msm/dsi-controller-main.yaml | 2 ++ > .../devicetree/bindings/display/msm/qcom,sm6115-mdss.yaml | 8 +++++++- > 2 files changed, 9 insertions(+), 1 deletion(-) > Acked-by: Rob Herring <robh@kernel.org>
On 2023-03-08 12:51:03, Rob Herring wrote: > > On Tue, 07 Mar 2023 14:01:47 +0100, Konrad Dybcio wrote: > > Add a compatible for the DSI on SM6115. > > > > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> > > --- > > .../devicetree/bindings/display/msm/dsi-controller-main.yaml | 2 ++ > > .../devicetree/bindings/display/msm/qcom,sm6115-mdss.yaml | 8 +++++++- > > 2 files changed, 9 insertions(+), 1 deletion(-) > > > > Acked-by: Rob Herring <robh@kernel.org> Shouldn't the examples in qcom,sm6115-mdss.yaml be updated below to reflect the binding changes?
On 14.03.2023 01:18, Marijn Suijten wrote: > On 2023-03-08 12:51:03, Rob Herring wrote: >> >> On Tue, 07 Mar 2023 14:01:47 +0100, Konrad Dybcio wrote: >>> Add a compatible for the DSI on SM6115. >>> >>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> >>> --- >>> .../devicetree/bindings/display/msm/dsi-controller-main.yaml | 2 ++ >>> .../devicetree/bindings/display/msm/qcom,sm6115-mdss.yaml | 8 +++++++- >>> 2 files changed, 9 insertions(+), 1 deletion(-) >>> >> >> Acked-by: Rob Herring <robh@kernel.org> > > Shouldn't the examples in qcom,sm6115-mdss.yaml be updated below to > reflect the binding changes? Yes it should, willfix Konrad
diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml index 94f4cdf88c95..d534451c8f7f 100644 --- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml +++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml @@ -25,6 +25,7 @@ properties: - qcom,sc7280-dsi-ctrl - qcom,sdm660-dsi-ctrl - qcom,sdm845-dsi-ctrl + - qcom,sm6115-dsi-ctrl - qcom,sm8150-dsi-ctrl - qcom,sm8250-dsi-ctrl - qcom,sm8350-dsi-ctrl @@ -351,6 +352,7 @@ allOf: contains: enum: - qcom,sdm845-dsi-ctrl + - qcom,sm6115-dsi-ctrl then: properties: clocks: diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm6115-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm6115-mdss.yaml index 2491cb100b33..605b1f654d78 100644 --- a/Documentation/devicetree/bindings/display/msm/qcom,sm6115-mdss.yaml +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm6115-mdss.yaml @@ -40,7 +40,13 @@ patternProperties: type: object properties: compatible: - const: qcom,dsi-ctrl-6g-qcm2290 + oneOf: + - items: + - const: qcom,sm6115-dsi-ctrl + - const: qcom,mdss-dsi-ctrl + - description: Old binding, please don't use + deprecated: true + const: qcom,dsi-ctrl-6g-qcm2290 "^phy@[0-9a-f]+$": type: object
Add a compatible for the DSI on SM6115. Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> --- .../devicetree/bindings/display/msm/dsi-controller-main.yaml | 2 ++ .../devicetree/bindings/display/msm/qcom,sm6115-mdss.yaml | 8 +++++++- 2 files changed, 9 insertions(+), 1 deletion(-)