| Message ID | 20230302-max9867-v1-1-aa9f7f25db5e@skidata.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | Add "mclk" support for maxim,max9867 | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 2 warnings, 51 lines checked |
| robh/patch-applied | success | |
| robh/dt-meta-schema | fail | build log |
On Thu, 02 Mar 2023 12:55:01 +0100, richard.leitner@linux.dev wrote: > From: Richard Leitner <richard.leitner@skidata.com> > > Convert from max9867.txt to maxim,max9867.yaml and add missing > '#sound-dai-cells' property. > > Signed-off-by: Richard Leitner <richard.leitner@skidata.com> > --- > .../devicetree/bindings/sound/max9867.txt | 17 -------- > .../devicetree/bindings/sound/maxim,max9867.yaml | 51 ++++++++++++++++++++++ > 2 files changed, 51 insertions(+), 17 deletions(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/maxim,max9867.yaml: 'oneOf' conditional failed, one must be fixed: 'unevaluatedProperties' is a required property 'additionalProperties' is a required property hint: Either unevaluatedProperties or additionalProperties must be present from schema $id: http://devicetree.org/meta-schemas/core.yaml# ./Documentation/devicetree/bindings/sound/maxim,max9867.yaml: $id: relative path/filename doesn't match actual path or filename expected: http://devicetree.org/schemas/sound/maxim,max9867.yaml# Error: Documentation/devicetree/bindings/sound/maxim,max9867.example.dts:18.9-13 syntax error FATAL ERROR: Unable to parse input tree make[1]: *** [scripts/Makefile.lib:434: Documentation/devicetree/bindings/sound/maxim,max9867.example.dtb] Error 1 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:1508: dt_binding_check] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230302-max9867-v1-1-aa9f7f25db5e@skidata.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On 02/03/2023 12:55, richard.leitner@linux.dev wrote: > From: Richard Leitner <richard.leitner@skidata.com> > > Convert from max9867.txt to maxim,max9867.yaml and add missing > '#sound-dai-cells' property. Thank you for your patch. There is something to discuss/improve. Except wrong ID (and missing test): > + > +examples: > + - | > + &i2c { > + max9867: max9867@18 { Generic node names, so "codec" and drop the unused label. Use 4 spaces for example indentation. > + compatible = "maxim,max9867"; > + #sound-dai-cells = <0>; > + reg = <0x18>; Best regards, Krzysztof
On Thu, Mar 02, 2023 at 02:31:14PM +0100, Krzysztof Kozlowski wrote: > On 02/03/2023 12:55, richard.leitner@linux.dev wrote: > > From: Richard Leitner <richard.leitner@skidata.com> > > > > Convert from max9867.txt to maxim,max9867.yaml and add missing > > '#sound-dai-cells' property. > > Thank you for your patch. There is something to discuss/improve. > > Except wrong ID (and missing test): > > > + > > +examples: > > + - | > > + &i2c { > > + max9867: max9867@18 { > > Generic node names, so "codec" and drop the unused label. Thanks for the review and feedback. I'll fix that in v2. > > Use 4 spaces for example indentation. Ok. checkpatch.pl didn't complain about that so I thought this was fine. Are there any other scripts/tools to check for correct formatting of bindings? > > > + compatible = "maxim,max9867"; > > + #sound-dai-cells = <0>; > > + reg = <0x18>; > > Best regards, > Krzysztof > Thanks & regards;rl
On Thu, Mar 02, 2023 at 07:05:02AM -0600, Rob Herring wrote: > > On Thu, 02 Mar 2023 12:55:01 +0100, richard.leitner@linux.dev wrote: > > From: Richard Leitner <richard.leitner@skidata.com> > > > > Convert from max9867.txt to maxim,max9867.yaml and add missing > > '#sound-dai-cells' property. > > > > Signed-off-by: Richard Leitner <richard.leitner@skidata.com> > > --- > > .../devicetree/bindings/sound/max9867.txt | 17 -------- > > .../devicetree/bindings/sound/maxim,max9867.yaml | 51 ++++++++++++++++++++++ > > 2 files changed, 51 insertions(+), 17 deletions(-) > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): Thank you for the pointer, Rob! Will fix those in v2 and from now on run 'make DT_CHECKER_FLAGS=-m dt_binding_check' before sending any patches 😉 regards;rl > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/maxim,max9867.yaml: 'oneOf' conditional failed, one must be fixed: > 'unevaluatedProperties' is a required property > 'additionalProperties' is a required property > hint: Either unevaluatedProperties or additionalProperties must be present > from schema $id: http://devicetree.org/meta-schemas/core.yaml# > ./Documentation/devicetree/bindings/sound/maxim,max9867.yaml: $id: relative path/filename doesn't match actual path or filename > expected: http://devicetree.org/schemas/sound/maxim,max9867.yaml# > Error: Documentation/devicetree/bindings/sound/maxim,max9867.example.dts:18.9-13 syntax error > FATAL ERROR: Unable to parse input tree > make[1]: *** [scripts/Makefile.lib:434: Documentation/devicetree/bindings/sound/maxim,max9867.example.dtb] Error 1 > make[1]: *** Waiting for unfinished jobs.... > make: *** [Makefile:1508: dt_binding_check] Error 2 > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230302-max9867-v1-1-aa9f7f25db5e@skidata.com > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema. >
diff --git a/Documentation/devicetree/bindings/sound/max9867.txt b/Documentation/devicetree/bindings/sound/max9867.txt deleted file mode 100644 index b8bd914ee697..000000000000 --- a/Documentation/devicetree/bindings/sound/max9867.txt +++ /dev/null @@ -1,17 +0,0 @@ -max9867 codec - -This device supports I2C mode only. - -Required properties: - -- compatible : "maxim,max9867" -- reg : The chip select number on the I2C bus - -Example: - -&i2c { - max9867: max9867@18 { - compatible = "maxim,max9867"; - reg = <0x18>; - }; -}; diff --git a/Documentation/devicetree/bindings/sound/maxim,max9867.yaml b/Documentation/devicetree/bindings/sound/maxim,max9867.yaml new file mode 100644 index 000000000000..cefa43c3d34e --- /dev/null +++ b/Documentation/devicetree/bindings/sound/maxim,max9867.yaml @@ -0,0 +1,51 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/max9867.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Maxim Integrated MAX9867 CODEC + +description: | + This device supports I2C only. + Pins on the device (for linking into audio routes): + * LOUT + * ROUT + * LINL + * LINR + * MICL + * MICR + * DMICL + * DMICR + +maintainers: + - Ladislav Michl <ladis@linux-mips.org> + +allOf: + - $ref: dai-common.yaml# + +properties: + compatible: + enum: + - maxim,max9867 + + '#sound-dai-cells': + const: 0 + + reg: + maxItems: 1 + +required: + - compatible + - reg + +examples: + - | + &i2c { + max9867: max9867@18 { + compatible = "maxim,max9867"; + #sound-dai-cells = <0>; + reg = <0x18>; + }; + }; +...