diff mbox series

[2/2] dt-bindings: altera: Add enclustra mercury PE1

Message ID 20230207094101.522240-2-s.trumtrar@pengutronix.de
State Superseded, archived
Headers show
Series None | expand

Checks

Context Check Description
robh/checkpatch success
robh/patch-applied success
robh/dtbs-check warning build log
robh/dt-meta-schema success

Commit Message

Steffen Trumtrar Feb. 7, 2023, 9:41 a.m. UTC
Add binding for the enclustra PE1 baseboard from enclustra GmbH.

Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
---
 Documentation/devicetree/bindings/arm/altera.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Krzysztof Kozlowski Feb. 7, 2023, 10:48 a.m. UTC | #1
On 07/02/2023 10:41, Steffen Trumtrar wrote:
> Add binding for the enclustra PE1 baseboard from enclustra GmbH.
> 
> Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> ---
>  Documentation/devicetree/bindings/arm/altera.yaml | 1 +

Bindings are before the usage. Otherwise you have checkpatch error.

>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/altera.yaml b/Documentation/devicetree/bindings/arm/altera.yaml
> index 3eee03aa935c..6f306f9f2f9d 100644
> --- a/Documentation/devicetree/bindings/arm/altera.yaml
> +++ b/Documentation/devicetree/bindings/arm/altera.yaml
> @@ -32,6 +32,7 @@ properties:
>          items:
>            - enum:
>                - google,chameleon-v3
> +              - enclustra,mercury-pe1

Messed order, keep alphabetical order.

>            - const: enclustra,mercury-aa1
>            - const: altr,socfpga-arria10
>            - const: altr,socfpga

Best regards,
Krzysztof
Steffen Trumtrar Feb. 7, 2023, 12:47 p.m. UTC | #2
On Tue, Feb 07, 2023 at 11:48:56AM +0100, Krzysztof Kozlowski wrote:
> On 07/02/2023 10:41, Steffen Trumtrar wrote:
> > Add binding for the enclustra PE1 baseboard from enclustra GmbH.
> > 
> > Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> > ---
> >  Documentation/devicetree/bindings/arm/altera.yaml | 1 +
> 
> Bindings are before the usage. Otherwise you have checkpatch error.
> 
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/arm/altera.yaml b/Documentation/devicetree/bindings/arm/altera.yaml
> > index 3eee03aa935c..6f306f9f2f9d 100644
> > --- a/Documentation/devicetree/bindings/arm/altera.yaml
> > +++ b/Documentation/devicetree/bindings/arm/altera.yaml
> > @@ -32,6 +32,7 @@ properties:
> >          items:
> >            - enum:
> >                - google,chameleon-v3
> > +              - enclustra,mercury-pe1
> 
> Messed order, keep alphabetical order.
> 
> >            - const: enclustra,mercury-aa1
> >            - const: altr,socfpga-arria10
> >            - const: altr,socfpga
> 

Ack.

Thanks,
Steffen Trumtrar
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/altera.yaml b/Documentation/devicetree/bindings/arm/altera.yaml
index 3eee03aa935c..6f306f9f2f9d 100644
--- a/Documentation/devicetree/bindings/arm/altera.yaml
+++ b/Documentation/devicetree/bindings/arm/altera.yaml
@@ -32,6 +32,7 @@  properties:
         items:
           - enum:
               - google,chameleon-v3
+              - enclustra,mercury-pe1
           - const: enclustra,mercury-aa1
           - const: altr,socfpga-arria10
           - const: altr,socfpga