| Message ID | 20230207-iommu-support-v1-1-4a902f9aa412@baylibre.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Add IOMMU support to MT8365 SoC | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 3/29/23 11:52, Alexandre Mergnat wrote: > Add binding description for mediatek,mt8365-smi-common > > Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> > --- > .../devicetree/bindings/memory-controllers/mediatek,smi-common.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml > index a8fda30cccbb..d599a190952f 100644 > --- a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml > +++ b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml > @@ -49,6 +49,10 @@ properties: > - const: mediatek,mt7623-smi-common > - const: mediatek,mt2701-smi-common > > + - items: > + - const: mediatek,mt8365-smi-common > + - const: mediatek,mt8186-smi-common > + > reg: > maxItems: 1 > >
On Wed, 2023-03-29 at 11:52 +0200, Alexandre Mergnat wrote: > > Add binding description for mediatek,mt8365-smi-common > > Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com> > --- > .../devicetree/bindings/memory-controllers/mediatek,smi- > common.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/memory- > controllers/mediatek,smi-common.yaml > b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi- > common.yaml > index a8fda30cccbb..d599a190952f 100644 > --- a/Documentation/devicetree/bindings/memory- > controllers/mediatek,smi-common.yaml > +++ b/Documentation/devicetree/bindings/memory- > controllers/mediatek,smi-common.yaml > @@ -49,6 +49,10 @@ properties: > - const: mediatek,mt7623-smi-common > - const: mediatek,mt2701-smi-common > > + - items: > + - const: mediatek,mt8365-smi-common > + - const: mediatek,mt8186-smi-common > + mt8365 is not same with mt8186. From the code, the bus_sel for mt8186 is: .bus_sel = F_MMU1_LARB(1) | F_MMU1_LARB(4) | F_MMU1_LARB(7), the bus_sel for mt8365 is: .bus_sel = F_MMU1_LARB(2) | F_MMU1_LARB(4), I guess we should add a independent "mediatek,mt8365-smi-common". > reg: > maxItems: 1 > > > -- > 2.25.1 >
diff --git a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml index a8fda30cccbb..d599a190952f 100644 --- a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml +++ b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml @@ -49,6 +49,10 @@ properties: - const: mediatek,mt7623-smi-common - const: mediatek,mt2701-smi-common + - items: + - const: mediatek,mt8365-smi-common + - const: mediatek,mt8186-smi-common + reg: maxItems: 1
Add binding description for mediatek,mt8365-smi-common Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com> --- .../devicetree/bindings/memory-controllers/mediatek,smi-common.yaml | 4 ++++ 1 file changed, 4 insertions(+)