| Message ID | 20230127203525.198295-1-krzysztof.kozlowski@linaro.org |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | dt-bindings: display: bridge: sil,sii8620: convert to dtschema | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 107 lines checked |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
Hi Krzysztof, Thank you for the patch. On Fri, Jan 27, 2023 at 09:35:25PM +0100, Krzysztof Kozlowski wrote: > Convert the Silicon Image SiI8620 HDMI/MHL bridge bindings to DT schema. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../bindings/display/bridge/sil,sii8620.yaml | 107 ++++++++++++++++++ > .../bindings/display/bridge/sil-sii8620.txt | 33 ------ > 2 files changed, 107 insertions(+), 33 deletions(-) > create mode 100644 Documentation/devicetree/bindings/display/bridge/sil,sii8620.yaml > delete mode 100644 Documentation/devicetree/bindings/display/bridge/sil-sii8620.txt > > diff --git a/Documentation/devicetree/bindings/display/bridge/sil,sii8620.yaml b/Documentation/devicetree/bindings/display/bridge/sil,sii8620.yaml > new file mode 100644 > index 000000000000..90532bb99161 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/bridge/sil,sii8620.yaml > @@ -0,0 +1,107 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/bridge/sil,sii8620.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Silicon Image SiI8620 HDMI/MHL bridge > + > +maintainers: > + - Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > + > +properties: > + compatible: > + const: sil,sii8620 > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + clock-names: > + items: > + - const: xtal > + > + cvcc10-supply: > + description: Digital Core Supply Voltage (1.0V) > + > + interrupts: > + maxItems: 1 > + > + iovcc18-supply: > + description: I/O Supply Voltage (1.8V) > + > + reset-gpios: > + maxItems: 1 > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + unevaluatedProperties: false > + > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/properties/port > + description: > + Video port for HDMI (encoder) input > + > + port@1: > + $ref: /schemas/graph.yaml#/properties/port > + description: > + MHL to connector port > + > + required: > + - port@0 Why port@0 only ? > + > +required: > + - compatible > + - reg > + - clocks > + - cvcc10-supply > + - interrupts > + - iovcc18-supply > + - reset-gpios > + - ports > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/gpio/gpio.h> > + #include <dt-bindings/interrupt-controller/irq.h> > + > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + bridge@39 { > + reg = <0x39>; > + compatible = "sil,sii8620"; > + cvcc10-supply = <&ldo36_reg>; > + iovcc18-supply = <&ldo34_reg>; > + interrupt-parent = <&gpf0>; > + interrupts = <2 IRQ_TYPE_LEVEL_HIGH>; > + reset-gpios = <&gpv7 0 GPIO_ACTIVE_LOW>; > + clocks = <&pmu_system_controller 0>; > + clock-names = "xtal"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + mhl_to_hdmi: endpoint { > + remote-endpoint = <&hdmi_to_mhl>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + mhl_to_musb_con: endpoint { > + remote-endpoint = <&musb_con_to_mhl>; > + }; > + }; > + }; > + }; > + }; > diff --git a/Documentation/devicetree/bindings/display/bridge/sil-sii8620.txt b/Documentation/devicetree/bindings/display/bridge/sil-sii8620.txt > deleted file mode 100644 > index b05052f7d62f..000000000000 > --- a/Documentation/devicetree/bindings/display/bridge/sil-sii8620.txt > +++ /dev/null > @@ -1,33 +0,0 @@ > -Silicon Image SiI8620 HDMI/MHL bridge bindings > - > -Required properties: > - - compatible: "sil,sii8620" > - - reg: i2c address of the bridge > - - cvcc10-supply: Digital Core Supply Voltage (1.0V) > - - iovcc18-supply: I/O Supply Voltage (1.8V) > - - interrupts: interrupt specifier of INT pin > - - reset-gpios: gpio specifier of RESET pin > - - clocks, clock-names: specification and name of "xtal" clock > - - video interfaces: Device node can contain video interface port > - node for HDMI encoder according to [1]. > - > -[1]: Documentation/devicetree/bindings/media/video-interfaces.txt > - > -Example: > - sii8620@39 { > - reg = <0x39>; > - compatible = "sil,sii8620"; > - cvcc10-supply = <&ldo36_reg>; > - iovcc18-supply = <&ldo34_reg>; > - interrupt-parent = <&gpf0>; > - interrupts = <2 0>; > - reset-gpio = <&gpv7 0 0>; > - clocks = <&pmu_system_controller 0>; > - clock-names = "xtal"; > - > - port { > - mhl_to_hdmi: endpoint { > - remote-endpoint = <&hdmi_to_mhl>; > - }; > - }; > - };
On 28/01/2023 09:30, Laurent Pinchart wrote: > Hi Krzysztof, > > Thank you for the patch. > > On Fri, Jan 27, 2023 at 09:35:25PM +0100, Krzysztof Kozlowski wrote: >> Convert the Silicon Image SiI8620 HDMI/MHL bridge bindings to DT schema. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> --- >> .../bindings/display/bridge/sil,sii8620.yaml | 107 ++++++++++++++++++ >> .../bindings/display/bridge/sil-sii8620.txt | 33 ------ >> 2 files changed, 107 insertions(+), 33 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/display/bridge/sil,sii8620.yaml >> delete mode 100644 Documentation/devicetree/bindings/display/bridge/sil-sii8620.txt >> >> diff --git a/Documentation/devicetree/bindings/display/bridge/sil,sii8620.yaml b/Documentation/devicetree/bindings/display/bridge/sil,sii8620.yaml >> new file mode 100644 >> index 000000000000..90532bb99161 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/display/bridge/sil,sii8620.yaml >> @@ -0,0 +1,107 @@ >> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/display/bridge/sil,sii8620.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Silicon Image SiI8620 HDMI/MHL bridge >> + >> +maintainers: >> + - Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> + >> +properties: >> + compatible: >> + const: sil,sii8620 >> + >> + reg: >> + maxItems: 1 >> + >> + clocks: >> + maxItems: 1 >> + >> + clock-names: >> + items: >> + - const: xtal >> + >> + cvcc10-supply: >> + description: Digital Core Supply Voltage (1.0V) >> + >> + interrupts: >> + maxItems: 1 >> + >> + iovcc18-supply: >> + description: I/O Supply Voltage (1.8V) >> + >> + reset-gpios: >> + maxItems: 1 >> + >> + ports: >> + $ref: /schemas/graph.yaml#/properties/ports >> + unevaluatedProperties: false >> + >> + properties: >> + port@0: >> + $ref: /schemas/graph.yaml#/properties/port >> + description: >> + Video port for HDMI (encoder) input >> + >> + port@1: >> + $ref: /schemas/graph.yaml#/properties/port >> + description: >> + MHL to connector port >> + >> + required: >> + - port@0 > > Why port@0 only ? I am not the author of the original binding, but when it was introduced, I think it came without MHL port support - only HDMI. This probably is incomplete but I guess can work due to some default settings. Shall we make both required? I don't know, sounds reasonable... Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/display/bridge/sil,sii8620.yaml b/Documentation/devicetree/bindings/display/bridge/sil,sii8620.yaml new file mode 100644 index 000000000000..90532bb99161 --- /dev/null +++ b/Documentation/devicetree/bindings/display/bridge/sil,sii8620.yaml @@ -0,0 +1,107 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/bridge/sil,sii8620.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Silicon Image SiI8620 HDMI/MHL bridge + +maintainers: + - Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> + +properties: + compatible: + const: sil,sii8620 + + reg: + maxItems: 1 + + clocks: + maxItems: 1 + + clock-names: + items: + - const: xtal + + cvcc10-supply: + description: Digital Core Supply Voltage (1.0V) + + interrupts: + maxItems: 1 + + iovcc18-supply: + description: I/O Supply Voltage (1.8V) + + reset-gpios: + maxItems: 1 + + ports: + $ref: /schemas/graph.yaml#/properties/ports + unevaluatedProperties: false + + properties: + port@0: + $ref: /schemas/graph.yaml#/properties/port + description: + Video port for HDMI (encoder) input + + port@1: + $ref: /schemas/graph.yaml#/properties/port + description: + MHL to connector port + + required: + - port@0 + +required: + - compatible + - reg + - clocks + - cvcc10-supply + - interrupts + - iovcc18-supply + - reset-gpios + - ports + +additionalProperties: false + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + #include <dt-bindings/interrupt-controller/irq.h> + + i2c { + #address-cells = <1>; + #size-cells = <0>; + + bridge@39 { + reg = <0x39>; + compatible = "sil,sii8620"; + cvcc10-supply = <&ldo36_reg>; + iovcc18-supply = <&ldo34_reg>; + interrupt-parent = <&gpf0>; + interrupts = <2 IRQ_TYPE_LEVEL_HIGH>; + reset-gpios = <&gpv7 0 GPIO_ACTIVE_LOW>; + clocks = <&pmu_system_controller 0>; + clock-names = "xtal"; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + mhl_to_hdmi: endpoint { + remote-endpoint = <&hdmi_to_mhl>; + }; + }; + + port@1 { + reg = <1>; + mhl_to_musb_con: endpoint { + remote-endpoint = <&musb_con_to_mhl>; + }; + }; + }; + }; + }; diff --git a/Documentation/devicetree/bindings/display/bridge/sil-sii8620.txt b/Documentation/devicetree/bindings/display/bridge/sil-sii8620.txt deleted file mode 100644 index b05052f7d62f..000000000000 --- a/Documentation/devicetree/bindings/display/bridge/sil-sii8620.txt +++ /dev/null @@ -1,33 +0,0 @@ -Silicon Image SiI8620 HDMI/MHL bridge bindings - -Required properties: - - compatible: "sil,sii8620" - - reg: i2c address of the bridge - - cvcc10-supply: Digital Core Supply Voltage (1.0V) - - iovcc18-supply: I/O Supply Voltage (1.8V) - - interrupts: interrupt specifier of INT pin - - reset-gpios: gpio specifier of RESET pin - - clocks, clock-names: specification and name of "xtal" clock - - video interfaces: Device node can contain video interface port - node for HDMI encoder according to [1]. - -[1]: Documentation/devicetree/bindings/media/video-interfaces.txt - -Example: - sii8620@39 { - reg = <0x39>; - compatible = "sil,sii8620"; - cvcc10-supply = <&ldo36_reg>; - iovcc18-supply = <&ldo34_reg>; - interrupt-parent = <&gpf0>; - interrupts = <2 0>; - reset-gpio = <&gpv7 0 0>; - clocks = <&pmu_system_controller 0>; - clock-names = "xtal"; - - port { - mhl_to_hdmi: endpoint { - remote-endpoint = <&hdmi_to_mhl>; - }; - }; - };
Convert the Silicon Image SiI8620 HDMI/MHL bridge bindings to DT schema. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- .../bindings/display/bridge/sil,sii8620.yaml | 107 ++++++++++++++++++ .../bindings/display/bridge/sil-sii8620.txt | 33 ------ 2 files changed, 107 insertions(+), 33 deletions(-) create mode 100644 Documentation/devicetree/bindings/display/bridge/sil,sii8620.yaml delete mode 100644 Documentation/devicetree/bindings/display/bridge/sil-sii8620.txt