| Message ID | 20230124054427.28808-2-rashmi.a@intel.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | None | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 2 warnings, 15 lines checked |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 24/01/2023 06:44, rashmi.a@intel.com wrote: > From: "A, Rashmi" <rashmi.a@intel.com> > > This reverts commit ab991c05c42853f0b6110022db9bf30fcc6323dd. Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. > > Revert Thunder Bay specific code as the product got cancelled > and there are no end customers. > > Signed-off-by: A, Rashmi <rashmi.a@intel.com> > Reviewed-by: Hunter, Adrian <adrian.hunter@intel.com>wq Stray characters. > --- > .../devicetree/bindings/mmc/arasan,sdhci.yaml | 25 ------------------- > 1 file changed, 25 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml b/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml > index 4053de758db6..0d5d21dd30bb 100644 > --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml > +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml > @@ -88,12 +88,6 @@ properties: > description: > For this device it is strongly suggested to include > arasan,soc-ctl-syscon. > - - items: > - - const: intel,thunderbay-sdhci-5.1 # Intel Thunder Bay eMMC PHY > - - const: arasan,sdhci-5.1 Instead should be made rather deprecated, unless you are sure there is no single person in the world using the bindings (e.g. with BSD or bootloader)? Best regards, Krzysztof
> -----Original Message----- > From: Krzysztof Kozlowski <krzk@kernel.org> > Sent: Tuesday, January 24, 2023 5:01 PM > To: A, Rashmi <rashmi.a@intel.com>; ulf.hansson@linaro.org; > michal.simek@xilinx.com; linux-mmc@vger.kernel.org; linux-arm- > kernel@lists.infradead.org; robh+dt@kernel.org; devicetree@vger.kernel.org; > linux-kernel@vger.kernel.org; kishon@ti.com; vkoul@kernel.org; > andriy.shevchenko@linux.intel.com; linux-phy@lists.infradead.org; > mgross@linux.intel.com > Cc: kris.pan@linux.intel.com; Hunter, Adrian <adrian.hunter@intel.com>; > Vaidya, Mahesh R <mahesh.r.vaidya@intel.com>; Srikandan, Nandhini > <nandhini.srikandan@intel.com>; Itha, Vasavi V <vasavi.v.itha@intel.com>; > Demakkanavar, Kenchappa <kenchappa.demakkanavar@intel.com>; Zhou, > Furong <furong.zhou@intel.com>; Sangannavar, Mallikarjunappa > <mallikarjunappa.sangannavar@intel.com> > Subject: Re: [PATCH v1 2/4] Revert "dt-bindings: mmc: Add bindings for Intel > Thunder Bay SoC" > > On 24/01/2023 06:44, rashmi.a@intel.com wrote: > > From: "A, Rashmi" <rashmi.a@intel.com> > > > > This reverts commit ab991c05c42853f0b6110022db9bf30fcc6323dd. > > Please use scripts/get_maintainers.pl to get a list of necessary people and lists > to CC. It might happen, that command when run on an older kernel, gives you > outdated entries. Therefore please be sure you base your patches on recent > Linux kernel. Acknowledged > > > > > Revert Thunder Bay specific code as the product got cancelled and > > there are no end customers. > > > > Signed-off-by: A, Rashmi <rashmi.a@intel.com> > > Reviewed-by: Hunter, Adrian <adrian.hunter@intel.com>wq > > Stray characters. Acknowledged > > > --- > > .../devicetree/bindings/mmc/arasan,sdhci.yaml | 25 > > ------------------- > > 1 file changed, 25 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml > > b/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml > > index 4053de758db6..0d5d21dd30bb 100644 > > --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml > > +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml > > @@ -88,12 +88,6 @@ properties: > > description: > > For this device it is strongly suggested to include > > arasan,soc-ctl-syscon. > > - - items: > > - - const: intel,thunderbay-sdhci-5.1 # Intel Thunder Bay eMMC PHY > > - - const: arasan,sdhci-5.1 > > Instead should be made rather deprecated, unless you are sure there is no single > person in the world using the bindings (e.g. with BSD or bootloader)? May I know what has to be done in order to deprecate the complete patchset? We have a proposal to club together the 2 driver patches and 2 dt binding patches and send out new patchset containing only 2 revert patches. Patch 1 - revert dt-bindings patch Revert "dt-bindings: mmc: Add bindings for Intel Thunder Bay SoC" & Revert "dt-bindings: phy: intel: Add Thunder Bay eMMC PHY bindings" Patch 2 - revert driver patch "Revert mmc: sdhci-of-arasan: Add intel Thunder Bay SOC support to the arasan eMMC driver" & "Revert phy: intel: Add Thunder Bay eMMC PHY support" > > > > Best regards, > Krzysztof -Regards Rashmi
On 09/03/2023 07:43, A, Rashmi wrote: >> >>> --- >>> .../devicetree/bindings/mmc/arasan,sdhci.yaml | 25 >>> ------------------- >>> 1 file changed, 25 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml >>> b/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml >>> index 4053de758db6..0d5d21dd30bb 100644 >>> --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml >>> +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml >>> @@ -88,12 +88,6 @@ properties: >>> description: >>> For this device it is strongly suggested to include >>> arasan,soc-ctl-syscon. >>> - - items: >>> - - const: intel,thunderbay-sdhci-5.1 # Intel Thunder Bay eMMC PHY >>> - - const: arasan,sdhci-5.1 >> >> Instead should be made rather deprecated, unless you are sure there is no single >> person in the world using the bindings (e.g. with BSD or bootloader)? > May I know what has to be done in order to deprecate the complete patchset? deprecated: true (git grep for examples) Best regards, Krzysztof
On 24/01/23 13:31, Krzysztof Kozlowski wrote: > On 24/01/2023 06:44, rashmi.a@intel.com wrote: >> From: "A, Rashmi" <rashmi.a@intel.com> >> >> This reverts commit ab991c05c42853f0b6110022db9bf30fcc6323dd. > > Please use scripts/get_maintainers.pl to get a list of necessary people > and lists to CC. It might happen, that command when run on an older > kernel, gives you outdated entries. Therefore please be sure you base > your patches on recent Linux kernel. > >> >> Revert Thunder Bay specific code as the product got cancelled >> and there are no end customers. >> >> Signed-off-by: A, Rashmi <rashmi.a@intel.com> >> Reviewed-by: Hunter, Adrian <adrian.hunter@intel.com>wq > > Stray characters. > >> --- >> .../devicetree/bindings/mmc/arasan,sdhci.yaml | 25 ------------------- >> 1 file changed, 25 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml b/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml >> index 4053de758db6..0d5d21dd30bb 100644 >> --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml >> +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml >> @@ -88,12 +88,6 @@ properties: >> description: >> For this device it is strongly suggested to include >> arasan,soc-ctl-syscon. >> - - items: >> - - const: intel,thunderbay-sdhci-5.1 # Intel Thunder Bay eMMC PHY >> - - const: arasan,sdhci-5.1 > > Instead should be made rather deprecated, unless you are sure there is > no single person in the world using the bindings (e.g. with BSD or > bootloader)? I am sorry but this is not clear to me. As I understand it, the hardware was never released, so the binding serves no purpose. Should it be removed or "deprecated"?
On 09/03/2023 15:12, Adrian Hunter wrote: > On 24/01/23 13:31, Krzysztof Kozlowski wrote: >> On 24/01/2023 06:44, rashmi.a@intel.com wrote: >>> From: "A, Rashmi" <rashmi.a@intel.com> >>> >>> This reverts commit ab991c05c42853f0b6110022db9bf30fcc6323dd. >> >> Please use scripts/get_maintainers.pl to get a list of necessary people >> and lists to CC. It might happen, that command when run on an older >> kernel, gives you outdated entries. Therefore please be sure you base >> your patches on recent Linux kernel. >> >>> >>> Revert Thunder Bay specific code as the product got cancelled >>> and there are no end customers. >>> >>> Signed-off-by: A, Rashmi <rashmi.a@intel.com> >>> Reviewed-by: Hunter, Adrian <adrian.hunter@intel.com>wq >> >> Stray characters. >> >>> --- >>> .../devicetree/bindings/mmc/arasan,sdhci.yaml | 25 ------------------- >>> 1 file changed, 25 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml b/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml >>> index 4053de758db6..0d5d21dd30bb 100644 >>> --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml >>> +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml >>> @@ -88,12 +88,6 @@ properties: >>> description: >>> For this device it is strongly suggested to include >>> arasan,soc-ctl-syscon. >>> - - items: >>> - - const: intel,thunderbay-sdhci-5.1 # Intel Thunder Bay eMMC PHY >>> - - const: arasan,sdhci-5.1 >> >> Instead should be made rather deprecated, unless you are sure there is >> no single person in the world using the bindings (e.g. with BSD or >> bootloader)? > > I am sorry but this is not clear to me. As I understand it, > the hardware was never released, so the binding serves no > purpose. Should it be removed or "deprecated"? Hm, commit msg said cancelled and I understood that it was released and then got cancelled. But indeed maybe just remove it. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml b/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml index 4053de758db6..0d5d21dd30bb 100644 --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml @@ -88,12 +88,6 @@ properties: description: For this device it is strongly suggested to include arasan,soc-ctl-syscon. - - items: - - const: intel,thunderbay-sdhci-5.1 # Intel Thunder Bay eMMC PHY - - const: arasan,sdhci-5.1 - description: - For this device it is strongly suggested to include - clock-output-names and '#clock-cells'. reg: maxItems: 1 @@ -309,22 +303,3 @@ examples: <&scmi_clk KEEM_BAY_PSS_SD0>; arasan,soc-ctl-syscon = <&sd0_phy_syscon>; }; - - - | - #define EMMC_XIN_CLK - #define EMMC_AXI_CLK - #define TBH_PSS_EMMC_RST_N - mmc@80420000 { - compatible = "intel,thunderbay-sdhci-5.1", "arasan,sdhci-5.1"; - interrupts = <GIC_SPI 714 IRQ_TYPE_LEVEL_HIGH>; - reg = <0x80420000 0x400>; - clocks = <&scmi_clk EMMC_XIN_CLK>, - <&scmi_clk EMMC_AXI_CLK>; - clock-names = "clk_xin", "clk_ahb"; - phys = <&emmc_phy>; - phy-names = "phy_arasan"; - assigned-clocks = <&scmi_clk EMMC_XIN_CLK>; - clock-output-names = "emmc_cardclock"; - resets = <&rst_pss1 TBH_PSS_EMMC_RST_N>; - #clock-cells = <0x0>; - };