| Message ID | 20221220160240.27494-6-sumitg@nvidia.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Tegra234 Memory interconnect support | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | fail | build log |
On 20/12/2022 17:02, Sumit Gupta wrote: > Adding ICC id's for dummy software clients representing CCPLEX clusters. > > Signed-off-by: Sumit Gupta <sumitg@nvidia.com> > --- > include/dt-bindings/memory/tegra234-mc.h | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/include/dt-bindings/memory/tegra234-mc.h b/include/dt-bindings/memory/tegra234-mc.h > index 347e55e89a2a..6e60d55491b3 100644 > --- a/include/dt-bindings/memory/tegra234-mc.h > +++ b/include/dt-bindings/memory/tegra234-mc.h > @@ -536,4 +536,9 @@ > #define TEGRA234_MEMORY_CLIENT_NVJPG1SRD 0x123 > #define TEGRA234_MEMORY_CLIENT_NVJPG1SWR 0x124 > > +/* ICC ID's for dummy MC clients used to represent CPU Clusters */ > +#define TEGRA_ICC_MC_CPU_CLUSTER0 1003 Why the IDs do not start from 0? Best regards, Krzysztof
On 22/12/22 16:59, Krzysztof Kozlowski wrote: > External email: Use caution opening links or attachments > > > On 20/12/2022 17:02, Sumit Gupta wrote: >> Adding ICC id's for dummy software clients representing CCPLEX clusters. >> >> Signed-off-by: Sumit Gupta <sumitg@nvidia.com> >> --- >> include/dt-bindings/memory/tegra234-mc.h | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/include/dt-bindings/memory/tegra234-mc.h b/include/dt-bindings/memory/tegra234-mc.h >> index 347e55e89a2a..6e60d55491b3 100644 >> --- a/include/dt-bindings/memory/tegra234-mc.h >> +++ b/include/dt-bindings/memory/tegra234-mc.h >> @@ -536,4 +536,9 @@ >> #define TEGRA234_MEMORY_CLIENT_NVJPG1SRD 0x123 >> #define TEGRA234_MEMORY_CLIENT_NVJPG1SWR 0x124 >> >> +/* ICC ID's for dummy MC clients used to represent CPU Clusters */ >> +#define TEGRA_ICC_MC_CPU_CLUSTER0 1003 > > Why the IDs do not start from 0? > > Best regards, > Krzysztof > MC client ID's are starting from zero. These ID's are used as "icc_node->id" while creating the icc_node. So, can't use the duplicate numbers. $ grep TEGRA234_MEMORY_ "include/dt-bindings/memory/tegra234- mc.h" #define TEGRA234_MEMORY_CLIENT_PTCR 0x00 #define TEGRA234_MEMORY_CLIENT_MIU7R 0x01 #define TEGRA234_MEMORY_CLIENT_MIU7W 0x02 #define TEGRA234_MEMORY_CLIENT_MIU8R 0x03 .... Dummy ID's which are already being used are starting from '1000'. So, added to that number as the ID's used for creating "icc_node" for CPU clusters are also dummy and they are not part of HW MC client's list. $ grep "100[0-9]" ./drivers/memory/tegra/mc.h #define TEGRA_ICC_MC 1000 #define TEGRA_ICC_EMC 1001 #define TEGRA_ICC_EMEM 1002
On 20/12/2022 17:02, Sumit Gupta wrote: > Adding ICC id's for dummy software clients representing CCPLEX clusters. > > Signed-off-by: Sumit Gupta <sumitg@nvidia.com> > --- Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/include/dt-bindings/memory/tegra234-mc.h b/include/dt-bindings/memory/tegra234-mc.h index 347e55e89a2a..6e60d55491b3 100644 --- a/include/dt-bindings/memory/tegra234-mc.h +++ b/include/dt-bindings/memory/tegra234-mc.h @@ -536,4 +536,9 @@ #define TEGRA234_MEMORY_CLIENT_NVJPG1SRD 0x123 #define TEGRA234_MEMORY_CLIENT_NVJPG1SWR 0x124 +/* ICC ID's for dummy MC clients used to represent CPU Clusters */ +#define TEGRA_ICC_MC_CPU_CLUSTER0 1003 +#define TEGRA_ICC_MC_CPU_CLUSTER1 1004 +#define TEGRA_ICC_MC_CPU_CLUSTER2 1005 + #endif
Adding ICC id's for dummy software clients representing CCPLEX clusters. Signed-off-by: Sumit Gupta <sumitg@nvidia.com> --- include/dt-bindings/memory/tegra234-mc.h | 5 +++++ 1 file changed, 5 insertions(+)