| Message ID | 20221213115628.105149-1-konrad.dybcio@linaro.org |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | [1/4] dt-bindings: i2c: qcom,i2c-cci: Fall back to common compatibles | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dt-meta-schema | fail | build log |
On Tue, 13 Dec 2022 12:56:25 +0100, Konrad Dybcio wrote: > Almost every compatible string in the CCI driver is a duplicate. Adjust > the bindings to include a common (first-soc-implementing-vX) compatible > to remove the need to keep adding superfluous compatible strings. > > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> > --- > .../devicetree/bindings/i2c/qcom,i2c-cci.yaml | 25 +++++++++++++------ > 1 file changed, 17 insertions(+), 8 deletions(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.example.dtb: cci@ac4a000: compatible: 'oneOf' conditional failed, one must be fixed: ['qcom,sdm845-cci'] is too short 'qcom,sdm845-cci' is not one of ['qcom,msm8226-cci', 'qcom,msm8974-cci', 'qcom,msm8996-cci'] 'qcom,sdm845-cci' is not one of ['qcom,msm8916-cci'] From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20221213115628.105149-1-konrad.dybcio@linaro.org The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On 13/12/2022 12:56, Konrad Dybcio wrote: > Almost every compatible string in the CCI driver is a duplicate. Adjust > the bindings to include a common (first-soc-implementing-vX) compatible > to remove the need to keep adding superfluous compatible strings. > > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> > --- > .../devicetree/bindings/i2c/qcom,i2c-cci.yaml | 25 +++++++++++++------ > 1 file changed, 17 insertions(+), 8 deletions(-) > > diff --git a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml > index cf9f8fda595f..65cf7860a9a0 100644 > --- a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml > +++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml > @@ -12,14 +12,23 @@ maintainers: > > properties: > compatible: > - enum: > - - qcom,msm8226-cci > - - qcom,msm8916-cci > - - qcom,msm8974-cci > - - qcom,msm8996-cci > - - qcom,sdm845-cci > - - qcom,sm8250-cci > - - qcom,sm8450-cci > + oneOf: Except missing test, how about also adding a comment to the driver, that list of compatibles should not grow when not needed? Best regards, Krzysztof
On 13.12.2022 17:58, Krzysztof Kozlowski wrote: > On 13/12/2022 12:56, Konrad Dybcio wrote: >> Almost every compatible string in the CCI driver is a duplicate. Adjust >> the bindings to include a common (first-soc-implementing-vX) compatible >> to remove the need to keep adding superfluous compatible strings. >> >> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> >> --- >> .../devicetree/bindings/i2c/qcom,i2c-cci.yaml | 25 +++++++++++++------ >> 1 file changed, 17 insertions(+), 8 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml >> index cf9f8fda595f..65cf7860a9a0 100644 >> --- a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml >> +++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml >> @@ -12,14 +12,23 @@ maintainers: >> >> properties: >> compatible: >> - enum: >> - - qcom,msm8226-cci >> - - qcom,msm8916-cci >> - - qcom,msm8974-cci >> - - qcom,msm8996-cci >> - - qcom,sdm845-cci >> - - qcom,sm8250-cci >> - - qcom,sm8450-cci >> + oneOf: > > Except missing test, Hm? I tested this locally with dt_binding_check and it passed.. how about also adding a comment to the driver, that > list of compatibles should not grow when not needed? Sure. Konrad > > Best regards, > Krzysztof >
On 13.12.2022 18:01, Konrad Dybcio wrote: > > > On 13.12.2022 17:58, Krzysztof Kozlowski wrote: >> On 13/12/2022 12:56, Konrad Dybcio wrote: >>> Almost every compatible string in the CCI driver is a duplicate. Adjust >>> the bindings to include a common (first-soc-implementing-vX) compatible >>> to remove the need to keep adding superfluous compatible strings. >>> >>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> >>> --- >>> .../devicetree/bindings/i2c/qcom,i2c-cci.yaml | 25 +++++++++++++------ >>> 1 file changed, 17 insertions(+), 8 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml >>> index cf9f8fda595f..65cf7860a9a0 100644 >>> --- a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml >>> +++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml >>> @@ -12,14 +12,23 @@ maintainers: >>> >>> properties: >>> compatible: >>> - enum: >>> - - qcom,msm8226-cci >>> - - qcom,msm8916-cci >>> - - qcom,msm8974-cci >>> - - qcom,msm8996-cci >>> - - qcom,sdm845-cci >>> - - qcom,sm8250-cci >>> - - qcom,sm8450-cci >>> + oneOf: >> >> Except missing test, > Hm? I tested this locally with dt_binding_check and it passed.. Eh, looks like I didn't hit save before running it or something, I see it now, sorry bout that.. Konrad > > how about also adding a comment to the driver, that >> list of compatibles should not grow when not needed? > Sure. > > Konrad >> >> Best regards, >> Krzysztof >>
diff --git a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml index cf9f8fda595f..65cf7860a9a0 100644 --- a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml +++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml @@ -12,14 +12,23 @@ maintainers: properties: compatible: - enum: - - qcom,msm8226-cci - - qcom,msm8916-cci - - qcom,msm8974-cci - - qcom,msm8996-cci - - qcom,sdm845-cci - - qcom,sm8250-cci - - qcom,sm8450-cci + oneOf: + - enum: + - qcom,msm8226-cci + - qcom,msm8974-cci + - qcom,msm8996-cci + + - items: + - enum: + - qcom,msm8916-cci + - const: qcom,msm8226-cci # CCI v1 + + - items: + - enum: + - qcom,sdm845-cci + - qcom,sm8250-cci + - qcom,sm8450-cci + - const: qcom,msm8996-cci # CCI v2 "#address-cells": const: 1
Almost every compatible string in the CCI driver is a duplicate. Adjust the bindings to include a common (first-soc-implementing-vX) compatible to remove the need to keep adding superfluous compatible strings. Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> --- .../devicetree/bindings/i2c/qcom,i2c-cci.yaml | 25 +++++++++++++------ 1 file changed, 17 insertions(+), 8 deletions(-)