| Message ID | 20221207055405.30940-17-hayashi.kunihiko@socionext.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | dt-bindings: soc: Introduce UniPhier miscellaneous register blocks and fix examples | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dt-meta-schema | fail | build log |
On Wed, 07 Dec 2022 14:54:05 +0900, Kunihiko Hayashi wrote: > Add DT binding schema for components belonging to the platform-specific > AHCI glue layer implemented in UniPhier SoCs. > > This AHCI glue layer works as a sideband logic for the host controller, > including core reset, PHYs, and some signals to the controller. > > Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> > --- > .../socionext,uniphier-ahci-glue.yaml | 78 +++++++++++++++++++ > 1 file changed, 78 insertions(+) > create mode 100644 Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-ahci-glue.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.example.dtb: ahci-glue@65700000: 'reg' is a required property From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-ahci-glue.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20221207055405.30940-17-hayashi.kunihiko@socionext.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On 07/12/2022 06:54, Kunihiko Hayashi wrote: > Add DT binding schema for components belonging to the platform-specific > AHCI glue layer implemented in UniPhier SoCs. > > This AHCI glue layer works as a sideband logic for the host controller, > including core reset, PHYs, and some signals to the controller. > > Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> > --- > .../socionext,uniphier-ahci-glue.yaml | 78 +++++++++++++++++++ > 1 file changed, 78 insertions(+) > create mode 100644 Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-ahci-glue.yaml > > diff --git a/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-ahci-glue.yaml b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-ahci-glue.yaml > new file mode 100644 > index 000000000000..bf37be8a778d > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-ahci-glue.yaml > @@ -0,0 +1,78 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/soc/socionext/socionext,uniphier-ahci-glue.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Socionext UniPhier SoC AHCI glue layer > + > +maintainers: > + - Kunihiko Hayashi <hayashi.kunihiko@socionext.com> > + > +description: |+ > + AHCI glue layer implemented on Socionext UniPhier SoCs is a sideband > + logic handling signals to AHCI host controller inside AHCI component. > + > +properties: > + compatible: > + items: > + - enum: > + - socionext,uniphier-pro4-ahci-glue > + - socionext,uniphier-pxs2-ahci-glue > + - socionext,uniphier-pxs3-ahci-glue > + - const: simple-mfd > + > + reg: > + maxItems: 1 > + > + '#address-cells': use consistent quotes > + const: 1 > + > + '#size-cells': > + const: 1 > + > + ranges: true > + > +patternProperties: > + "^reset-controller@[0-9a-f]+$": > + $ref: /schemas/reset/socionext,uniphier-glue-reset.yaml# > + > + "phy@[0-9a-f]+$": > + $ref: /schemas/phy/socionext,uniphier-ahci-phy.yaml# > + > +required: > + - compatible > + - reg > + > +additionalProperties: > + type: object What is the additional object? It's not in your example, not in DTS. Why do you need to allow it? Best regards, Krzysztof
On 2022/12/08 17:24, Krzysztof Kozlowski wrote: > On 07/12/2022 06:54, Kunihiko Hayashi wrote: >> Add DT binding schema for components belonging to the platform-specific >> AHCI glue layer implemented in UniPhier SoCs. >> >> This AHCI glue layer works as a sideband logic for the host controller, >> including core reset, PHYs, and some signals to the controller. >> >> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> >> --- >> .../socionext,uniphier-ahci-glue.yaml | 78 +++++++++++++++++++ >> 1 file changed, 78 insertions(+) >> create mode 100644 >> Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-ahci-glue.yaml >> >> diff --git >> a/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-ahci-glue.yaml >> b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-ahci-glue.yaml >> new file mode 100644 >> index 000000000000..bf37be8a778d >> --- /dev/null >> +++ >> b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-ahci-glue.yaml >> @@ -0,0 +1,78 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: >> http://devicetree.org/schemas/soc/socionext/socionext,uniphier-ahci-glue.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Socionext UniPhier SoC AHCI glue layer >> + >> +maintainers: >> + - Kunihiko Hayashi <hayashi.kunihiko@socionext.com> >> + >> +description: |+ >> + AHCI glue layer implemented on Socionext UniPhier SoCs is a sideband >> + logic handling signals to AHCI host controller inside AHCI component. >> + >> +properties: >> + compatible: >> + items: >> + - enum: >> + - socionext,uniphier-pro4-ahci-glue >> + - socionext,uniphier-pxs2-ahci-glue >> + - socionext,uniphier-pxs3-ahci-glue >> + - const: simple-mfd >> + >> + reg: >> + maxItems: 1 >> + >> + '#address-cells': > > use consistent quotes I'll change it. >> + const: 1 >> + >> + '#size-cells': >> + const: 1 >> + >> + ranges: true >> + >> +patternProperties: >> + "^reset-controller@[0-9a-f]+$": >> + $ref: /schemas/reset/socionext,uniphier-glue-reset.yaml# >> + >> + "phy@[0-9a-f]+$": >> + $ref: /schemas/phy/socionext,uniphier-ahci-phy.yaml# >> + >> +required: >> + - compatible >> + - reg >> + >> +additionalProperties: >> + type: object > > What is the additional object? It's not in your example, not in DTS. Why > do you need to allow it? Sorry, I forgot to drop it. I'll replace it with: additionalProperties: false Thank you, --- Best Regards Kunihiko Hayashi
diff --git a/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-ahci-glue.yaml b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-ahci-glue.yaml new file mode 100644 index 000000000000..bf37be8a778d --- /dev/null +++ b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-ahci-glue.yaml @@ -0,0 +1,78 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/soc/socionext/socionext,uniphier-ahci-glue.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Socionext UniPhier SoC AHCI glue layer + +maintainers: + - Kunihiko Hayashi <hayashi.kunihiko@socionext.com> + +description: |+ + AHCI glue layer implemented on Socionext UniPhier SoCs is a sideband + logic handling signals to AHCI host controller inside AHCI component. + +properties: + compatible: + items: + - enum: + - socionext,uniphier-pro4-ahci-glue + - socionext,uniphier-pxs2-ahci-glue + - socionext,uniphier-pxs3-ahci-glue + - const: simple-mfd + + reg: + maxItems: 1 + + '#address-cells': + const: 1 + + '#size-cells': + const: 1 + + ranges: true + +patternProperties: + "^reset-controller@[0-9a-f]+$": + $ref: /schemas/reset/socionext,uniphier-glue-reset.yaml# + + "phy@[0-9a-f]+$": + $ref: /schemas/phy/socionext,uniphier-ahci-phy.yaml# + +required: + - compatible + - reg + +additionalProperties: + type: object + +examples: + - | + sata-controller@65700000 { + compatible = "socionext,uniphier-pxs3-ahci-glue", "simple-mfd"; + reg = <0x65b00000 0x400>; + #address-cells = <1>; + #size-cells = <1>; + ranges = <0 0x65700000 0x100>; + + reset-controller@0 { + compatible = "socionext,uniphier-pxs3-ahci-reset"; + reg = <0x0 0x4>; + clock-names = "link"; + clocks = <&sys_clk 28>; + reset-names = "link"; + resets = <&sys_rst 28>; + #reset-cells = <1>; + }; + + phy@10 { + compatible = "socionext,uniphier-pxs3-ahci-phy"; + reg = <0x10 0x10>; + clock-names = "link", "phy"; + clocks = <&sys_clk 28>, <&sys_clk 30>; + reset-names = "link", "phy"; + resets = <&sys_rst 28>, <&sys_rst 30>; + #phy-cells = <0>; + }; + };
Add DT binding schema for components belonging to the platform-specific AHCI glue layer implemented in UniPhier SoCs. This AHCI glue layer works as a sideband logic for the host controller, including core reset, PHYs, and some signals to the controller. Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> --- .../socionext,uniphier-ahci-glue.yaml | 78 +++++++++++++++++++ 1 file changed, 78 insertions(+) create mode 100644 Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-ahci-glue.yaml