| Message ID | 20221128054920.2113-2-clin@suse.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Add GMAC support for S32 SoC family | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
Hi Chester, Am 28.11.22 um 06:49 schrieb Chester Lin: > Add a new compatible string for NXP S32CC DWMAC glue driver. The maxItems > of clock and clock-names need be increased because S32CC has up to 11 > clocks for its DWMAC. > > Signed-off-by: Chester Lin <clin@suse.com> > --- > > No change in v2. > > Documentation/devicetree/bindings/net/snps,dwmac.yaml | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > index 13b984076af5..c174d173591e 100644 > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > @@ -65,6 +65,7 @@ properties: > - ingenic,x2000-mac > - loongson,ls2k-dwmac > - loongson,ls7a-dwmac > + - nxp,s32cc-dwmac As we had discussed offline, please change this to nxp,s32g2-dwmac. S32G3 and S32R45 can then reuse it if they don't require changes; there is no difference here to how i.MX family or other vendors inherit IP across SoC models, so Rob's rules apply equally. Also affects the following patches. Thanks, Andreas > - renesas,r9a06g032-gmac > - renesas,rzn1-gmac > - rockchip,px30-gmac [snip]
diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml index 13b984076af5..c174d173591e 100644 --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml @@ -65,6 +65,7 @@ properties: - ingenic,x2000-mac - loongson,ls2k-dwmac - loongson,ls7a-dwmac + - nxp,s32cc-dwmac - renesas,r9a06g032-gmac - renesas,rzn1-gmac - rockchip,px30-gmac @@ -110,7 +111,7 @@ properties: clocks: minItems: 1 - maxItems: 8 + maxItems: 11 additionalItems: true items: - description: GMAC main clock @@ -122,7 +123,7 @@ properties: clock-names: minItems: 1 - maxItems: 8 + maxItems: 11 additionalItems: true contains: enum:
Add a new compatible string for NXP S32CC DWMAC glue driver. The maxItems of clock and clock-names need be increased because S32CC has up to 11 clocks for its DWMAC. Signed-off-by: Chester Lin <clin@suse.com> --- No change in v2. Documentation/devicetree/bindings/net/snps,dwmac.yaml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)