| Message ID | 20221117-b4-amlogic-bindings-convert-v1-7-3f025599b968@linaro.org |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | dt-bindings: first batch of dt-schema conversions for Amlogic Meson bindings | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 4 warnings, 0 lines checked |
| robh/patch-applied | success |
On 18/11/2022 15:33, Neil Armstrong wrote: > Remove the deprecated amlogic,meson-gx-pwrc.txt bindings, which was > replaced by the amlogic,meson-ee-pwrc.yaml bindings. > > The amlogic,meson-gx-pwrc-vpu compatible isn't used anymore since [1] > was merged in v5.8-rc1 and amlogic,meson-g12a-pwrc-vpu either since [2] > was merged in v5.3-rc1. > > [1] commit 5273d6cacc06 ("arm64: dts: meson-gx: Switch to the meson-ee-pwrc bindings") > [2] commit f4f1c8d9ace7 ("arm64: dts: meson-g12: add Everything-Else power domain controller") As of next-20221109 I see both compatibles used, so something here is not accurate. > > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> > --- > .../bindings/power/amlogic,meson-gx-pwrc.txt | 63 ---------------------- > 1 file changed, 63 deletions(-) > Best regards, Krzysztof
On 18/11/2022 15:52, Krzysztof Kozlowski wrote: > On 18/11/2022 15:33, Neil Armstrong wrote: >> Remove the deprecated amlogic,meson-gx-pwrc.txt bindings, which was >> replaced by the amlogic,meson-ee-pwrc.yaml bindings. >> >> The amlogic,meson-gx-pwrc-vpu compatible isn't used anymore since [1] >> was merged in v5.8-rc1 and amlogic,meson-g12a-pwrc-vpu either since [2] >> was merged in v5.3-rc1. >> >> [1] commit 5273d6cacc06 ("arm64: dts: meson-gx: Switch to the meson-ee-pwrc bindings") >> [2] commit f4f1c8d9ace7 ("arm64: dts: meson-g12: add Everything-Else power domain controller") > > As of next-20221109 I see both compatibles used, so something here is > not accurate. Yes driver still exists, was left for compatibility with older DTs during the migration. > >> >> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> >> --- >> .../bindings/power/amlogic,meson-gx-pwrc.txt | 63 ---------------------- >> 1 file changed, 63 deletions(-) >> > > > Best regards, > Krzysztof >
On 18/11/2022 15:55, Neil Armstrong wrote: > On 18/11/2022 15:52, Krzysztof Kozlowski wrote: >> On 18/11/2022 15:33, Neil Armstrong wrote: >>> Remove the deprecated amlogic,meson-gx-pwrc.txt bindings, which was >>> replaced by the amlogic,meson-ee-pwrc.yaml bindings. >>> >>> The amlogic,meson-gx-pwrc-vpu compatible isn't used anymore since [1] >>> was merged in v5.8-rc1 and amlogic,meson-g12a-pwrc-vpu either since [2] >>> was merged in v5.3-rc1. >>> >>> [1] commit 5273d6cacc06 ("arm64: dts: meson-gx: Switch to the meson-ee-pwrc bindings") >>> [2] commit f4f1c8d9ace7 ("arm64: dts: meson-g12: add Everything-Else power domain controller") >> >> As of next-20221109 I see both compatibles used, so something here is >> not accurate. > > Yes driver still exists, was left for compatibility with older DTs during the migration. Then the bindings should stay. You can add "deprecated" to its title. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/power/amlogic,meson-gx-pwrc.txt b/Documentation/devicetree/bindings/power/amlogic,meson-gx-pwrc.txt deleted file mode 100644 index 99b5b10cda31..000000000000 --- a/Documentation/devicetree/bindings/power/amlogic,meson-gx-pwrc.txt +++ /dev/null @@ -1,63 +0,0 @@ -Amlogic Meson Power Controller -============================== - -The Amlogic Meson SoCs embeds an internal Power domain controller. - -VPU Power Domain ----------------- - -The Video Processing Unit power domain is controlled by this power controller, -but the domain requires some external resources to meet the correct power -sequences. -The bindings must respect the power domain bindings as described in the file -power-domain.yaml - -Device Tree Bindings: ---------------------- - -Required properties: -- compatible: should be one of the following : - - "amlogic,meson-gx-pwrc-vpu" for the Meson GX SoCs - - "amlogic,meson-g12a-pwrc-vpu" for the Meson G12A SoCs -- #power-domain-cells: should be 0 -- amlogic,hhi-sysctrl: phandle to the HHI sysctrl node -- resets: phandles to the reset lines needed for this power demain sequence - as described in ../reset/reset.txt -- clocks: from common clock binding: handle to VPU and VAPB clocks -- clock-names: from common clock binding: must contain "vpu", "vapb" - corresponding to entry in the clocks property. - -Parent node should have the following properties : -- compatible: "amlogic,meson-gx-ao-sysctrl", "syscon", "simple-mfd" -- reg: base address and size of the AO system control register space. - -Example: -------- - -ao_sysctrl: sys-ctrl@0 { - compatible = "amlogic,meson-gx-ao-sysctrl", "syscon", "simple-mfd"; - reg = <0x0 0x0 0x0 0x100>; - - pwrc_vpu: power-controller-vpu { - compatible = "amlogic,meson-gx-pwrc-vpu"; - #power-domain-cells = <0>; - amlogic,hhi-sysctrl = <&sysctrl>; - resets = <&reset RESET_VIU>, - <&reset RESET_VENC>, - <&reset RESET_VCBUS>, - <&reset RESET_BT656>, - <&reset RESET_DVIN_RESET>, - <&reset RESET_RDMA>, - <&reset RESET_VENCI>, - <&reset RESET_VENCP>, - <&reset RESET_VDAC>, - <&reset RESET_VDI6>, - <&reset RESET_VENCL>, - <&reset RESET_VID_LOCK>; - clocks = <&clkc CLKID_VPU>, - <&clkc CLKID_VAPB>; - clock-names = "vpu", "vapb"; - }; -}; - -
Remove the deprecated amlogic,meson-gx-pwrc.txt bindings, which was replaced by the amlogic,meson-ee-pwrc.yaml bindings. The amlogic,meson-gx-pwrc-vpu compatible isn't used anymore since [1] was merged in v5.8-rc1 and amlogic,meson-g12a-pwrc-vpu either since [2] was merged in v5.3-rc1. [1] commit 5273d6cacc06 ("arm64: dts: meson-gx: Switch to the meson-ee-pwrc bindings") [2] commit f4f1c8d9ace7 ("arm64: dts: meson-g12: add Everything-Else power domain controller") Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> --- .../bindings/power/amlogic,meson-gx-pwrc.txt | 63 ---------------------- 1 file changed, 63 deletions(-)