| Message ID | 20221117-b4-amlogic-bindings-convert-v1-1-3f025599b968@linaro.org |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | dt-bindings: first batch of dt-schema conversions for Amlogic Meson bindings | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 36 lines checked |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 18/11/2022 15:33, Neil Armstrong wrote: > Convert the Amlogic Secure Monitor bindings to dt-schema. > > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> > --- > .../bindings/firmware/amlogic,meson-gxbb-sm.yaml | 36 ++++++++++++++++++++++ > .../bindings/firmware/meson/meson_sm.txt | 15 --------- > 2 files changed, 36 insertions(+), 15 deletions(-) > > diff --git a/Documentation/devicetree/bindings/firmware/amlogic,meson-gxbb-sm.yaml b/Documentation/devicetree/bindings/firmware/amlogic,meson-gxbb-sm.yaml > new file mode 100644 > index 000000000000..33d1408610cf > --- /dev/null > +++ b/Documentation/devicetree/bindings/firmware/amlogic,meson-gxbb-sm.yaml > @@ -0,0 +1,36 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/firmware/amlogic,meson-gxbb-sm.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Amlogic Secure Monitor (SM) > + > +description: > + In the Amlogic SoCs the Secure Monitor code is used to provide access to the > + NVMEM, enable JTAG, set USB boot, etc... > + > +maintainers: > + - Neil Armstrong <neil.armstrong@linaro.org> > + > +properties: > + compatible: > + const: amlogic,meson-gxbb-sm > + > +patternProperties: > + "power-controller": This looks like a property, not a pattern. > + type: object > + $ref: /schemas/power/amlogic,meson-sec-pwrc.yaml# Would be nice to add it here to example and drop from amlogic,meson-sec-pwrc.yaml (unless it will be used by more schemas?). Best regards, Krzysztof
On Fri, 18 Nov 2022 15:33:27 +0100, Neil Armstrong wrote: > Convert the Amlogic Secure Monitor bindings to dt-schema. > > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> > --- > .../bindings/firmware/amlogic,meson-gxbb-sm.yaml | 36 ++++++++++++++++++++++ > .../bindings/firmware/meson/meson_sm.txt | 15 --------- > 2 files changed, 36 insertions(+), 15 deletions(-) > Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings. Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future. Full log is available here: https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20221117-b4-amlogic-bindings-convert-v1-1-3f025599b968@linaro.org secure-monitor: compatible:0: 'amlogic,meson-gxbb-sm' was expected arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dtb arch/arm64/boot/dts/amlogic/meson-gxbb-nanopi-k2.dtb arch/arm64/boot/dts/amlogic/meson-gxbb-nexbox-a95x.dtb arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dtb arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dtb arch/arm64/boot/dts/amlogic/meson-gxbb-p201.dtb arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95-meta.dtb arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95-pro.dtb arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95-telos.dtb arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-hub.dtb arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-play2.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s805x-libretech-ac.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s805x-p241.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905d-libretech-pc.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905d-mecool-kii-pro.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905d-p230.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905d-p231.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905d-sml5442tw.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905d-vero4k-plus.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905w-jethome-jethub-j80.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905w-p281.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905w-tx3-mini.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905x-hwacom-amazetv.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc-v2.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905x-nexbox-a95x.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905x-p212.dtb arch/arm64/boot/dts/amlogic/meson-gxm-gt1-ultimate.dtb arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dtb arch/arm64/boot/dts/amlogic/meson-gxm-mecool-kiii-pro.dtb arch/arm64/boot/dts/amlogic/meson-gxm-minix-neo-u9h.dtb arch/arm64/boot/dts/amlogic/meson-gxm-nexbox-a1.dtb arch/arm64/boot/dts/amlogic/meson-gxm-q200.dtb arch/arm64/boot/dts/amlogic/meson-gxm-q201.dtb arch/arm64/boot/dts/amlogic/meson-gxm-rbox-pro.dtb arch/arm64/boot/dts/amlogic/meson-gxm-s912-libretech-pc.dtb arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dtb arch/arm64/boot/dts/amlogic/meson-gxm-wetek-core2.dtb secure-monitor: compatible: ['amlogic,meson-gx-sm', 'amlogic,meson-gxbb-sm'] is too long arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dtb arch/arm64/boot/dts/amlogic/meson-gxbb-nanopi-k2.dtb arch/arm64/boot/dts/amlogic/meson-gxbb-nexbox-a95x.dtb arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dtb arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dtb arch/arm64/boot/dts/amlogic/meson-gxbb-p201.dtb arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95-meta.dtb arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95-pro.dtb arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95-telos.dtb arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-hub.dtb arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-play2.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s805x-libretech-ac.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s805x-p241.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905d-libretech-pc.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905d-mecool-kii-pro.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905d-p230.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905d-p231.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905d-sml5442tw.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905d-vero4k-plus.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905w-jethome-jethub-j80.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905w-p281.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905w-tx3-mini.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905x-hwacom-amazetv.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc-v2.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905x-nexbox-a95x.dtb arch/arm64/boot/dts/amlogic/meson-gxl-s905x-p212.dtb arch/arm64/boot/dts/amlogic/meson-gxm-gt1-ultimate.dtb arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dtb arch/arm64/boot/dts/amlogic/meson-gxm-mecool-kiii-pro.dtb arch/arm64/boot/dts/amlogic/meson-gxm-minix-neo-u9h.dtb arch/arm64/boot/dts/amlogic/meson-gxm-nexbox-a1.dtb arch/arm64/boot/dts/amlogic/meson-gxm-q200.dtb arch/arm64/boot/dts/amlogic/meson-gxm-q201.dtb arch/arm64/boot/dts/amlogic/meson-gxm-rbox-pro.dtb arch/arm64/boot/dts/amlogic/meson-gxm-s912-libretech-pc.dtb arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dtb arch/arm64/boot/dts/amlogic/meson-gxm-wetek-core2.dtb
diff --git a/Documentation/devicetree/bindings/firmware/amlogic,meson-gxbb-sm.yaml b/Documentation/devicetree/bindings/firmware/amlogic,meson-gxbb-sm.yaml new file mode 100644 index 000000000000..33d1408610cf --- /dev/null +++ b/Documentation/devicetree/bindings/firmware/amlogic,meson-gxbb-sm.yaml @@ -0,0 +1,36 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/firmware/amlogic,meson-gxbb-sm.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Amlogic Secure Monitor (SM) + +description: + In the Amlogic SoCs the Secure Monitor code is used to provide access to the + NVMEM, enable JTAG, set USB boot, etc... + +maintainers: + - Neil Armstrong <neil.armstrong@linaro.org> + +properties: + compatible: + const: amlogic,meson-gxbb-sm + +patternProperties: + "power-controller": + type: object + $ref: /schemas/power/amlogic,meson-sec-pwrc.yaml# + +required: + - compatible + +additionalProperties: false + +examples: + - | + firmware { + secure-monitor { + compatible = "amlogic,meson-gxbb-sm"; + }; + }; diff --git a/Documentation/devicetree/bindings/firmware/meson/meson_sm.txt b/Documentation/devicetree/bindings/firmware/meson/meson_sm.txt deleted file mode 100644 index c248cd44f727..000000000000 --- a/Documentation/devicetree/bindings/firmware/meson/meson_sm.txt +++ /dev/null @@ -1,15 +0,0 @@ -* Amlogic Secure Monitor - -In the Amlogic SoCs the Secure Monitor code is used to provide access to the -NVMEM, enable JTAG, set USB boot, etc... - -Required properties for the secure monitor node: -- compatible: Should be "amlogic,meson-gxbb-sm" - -Example: - - firmware { - sm: secure-monitor { - compatible = "amlogic,meson-gxbb-sm"; - }; - };
Convert the Amlogic Secure Monitor bindings to dt-schema. Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> --- .../bindings/firmware/amlogic,meson-gxbb-sm.yaml | 36 ++++++++++++++++++++++ .../bindings/firmware/meson/meson_sm.txt | 15 --------- 2 files changed, 36 insertions(+), 15 deletions(-)