| Message ID | 20221021190908.1502026-3-nfraprado@collabora.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Add missing dt-binding properties to rt5682(s) | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com> On 21/10/2022 21:09, Nícolas F. R. A. Prado wrote: > The rt5682s codec can have two supplies: AVDD and MICVDD. Add properties > for them. > > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> > --- > > Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml > index ea53a55015c4..ca1037e76f96 100644 > --- a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml > +++ b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml > @@ -90,6 +90,10 @@ properties: > "#sound-dai-cells": > const: 0 > > + AVDD-supply: true > + > + MICVDD-supply: true > + > additionalProperties: false > > required:
On 21/10/2022 15:09, Nícolas F. R. A. Prado wrote: > The rt5682s codec can have two supplies: AVDD and MICVDD. Add properties > for them. > > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> > --- > > Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml > index ea53a55015c4..ca1037e76f96 100644 > --- a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml > +++ b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml > @@ -90,6 +90,10 @@ properties: > "#sound-dai-cells": > const: 0 > > + AVDD-supply: true > + > + MICVDD-supply: true > + How about keeping some order in the list of properties? Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 21/10/2022 15:09, Nícolas F. R. A. Prado wrote: > The rt5682s codec can have two supplies: AVDD and MICVDD. Add properties > for them. > > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> > --- > > Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml > index ea53a55015c4..ca1037e76f96 100644 > --- a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml > +++ b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml > @@ -90,6 +90,10 @@ properties: > "#sound-dai-cells": > const: 0 > > + AVDD-supply: true > + > + MICVDD-supply: true Ach, unacked. Please use lowercase names. Best regards, Krzysztof
On Sat, Oct 22, 2022 at 12:39:56PM -0400, Krzysztof Kozlowski wrote: > On 21/10/2022 15:09, Nícolas F. R. A. Prado wrote: > > The rt5682s codec can have two supplies: AVDD and MICVDD. Add properties > > for them. > > > > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> > > --- > > > > Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml > > index ea53a55015c4..ca1037e76f96 100644 > > --- a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml > > +++ b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml > > @@ -90,6 +90,10 @@ properties: > > "#sound-dai-cells": > > const: 0 > > > > + AVDD-supply: true > > + > > + MICVDD-supply: true > > + > > How about keeping some order in the list of properties? The current properties don't seem to follow any particular order and keeping the supplies grouped together seemed reasonable. What ordering do you suggest? Thanks, Nícolas
On 24/10/2022 11:06, Nícolas F. R. A. Prado wrote: > On Sat, Oct 22, 2022 at 12:39:56PM -0400, Krzysztof Kozlowski wrote: >> On 21/10/2022 15:09, Nícolas F. R. A. Prado wrote: >>> The rt5682s codec can have two supplies: AVDD and MICVDD. Add properties >>> for them. >>> >>> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> >>> --- >>> >>> Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml | 4 ++++ >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml >>> index ea53a55015c4..ca1037e76f96 100644 >>> --- a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml >>> +++ b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml >>> @@ -90,6 +90,10 @@ properties: >>> "#sound-dai-cells": >>> const: 0 >>> >>> + AVDD-supply: true >>> + >>> + MICVDD-supply: true >>> + >> >> How about keeping some order in the list of properties? > > The current properties don't seem to follow any particular order and keeping the > supplies grouped together seemed reasonable. What ordering do you suggest? That's true... :/ Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml index ea53a55015c4..ca1037e76f96 100644 --- a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml +++ b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml @@ -90,6 +90,10 @@ properties: "#sound-dai-cells": const: 0 + AVDD-supply: true + + MICVDD-supply: true + additionalProperties: false required:
The rt5682s codec can have two supplies: AVDD and MICVDD. Add properties for them. Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> --- Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml | 4 ++++ 1 file changed, 4 insertions(+)