| Message ID | 20221005142734.2724537-1-clca@bang-olufsen.dk |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | [1/2] ASoC: dt-bindings: add pin-switches to audio-graph-card2.yaml | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 05/10/2022 16:27, Claudio Cabral wrote: > Document support for pin-switches in audio-graph-card2 Full stop? > this devicetree property behaves the same way as its homonym in > simple-card Missing capital letter and full stop? Instead please describe why do you need pin-switches in this binding... > > Reviewed-by: Alvin Šipraga <alsi@bang-olufsen.dk> > Signed-off-by: Alvin Šipraga <alsi@bang-olufsen.dk> Authorship or contributions (SoB) usually means someone reviewed it and there is no need for both tags. The combination of both tags above is a bit surprising. > Signed-off-by: Claudio Cabral <clca@bang-olufsen.dk> > --- > Documentation/devicetree/bindings/sound/audio-graph-card2.yaml | 3 +++ > 1 file changed, 3 insertions(+) Best regards, Krzysztof
On Wed, Oct 05, 2022 at 06:06:13PM +0200, Krzysztof Kozlowski wrote: > On 05/10/2022 16:27, Claudio Cabral wrote: > > Reviewed-by: Alvin Šipraga <alsi@bang-olufsen.dk> > > Signed-off-by: Alvin Šipraga <alsi@bang-olufsen.dk> > > Authorship or contributions (SoB) usually means someone reviewed it and > there is no need for both tags. The combination of both tags above is a > bit surprising. Thanks for clarifying. In that case the S-o-b ought to be dropped, since it is Claudio's patch. I just reviewed it. Thanks!
diff --git a/Documentation/devicetree/bindings/sound/audio-graph-card2.yaml b/Documentation/devicetree/bindings/sound/audio-graph-card2.yaml index 7416067c945e..ab2cc83d6b4b 100644 --- a/Documentation/devicetree/bindings/sound/audio-graph-card2.yaml +++ b/Documentation/devicetree/bindings/sound/audio-graph-card2.yaml @@ -32,6 +32,9 @@ properties: codec2codec: type: object description: Codec to Codec node + pin-switches: + description: the widget names for which pin switches must be created. + $ref: /schemas/types.yaml#/definitions/string-array required: - compatible