Message ID | 20220928145818.376250-1-dmitry.baryshkov@linaro.org |
---|---|
State | Superseded, archived |
Headers | show |
Series | dt-bindings: clock: split qcom,gcc-sdm660 to the separate file | expand |
Context | Check | Description |
---|---|---|
robh/checkpatch | warning | total: 0 errors, 1 warnings, 76 lines checked |
robh/patch-applied | success | |
robh/dtbs-check | warning | build log |
robh/dt-meta-schema | success |
On 28/09/2022 16:58, Dmitry Baryshkov wrote: > Move schema for the GCC on SDM630/SDM636/SDM660 to a separate file to be > able to define device-specific clock properties. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > .../bindings/clock/qcom,gcc-other.yaml | 3 - > .../bindings/clock/qcom,gcc-sdm660.yaml | 61 +++++++++++++++++++ > 2 files changed, 61 insertions(+), 3 deletions(-) > create mode 100644 Documentation/devicetree/bindings/clock/qcom,gcc-sdm660.yaml > > diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-other.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-other.yaml > index 76988e04c7db..35fc22a19000 100644 > --- a/Documentation/devicetree/bindings/clock/qcom,gcc-other.yaml > +++ b/Documentation/devicetree/bindings/clock/qcom,gcc-other.yaml > @@ -24,7 +24,6 @@ description: | > - dt-bindings/clock/qcom,gcc-mdm9607.h > - dt-bindings/clock/qcom,gcc-mdm9615.h > - dt-bindings/reset/qcom,gcc-mdm9615.h > - - dt-bindings/clock/qcom,gcc-sdm660.h (qcom,gcc-sdm630 and qcom,gcc-sdm660) > > allOf: > - $ref: "qcom,gcc.yaml#" > @@ -41,8 +40,6 @@ properties: > - qcom,gcc-msm8974pro > - qcom,gcc-msm8974pro-ac > - qcom,gcc-mdm9615 > - - qcom,gcc-sdm630 > - - qcom,gcc-sdm660 > > required: > - compatible > diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-sdm660.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-sdm660.yaml > new file mode 100644 > index 000000000000..a39f28d37387 > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/qcom,gcc-sdm660.yaml > @@ -0,0 +1,61 @@ > +# SPDX-License-Identifier: GPL-2.0-only > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/clock/qcom,gcc-sdm660.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm Global Clock & Reset Controller Binding for SDM660/SDM630/SDM636 > + > +maintainers: > + - Stephen Boyd <sboyd@kernel.org> > + - Taniya Das <tdas@codeaurora.org> I guess email is not valid anymore. > + > +description: | > + Qualcomm global clock control module which supports the clocks, resets and > + power domains on SDM630, SDM636 and SDM660 > + > + See also: > + - dt-bindings/clock/qcom,gcc-sdm660.h (qcom,gcc-sdm630 and qcom,gcc-sdm660) > + > +$ref: qcom,gcc.yaml# > + > +properties: > + compatible: > + enum: > + - qcom,gcc-sdm630 > + - qcom,gcc-sdm660 > + > + clocks: > + items: > + - description: XO source > + - description: Sleep clock source > + > + clock-names: > + items: > + - const: xo > + - const: sleep_clk > + > + power-domains: > + maxItems: 1 > + > +required: > + - compatible > + > +unevaluatedProperties: false > + > +examples: > + # Example for GCC for SDM660: > + - | > + #include <dt-bindings/clock/qcom,rpmh.h> > + clock-controller@100000 { > + compatible = "qcom,gcc-sdm660"; > + #clock-cells = <1>; > + #reset-cells = <1>; > + #power-domain-cells = <1>; > + reg = <0x00100000 0x94000>; reg after compatible? Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 28/09/2022 16:58, Dmitry Baryshkov wrote: > Move schema for the GCC on SDM630/SDM636/SDM660 to a separate file to be > able to define device-specific clock properties. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > .../bindings/clock/qcom,gcc-other.yaml | 3 - > .../bindings/clock/qcom,gcc-sdm660.yaml | 61 +++++++++++++++++++ > 2 files changed, 61 insertions(+), 3 deletions(-) > create mode 100644 Documentation/devicetree/bindings/clock/qcom,gcc-sdm660.yaml > > diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-other.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-other.yaml > index 76988e04c7db..35fc22a19000 100644 > --- a/Documentation/devicetree/bindings/clock/qcom,gcc-other.yaml > +++ b/Documentation/devicetree/bindings/clock/qcom,gcc-other.yaml > @@ -24,7 +24,6 @@ description: | > - dt-bindings/clock/qcom,gcc-mdm9607.h > - dt-bindings/clock/qcom,gcc-mdm9615.h > - dt-bindings/reset/qcom,gcc-mdm9615.h > - - dt-bindings/clock/qcom,gcc-sdm660.h (qcom,gcc-sdm630 and qcom,gcc-sdm660) > > allOf: > - $ref: "qcom,gcc.yaml#" > @@ -41,8 +40,6 @@ properties: > - qcom,gcc-msm8974pro > - qcom,gcc-msm8974pro-ac > - qcom,gcc-mdm9615 > - - qcom,gcc-sdm630 > - - qcom,gcc-sdm660 > > required: > - compatible > diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-sdm660.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-sdm660.yaml > new file mode 100644 > index 000000000000..a39f28d37387 > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/qcom,gcc-sdm660.yaml > @@ -0,0 +1,61 @@ > +# SPDX-License-Identifier: GPL-2.0-only > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/clock/qcom,gcc-sdm660.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm Global Clock & Reset Controller Binding for SDM660/SDM630/SDM636 And one more comment: drop "Binding". Title is for hardware, so for example: Qualcomm SDM660/SDM630/SDM636 Global Clock & Reset Controller Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-other.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-other.yaml index 76988e04c7db..35fc22a19000 100644 --- a/Documentation/devicetree/bindings/clock/qcom,gcc-other.yaml +++ b/Documentation/devicetree/bindings/clock/qcom,gcc-other.yaml @@ -24,7 +24,6 @@ description: | - dt-bindings/clock/qcom,gcc-mdm9607.h - dt-bindings/clock/qcom,gcc-mdm9615.h - dt-bindings/reset/qcom,gcc-mdm9615.h - - dt-bindings/clock/qcom,gcc-sdm660.h (qcom,gcc-sdm630 and qcom,gcc-sdm660) allOf: - $ref: "qcom,gcc.yaml#" @@ -41,8 +40,6 @@ properties: - qcom,gcc-msm8974pro - qcom,gcc-msm8974pro-ac - qcom,gcc-mdm9615 - - qcom,gcc-sdm630 - - qcom,gcc-sdm660 required: - compatible diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-sdm660.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-sdm660.yaml new file mode 100644 index 000000000000..a39f28d37387 --- /dev/null +++ b/Documentation/devicetree/bindings/clock/qcom,gcc-sdm660.yaml @@ -0,0 +1,61 @@ +# SPDX-License-Identifier: GPL-2.0-only +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/clock/qcom,gcc-sdm660.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Qualcomm Global Clock & Reset Controller Binding for SDM660/SDM630/SDM636 + +maintainers: + - Stephen Boyd <sboyd@kernel.org> + - Taniya Das <tdas@codeaurora.org> + +description: | + Qualcomm global clock control module which supports the clocks, resets and + power domains on SDM630, SDM636 and SDM660 + + See also: + - dt-bindings/clock/qcom,gcc-sdm660.h (qcom,gcc-sdm630 and qcom,gcc-sdm660) + +$ref: qcom,gcc.yaml# + +properties: + compatible: + enum: + - qcom,gcc-sdm630 + - qcom,gcc-sdm660 + + clocks: + items: + - description: XO source + - description: Sleep clock source + + clock-names: + items: + - const: xo + - const: sleep_clk + + power-domains: + maxItems: 1 + +required: + - compatible + +unevaluatedProperties: false + +examples: + # Example for GCC for SDM660: + - | + #include <dt-bindings/clock/qcom,rpmh.h> + clock-controller@100000 { + compatible = "qcom,gcc-sdm660"; + #clock-cells = <1>; + #reset-cells = <1>; + #power-domain-cells = <1>; + reg = <0x00100000 0x94000>; + + clock-names = "xo", "sleep_clk"; + clocks = <&xo_board>, + <&sleep_clk>; + }; +...
Move schema for the GCC on SDM630/SDM636/SDM660 to a separate file to be able to define device-specific clock properties. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- .../bindings/clock/qcom,gcc-other.yaml | 3 - .../bindings/clock/qcom,gcc-sdm660.yaml | 61 +++++++++++++++++++ 2 files changed, 61 insertions(+), 3 deletions(-) create mode 100644 Documentation/devicetree/bindings/clock/qcom,gcc-sdm660.yaml