| Message ID | 20220927191736.299702-1-marex@denx.de |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | [1/3] dt-bindings: mmc: arm,pl18x: Document interrupt-names is ignored | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Tue, Sep 27, 2022 at 09:17:34PM +0200, Marek Vasut wrote: > Due to inconsistency of existing DTs regarding the content of this IP > interrupt-names DT property, document this such that interrupt-names > is not used by this IP bindings. > > Signed-off-by: Marek Vasut <marex@denx.de> > --- > Cc: Alexandre Torgue <alexandre.torgue@foss.st.com> > Cc: Andy Gross <agross@kernel.org> > Cc: Bjorn Andersson <andersson@kernel.org> > Cc: Konrad Dybcio <konrad.dybcio@somainline.org> > Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Ulf Hansson <ulf.hansson@linaro.org> > Cc: Yann Gautier <yann.gautier@foss.st.com> > Cc: devicetree@vger.kernel.org > Cc: linux-mmc@vger.kernel.org > Cc: linux-arm-msm@vger.kernel.org > Cc: linux-stm32@st-md-mailman.stormreply.com > To: linux-arm-kernel@lists.infradead.org > --- > Documentation/devicetree/bindings/mmc/arm,pl18x.yaml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml b/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml > index 1e69a5a42439b..a0ddf6495f85e 100644 > --- a/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml > +++ b/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml > @@ -95,7 +95,8 @@ properties: > PIO (polled I/O) interrupt and occurs when the FIFO needs to be > emptied as part of a bulk read from the card. Some variants have these > two interrupts wired into the same line (logic OR) and in that case > - only one interrupt may be provided. > + only one interrupt may be provided. The interrupt-names property is > + not used due to inconsistency of existing DTs regarding its content. > minItems: 1 > maxItems: 2 deprecated: false > > -- > 2.35.1 > >
On Tue, Sep 27, 2022 at 9:17 PM Marek Vasut <marex@denx.de> wrote: > The pl18x MMCI driver does not use the interrupt-names property, > the binding document has been updated to recommend this property > be unused, remove it. > > Signed-off-by: Marek Vasut <marex@denx.de> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
On Tue, Sep 27, 2022 at 9:17 PM Marek Vasut <marex@denx.de> wrote: > The pl18x MMCI driver does not use the interrupt-names property, > the binding document has been updated to recommend this property > be unused, remove it. > > Signed-off-by: Marek Vasut <marex@denx.de> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
On 9/27/22 21:17, Marek Vasut wrote: > The pl18x MMCI driver does not use the interrupt-names property, > the binding document has been updated to recommend this property > be unused, remove it. > > Signed-off-by: Marek Vasut <marex@denx.de> Reviewed-by: Yann Gautier <yann.gautier@foss.st.com> Best regards, Yann
diff --git a/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml b/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml index 1e69a5a42439b..a0ddf6495f85e 100644 --- a/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml +++ b/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml @@ -95,7 +95,8 @@ properties: PIO (polled I/O) interrupt and occurs when the FIFO needs to be emptied as part of a bulk read from the card. Some variants have these two interrupts wired into the same line (logic OR) and in that case - only one interrupt may be provided. + only one interrupt may be provided. The interrupt-names property is + not used due to inconsistency of existing DTs regarding its content. minItems: 1 maxItems: 2
Due to inconsistency of existing DTs regarding the content of this IP interrupt-names DT property, document this such that interrupt-names is not used by this IP bindings. Signed-off-by: Marek Vasut <marex@denx.de> --- Cc: Alexandre Torgue <alexandre.torgue@foss.st.com> Cc: Andy Gross <agross@kernel.org> Cc: Bjorn Andersson <andersson@kernel.org> Cc: Konrad Dybcio <konrad.dybcio@somainline.org> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> Cc: Linus Walleij <linus.walleij@linaro.org> Cc: Rob Herring <robh+dt@kernel.org> Cc: Ulf Hansson <ulf.hansson@linaro.org> Cc: Yann Gautier <yann.gautier@foss.st.com> Cc: devicetree@vger.kernel.org Cc: linux-mmc@vger.kernel.org Cc: linux-arm-msm@vger.kernel.org Cc: linux-stm32@st-md-mailman.stormreply.com To: linux-arm-kernel@lists.infradead.org --- Documentation/devicetree/bindings/mmc/arm,pl18x.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)