diff mbox series

dt-bindings: memory-controller: st,stm32: Fix st,fmc2_ebi-cs-write-address-setup-ns

Message ID 20220926222003.527171-1-marex@denx.de
State Not Applicable, archived
Headers show
Series dt-bindings: memory-controller: st,stm32: Fix st,fmc2_ebi-cs-write-address-setup-ns | expand

Checks

Context Check Description
robh/checkpatch success
robh/patch-applied success
robh/dtbs-check warning build log
robh/dt-meta-schema success

Commit Message

Marek Vasut Sept. 26, 2022, 10:20 p.m. UTC
The property st,fmc2_ebi-cs-write-address-setup-ns should really be
st,fmc2-ebi-cs-write-address-setup-ns (there is underscore _ between
fmc2 and ebi and there should be a dash - instead). This is a remnant
from conversion of old non-upstream bindings. Fix it.

Signed-off-by: Marek Vasut <marex@denx.de>
---
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
Cc: Christophe Kerello <christophe.kerello@foss.st.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: devicetree@vger.kernel.org
Cc: linux-stm32@st-md-mailman.stormreply.com
To: linux-arm-kernel@lists.infradead.org
---
 .../bindings/memory-controllers/st,stm32-fmc2-ebi.yaml          | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Rob Herring Sept. 26, 2022, 10:26 p.m. UTC | #1
On Mon, Sep 26, 2022 at 5:20 PM Marek Vasut <marex@denx.de> wrote:
>
> The property st,fmc2_ebi-cs-write-address-setup-ns should really be
> st,fmc2-ebi-cs-write-address-setup-ns (there is underscore _ between
> fmc2 and ebi and there should be a dash - instead). This is a remnant
> from conversion of old non-upstream bindings. Fix it.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> ---
> Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
> Cc: Christophe Kerello <christophe.kerello@foss.st.com>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: devicetree@vger.kernel.org
> Cc: linux-stm32@st-md-mailman.stormreply.com
> To: linux-arm-kernel@lists.infradead.org
> ---
>  .../bindings/memory-controllers/st,stm32-fmc2-ebi.yaml          | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Rob Herring <robh@kernel.org>
Krzysztof Kozlowski Sept. 28, 2022, 7:11 a.m. UTC | #2
On Tue, 27 Sep 2022 00:20:03 +0200, Marek Vasut wrote:
> The property st,fmc2_ebi-cs-write-address-setup-ns should really be
> st,fmc2-ebi-cs-write-address-setup-ns (there is underscore _ between
> fmc2 and ebi and there should be a dash - instead). This is a remnant
> from conversion of old non-upstream bindings. Fix it.
> 
> 

Applied, thanks!

[1/1] dt-bindings: memory-controller: st,stm32: Fix st,fmc2_ebi-cs-write-address-setup-ns
      https://git.kernel.org/krzk/linux-mem-ctrl/c/587f9891ec9661e16df7e5268543416a7d8cb547

Best regards,
Krzysztof Kozlowski Sept. 28, 2022, 7:12 a.m. UTC | #3
On 28/09/2022 09:11, Krzysztof Kozlowski wrote:
> On Tue, 27 Sep 2022 00:20:03 +0200, Marek Vasut wrote:
>> The property st,fmc2_ebi-cs-write-address-setup-ns should really be
>> st,fmc2-ebi-cs-write-address-setup-ns (there is underscore _ between
>> fmc2 and ebi and there should be a dash - instead). This is a remnant
>> from conversion of old non-upstream bindings. Fix it.
>>
>>
> 
> Applied, thanks!
> 
> [1/1] dt-bindings: memory-controller: st,stm32: Fix st,fmc2_ebi-cs-write-address-setup-ns
>       https://git.kernel.org/krzk/linux-mem-ctrl/c/587f9891ec9661e16df7e5268543416a7d8cb547

Just a note: it's late for me in the cycle to pick up patches. I applied
this but there is a change it will miss this merge window. If that
happens, I will keep it for next cycle (no need to resend).

Best regards,
Krzysztof
Marek Vasut Sept. 28, 2022, 12:51 p.m. UTC | #4
On 9/28/22 09:12, Krzysztof Kozlowski wrote:
> On 28/09/2022 09:11, Krzysztof Kozlowski wrote:
>> On Tue, 27 Sep 2022 00:20:03 +0200, Marek Vasut wrote:
>>> The property st,fmc2_ebi-cs-write-address-setup-ns should really be
>>> st,fmc2-ebi-cs-write-address-setup-ns (there is underscore _ between
>>> fmc2 and ebi and there should be a dash - instead). This is a remnant
>>> from conversion of old non-upstream bindings. Fix it.
>>>
>>>
>>
>> Applied, thanks!
>>
>> [1/1] dt-bindings: memory-controller: st,stm32: Fix st,fmc2_ebi-cs-write-address-setup-ns
>>        https://git.kernel.org/krzk/linux-mem-ctrl/c/587f9891ec9661e16df7e5268543416a7d8cb547
> 
> Just a note: it's late for me in the cycle to pick up patches. I applied
> this but there is a change it will miss this merge window.

That's no problem really, it's been broken for so long and nobody 
noticed, that one cycle won't make much of a difference.

> If that
> happens, I will keep it for next cycle (no need to resend).

Nice, thanks !
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/memory-controllers/st,stm32-fmc2-ebi.yaml b/Documentation/devicetree/bindings/memory-controllers/st,stm32-fmc2-ebi.yaml
index 6b516d3895af2..a1f535cececcc 100644
--- a/Documentation/devicetree/bindings/memory-controllers/st,stm32-fmc2-ebi.yaml
+++ b/Documentation/devicetree/bindings/memory-controllers/st,stm32-fmc2-ebi.yaml
@@ -156,7 +156,7 @@  patternProperties:
         description: This property defines the data latency before reading or
           writing the first data in nanoseconds.
 
-      st,fmc2_ebi-cs-write-address-setup-ns:
+      st,fmc2-ebi-cs-write-address-setup-ns:
         description: This property defines the duration of the address setup
           phase in nanoseconds used for asynchronous write transactions.