| Message ID | 20220926183727.1893566-2-aurelien@aurel32.net |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | Add support for the Hardkernel ODROID-M1 board | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 26/09/2022 20:37, Aurelien Jarno wrote: > From: Dongjin Kim <tobetter@gmail.com> > > Add device tree binding for Hardkernel ODROID-M1 board based on RK3568 > SoC. > > Signed-off-by: Dongjin Kim <tobetter@gmail.com> > Acked-by: Rob Herring <robh@kernel.org> > --- > Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml > index 7811ba64149c..d25a8a0bb2b5 100644 > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml > @@ -688,6 +688,11 @@ properties: > - const: rockchip,rk3568-bpi-r2pro > - const: rockchip,rk3568 > > + - description: Rockchip RK3568 Hardkernel ODROID-M1 Description should be just "Hardkernel ODROID-M1" and then put in alphabetical order - before to other Rockchip boards. Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 26/09/2022 20:37, Aurelien Jarno wrote: > From: Dongjin Kim <tobetter@gmail.com> > > Add device tree binding for Hardkernel ODROID-M1 board based on RK3568 > SoC. > > Signed-off-by: Dongjin Kim <tobetter@gmail.com> > Acked-by: Rob Herring <robh@kernel.org> And second issue - your SoB is missing here. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml index 7811ba64149c..d25a8a0bb2b5 100644 --- a/Documentation/devicetree/bindings/arm/rockchip.yaml +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml @@ -688,6 +688,11 @@ properties: - const: rockchip,rk3568-bpi-r2pro - const: rockchip,rk3568 + - description: Rockchip RK3568 Hardkernel ODROID-M1 + items: + - const: rockchip,rk3568-odroid-m1 + - const: rockchip,rk3568 + additionalProperties: true ...