diff mbox series

[RESEND,v3,6/7] dt-bindings: spi: spi-zynqmp-qspi: Add support for Xilinx Versal QSPI

Message ID 20220926063327.20753-7-amit.kumar-mahapatra@xilinx.com
State Not Applicable, archived
Headers show
Series spi: spi-zyqnmp-gqspi: Add tap delay and Versal platform support | expand

Checks

Context Check Description
robh/checkpatch success
robh/patch-applied success
robh/dtbs-check warning build log
robh/dt-meta-schema success

Commit Message

Amit Kumar Mahapatra Sept. 26, 2022, 6:33 a.m. UTC
Add new compatible to support QSPI controller on Xilinx Versal SoCs.

Signed-off-by: Amit Kumar Mahapatra <amit.kumar-mahapatra@xilinx.com>
---
 Documentation/devicetree/bindings/spi/spi-zynqmp-qspi.yaml | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Krzysztof Kozlowski Sept. 26, 2022, 9:01 a.m. UTC | #1
On 26/09/2022 08:33, Amit Kumar Mahapatra wrote:
> Add new compatible to support QSPI controller on Xilinx Versal SoCs.

Use subject prefixes matching the subsystem (git log --oneline -- ...).

This is still not fixed.

> 
> Signed-off-by: Amit Kumar Mahapatra <amit.kumar-mahapatra@xilinx.com>
> ---
>  Documentation/devicetree/bindings/spi/spi-zynqmp-qspi.yaml | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/spi/spi-zynqmp-qspi.yaml b/Documentation/devicetree/bindings/spi/spi-zynqmp-qspi.yaml
> index fafde1c06be6..5ed651084896 100644
> --- a/Documentation/devicetree/bindings/spi/spi-zynqmp-qspi.yaml
> +++ b/Documentation/devicetree/bindings/spi/spi-zynqmp-qspi.yaml
> @@ -14,7 +14,9 @@ allOf:
>  
>  properties:
>    compatible:
> -    const: xlnx,zynqmp-qspi-1.0
> +    enum:
> +      - xlnx,versal-qspi-1.0
> +      - xlnx,zynqmp-qspi-1.0

With fixed subject:

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Mahapatra, Amit Kumar Sept. 27, 2022, 9:40 a.m. UTC | #2
Hello Krzysztof,

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: Monday, September 26, 2022 2:32 PM
> To: Amit Kumar Mahapatra <amit.kumar-mahapatra@xilinx.com>;
> broonie@kernel.org; robh+dt@kernel.org;
> krzysztof.kozlowski+dt@linaro.org
> Cc: Mahapatra, Amit Kumar <amit.kumar-mahapatra@amd.com>; git (AMD-
> Xilinx) <git@amd.com>; michal.simek@xilinx.com; linux-spi@vger.kernel.org;
> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
> devicetree@vger.kernel.org; Mahapatra, Amit Kumar <amit.kumar-
> mahapatra@amd.com>
> Subject: Re: [RESEND PATCH v3 6/7] dt-bindings: spi: spi-zynqmp-qspi: Add
> support for Xilinx Versal QSPI
> 
> On 26/09/2022 08:33, Amit Kumar Mahapatra wrote:
> > Add new compatible to support QSPI controller on Xilinx Versal SoCs.
> 
> Use subject prefixes matching the subsystem (git log --oneline -- ...).
> 
> This is still not fixed.
I missed this comment in the previous version. I will fix it & send the next version.

Thanks,
Amit
> 
> >
> > Signed-off-by: Amit Kumar Mahapatra <amit.kumar-
> mahapatra@xilinx.com>
> > ---
> >  Documentation/devicetree/bindings/spi/spi-zynqmp-qspi.yaml | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/spi/spi-zynqmp-qspi.yaml
> b/Documentation/devicetree/bindings/spi/spi-zynqmp-qspi.yaml
> > index fafde1c06be6..5ed651084896 100644
> > --- a/Documentation/devicetree/bindings/spi/spi-zynqmp-qspi.yaml
> > +++ b/Documentation/devicetree/bindings/spi/spi-zynqmp-qspi.yaml
> > @@ -14,7 +14,9 @@ allOf:
> >
> >  properties:
> >    compatible:
> > -    const: xlnx,zynqmp-qspi-1.0
> > +    enum:
> > +      - xlnx,versal-qspi-1.0
> > +      - xlnx,zynqmp-qspi-1.0
> 
> With fixed subject:
> 
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> Best regards,
> Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/spi/spi-zynqmp-qspi.yaml b/Documentation/devicetree/bindings/spi/spi-zynqmp-qspi.yaml
index fafde1c06be6..5ed651084896 100644
--- a/Documentation/devicetree/bindings/spi/spi-zynqmp-qspi.yaml
+++ b/Documentation/devicetree/bindings/spi/spi-zynqmp-qspi.yaml
@@ -14,7 +14,9 @@  allOf:
 
 properties:
   compatible:
-    const: xlnx,zynqmp-qspi-1.0
+    enum:
+      - xlnx,versal-qspi-1.0
+      - xlnx,zynqmp-qspi-1.0
 
   reg:
     maxItems: 2