| Message ID | 20220925211744.133947-2-luca@z3ntu.xyz |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | [1/2] dt-bindings: mfd: qcom,spmi-pmic: adjust pwm node validation | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success | |
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 25/09/2022 23:17, Luca Weiss wrote: Thank you for your patch. There is something to discuss/improve. > additionalProperties: true # FIXME qcom,pm8916-wcd-analog-codec binding not converted yet > > + "charger@[0-9a-f]+$": > + type: object > + oneOf: > + - $ref: /schemas/power/supply/qcom,pm8941-charger.yaml# > + - $ref: /schemas/power/supply/qcom,pm8941-coincell.yaml# > + > + "^dcdc@[0-9a-f]+$": > + type: object How about renaming this one to usb-vbus-regulator? Best regards, Krzysztof
On Montag, 26. September 2022 10:51:45 CEST Krzysztof Kozlowski wrote: > On 25/09/2022 23:17, Luca Weiss wrote: > > Thank you for your patch. There is something to discuss/improve. > > > additionalProperties: true # FIXME qcom,pm8916-wcd-analog-codec > > binding not converted yet> > > + "charger@[0-9a-f]+$": > > + type: object > > + oneOf: > > + - $ref: /schemas/power/supply/qcom,pm8941-charger.yaml# > > + - $ref: /schemas/power/supply/qcom,pm8941-coincell.yaml# > > + > > + "^dcdc@[0-9a-f]+$": > > + type: object > > How about renaming this one to usb-vbus-regulator? Sounds good to me. I was actually hoping somebody would suggest a better name. Should I wait a bit to see if anybody else has a better suggestion or send a v2 now? Regards Luca > > Best regards, > Krzysztof
diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml index 16ade0fa2d33..e54fb5d64ef8 100644 --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml @@ -105,7 +105,9 @@ properties: patternProperties: "^adc@[0-9a-f]+$": type: object - $ref: /schemas/iio/adc/qcom,spmi-vadc.yaml# + oneOf: + - $ref: /schemas/iio/adc/qcom,spmi-iadc.yaml# + - $ref: /schemas/iio/adc/qcom,spmi-vadc.yaml# "^adc-tm@[0-9a-f]+$": type: object @@ -115,6 +117,16 @@ patternProperties: type: object additionalProperties: true # FIXME qcom,pm8916-wcd-analog-codec binding not converted yet + "charger@[0-9a-f]+$": + type: object + oneOf: + - $ref: /schemas/power/supply/qcom,pm8941-charger.yaml# + - $ref: /schemas/power/supply/qcom,pm8941-coincell.yaml# + + "^dcdc@[0-9a-f]+$": + type: object + $ref: /schemas/regulator/qcom,usb-vbus-regulator.yaml# + "extcon@[0-9a-f]+$": type: object $ref: /schemas/extcon/qcom,pm8941-misc.yaml#
* 'adc@' is either spmi-iadc or spmi-vadc * 'charger@' is either pm8941-charger or pm8941-coincell * 'dcdc@' is usb-vbus-regulator Signed-off-by: Luca Weiss <luca@z3ntu.xyz> --- .../devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-)