| Message ID | 20220920114051.1116441-5-bhupesh.sharma@linaro.org |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | crypto: qcom-qce: Add YAML bindings & support for newer SoCs | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 20/09/2022 13:40, Bhupesh Sharma wrote: > Newer Qualcomm chips support newer versions of the qce crypto IP, so add > soc specific compatible strings for qcom-qce instead of using crypto > IP version specific ones. > > Keep the old strings for backward-compatibility, but mark them as > deprecated. > > Cc: Bjorn Andersson <andersson@kernel.org> > Reviewed-by: Rob Herring <robh@kernel.org> > Tested-by: Jordan Crouse <jorcrous@amazon.com> > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> > --- > .../devicetree/bindings/crypto/qcom-qce.yaml | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml > index 4e00e7925fed..aa2f676f5382 100644 > --- a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml > +++ b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml > @@ -15,7 +15,15 @@ description: > > properties: > compatible: > - const: qcom,crypto-v5.1 > + enum: > + - qcom,crypto-v5.1 # Deprecated. Kept only for backward compatibility No changes since v6. Best regards, Krzysztof
On 9/20/22 8:40 PM, Krzysztof Kozlowski wrote: > On 20/09/2022 13:40, Bhupesh Sharma wrote: >> Newer Qualcomm chips support newer versions of the qce crypto IP, so add >> soc specific compatible strings for qcom-qce instead of using crypto >> IP version specific ones. >> >> Keep the old strings for backward-compatibility, but mark them as >> deprecated. >> >> Cc: Bjorn Andersson <andersson@kernel.org> >> Reviewed-by: Rob Herring <robh@kernel.org> >> Tested-by: Jordan Crouse <jorcrous@amazon.com> >> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> >> --- >> .../devicetree/bindings/crypto/qcom-qce.yaml | 12 ++++++++++-- >> 1 file changed, 10 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml >> index 4e00e7925fed..aa2f676f5382 100644 >> --- a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml >> +++ b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml >> @@ -15,7 +15,15 @@ description: >> >> properties: >> compatible: >> - const: qcom,crypto-v5.1 >> + enum: >> + - qcom,crypto-v5.1 # Deprecated. Kept only for backward compatibility > > No changes since v6. Right. v7 is just to propose the new subset of patchsets and ordering (since we changed it from v5 - which was a single patchset) and get some early feedback and comments and get to know if the respective maintainers are fine with the patch ordering, cc-list etc. I will surely include your comments in v8. Thanks, Bhupesh
diff --git a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml index 4e00e7925fed..aa2f676f5382 100644 --- a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml +++ b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml @@ -15,7 +15,15 @@ description: properties: compatible: - const: qcom,crypto-v5.1 + enum: + - qcom,crypto-v5.1 # Deprecated. Kept only for backward compatibility + - qcom,ipq6018-qce + - qcom,ipq8074-qce + - qcom,msm8996-qce + - qcom,sdm845-qce + - qcom,sm8150-qce + - qcom,sm8250-qce + - qcom,sm8350-qce reg: maxItems: 1 @@ -70,7 +78,7 @@ examples: - | #include <dt-bindings/clock/qcom,gcc-apq8084.h> crypto-engine@fd45a000 { - compatible = "qcom,crypto-v5.1"; + compatible = "qcom,ipq6018-qce"; reg = <0xfd45a000 0x6000>; clocks = <&gcc GCC_CE2_AHB_CLK>, <&gcc GCC_CE2_AXI_CLK>,