| Message ID | 20220919-v1-1-4844816c9808@baylibre.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | Add MT8195 HDMI support | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success |
On Mon, 2022-09-19 at 18:55 +0200, Guillaume Ranquet wrote: > From: Pablo Sun <pablo.sun@mediatek.com> > > Expand dt-bindings slot for VDOSYS1 of MT8195. > This clock is required by the DPI1 hardware > and is a downstream of the HDMI pixel clock. > > Signed-off-by: Pablo Sun <pablo.sun@mediatek.com> > Signed-off-by: Guillaume Ranquet <granquet@baylibre.com> > Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com> > > diff --git a/include/dt-bindings/clock/mt8195-clk.h b/include/dt- > bindings/clock/mt8195-clk.h > index 95cf812a0b37..d70d017ad69c 100644 > --- a/include/dt-bindings/clock/mt8195-clk.h > +++ b/include/dt-bindings/clock/mt8195-clk.h > @@ -859,6 +859,8 @@ > #define CLK_VDO1_DPINTF 47 > #define CLK_VDO1_DISP_MONITOR_DPINTF 48 > #define CLK_VDO1_26M_SLOW 49 > -#define CLK_VDO1_NR_CLK 50 > +#define CLK_VDO1_DPI1_HDMI 50 > +#define CLK_VDO1_NR_CLK 51 > + > > #endif /* _DT_BINDINGS_CLK_MT8195_H */ Hello Guillaume, I am not sure the reason, but it seems patches in this series lack of something like this for whole series: --- Documentation/devicetree/bindings/watchdog/mtk-wdt.txt | 1 + 1 file changed, 1 insertion(+) BRs, Bo-Chen
On 19/09/2022 18:55, Guillaume Ranquet wrote: > From: Pablo Sun <pablo.sun@mediatek.com> > > Expand dt-bindings slot for VDOSYS1 of MT8195. > This clock is required by the DPI1 hardware > and is a downstream of the HDMI pixel clock. > > Signed-off-by: Pablo Sun <pablo.sun@mediatek.com> > Signed-off-by: Guillaume Ranquet <granquet@baylibre.com> > Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com> > Looks like broken patch. Best regards, Krzysztof
On Thu, 22 Sep 2022 09:11, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: >On 19/09/2022 18:55, Guillaume Ranquet wrote: >> From: Pablo Sun <pablo.sun@mediatek.com> >> >> Expand dt-bindings slot for VDOSYS1 of MT8195. >> This clock is required by the DPI1 hardware >> and is a downstream of the HDMI pixel clock. >> >> Signed-off-by: Pablo Sun <pablo.sun@mediatek.com> >> Signed-off-by: Guillaume Ranquet <granquet@baylibre.com> >> Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com> >> > >Looks like broken patch. > >Best regards, >Krzysztof > Hi Bo-Chen and Krzysztof, I've sent the patches using the rather new b4 prep/send commands. Though it produces valid patches, it's using `git show --format=email` to produce the patches, which lacks a diffstat. My understanding is that the diffstat is considered to be comments and thus are not necessary to produce a valid patch. I've reported the issue on the tools mailing list [1], I'm looking at providing a fix. I'll be extra careful at the patch format for V2. Sorry for the inconveniance, Guillaume. [1] https://lore.kernel.org/tools/CABnWg9uBOGqJMq=yCtn7SoEME=+2u1-ZK9ftb6=_jRhkhL_jiw@mail.gmail.com/T/#u
On 22/09/2022 14:45, Guillaume Ranquet wrote: > On Thu, 22 Sep 2022 09:11, Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: >> On 19/09/2022 18:55, Guillaume Ranquet wrote: >>> From: Pablo Sun <pablo.sun@mediatek.com> >>> >>> Expand dt-bindings slot for VDOSYS1 of MT8195. >>> This clock is required by the DPI1 hardware >>> and is a downstream of the HDMI pixel clock. >>> >>> Signed-off-by: Pablo Sun <pablo.sun@mediatek.com> >>> Signed-off-by: Guillaume Ranquet <granquet@baylibre.com> >>> Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com> >>> >> >> Looks like broken patch. >> >> Best regards, >> Krzysztof >> > > Hi Bo-Chen and Krzysztof, > I've sent the patches using the rather new b4 prep/send commands. > > Though it produces valid patches, it's using `git show --format=email` > to produce the patches, which lacks a diffstat. > > My understanding is that the diffstat is considered to be comments and thus > are not necessary to produce a valid patch. > > I've reported the issue on the tools mailing list [1], I'm looking at providing > a fix. > > I'll be extra careful at the patch format for V2. Thanks for explanation! Probably your patches are perfectly fine and should apply, although I must admit diffstat is often useful. Best regards, Krzysztof
On 19/09/2022 18:55, Guillaume Ranquet wrote: > From: Pablo Sun <pablo.sun@mediatek.com> > > Expand dt-bindings slot for VDOSYS1 of MT8195. > This clock is required by the DPI1 hardware > and is a downstream of the HDMI pixel clock. > > Signed-off-by: Pablo Sun <pablo.sun@mediatek.com> > Signed-off-by: Guillaume Ranquet <granquet@baylibre.com> > Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Thu, Sep 22, 2022 at 02:51:00PM +0200, Krzysztof Kozlowski wrote: > Thanks for explanation! Probably your patches are perfectly fine and > should apply, although I must admit diffstat is often useful. Krzysztof: The patches should indeed apply without problems and there's a fix for the missing diffstat already in place. Best regards, Konstantin
diff --git a/include/dt-bindings/clock/mt8195-clk.h b/include/dt-bindings/clock/mt8195-clk.h index 95cf812a0b37..d70d017ad69c 100644 --- a/include/dt-bindings/clock/mt8195-clk.h +++ b/include/dt-bindings/clock/mt8195-clk.h @@ -859,6 +859,8 @@ #define CLK_VDO1_DPINTF 47 #define CLK_VDO1_DISP_MONITOR_DPINTF 48 #define CLK_VDO1_26M_SLOW 49 -#define CLK_VDO1_NR_CLK 50 +#define CLK_VDO1_DPI1_HDMI 50 +#define CLK_VDO1_NR_CLK 51 + #endif /* _DT_BINDINGS_CLK_MT8195_H */