Message ID | 20220918095957.24537-1-yuanjilin@cdjrlc.com |
---|---|
State | Rejected, archived |
Headers | show |
Series | of: base: fix repeated words in comments | expand |
Context | Check | Description |
---|---|---|
robh/checkpatch | success | |
robh/checkpatch | success | |
robh/patch-applied | fail | build log |
robh/patch-applied | fail | build log |
On Sun, Sep 18, 2022 at 05:59:57PM +0800, Jilin Yuan wrote: > /** > * of_match_node - Tell if a device_node has a matching of_match structure > - * @matches: array of of device match structures to search in > + * @matches: array of device match structures to search in > * @node: the of device structure to match against > * > * Low level utility function used by device matching. > @@ -1175,7 +1175,7 @@ EXPORT_SYMBOL(of_match_node); > * you pass will not be searched, only the next one > * will; typically, you pass what the previous call > * returned. of_node_put() will be called on it > - * @matches: array of of device match structures to search in > + * @matches: array of device match structures to search in > * @match: Updated to point at the matches entry which matched That second "of" is the device, so the fix doesn't make sense. Also, PLEASE stop sending these mindless redundant word-stripping patches as byproduct of whatever automated tool you use. As Edward Cree said to one of your colleague [1]: > #ifdef RANT > NGL, getting kinda sick of these bogus comment text 'fixes' from people > who clearly don't have enough mastery of English to copyedit it. > (Previous one from this author was actually wrong too but I didn't catch > it at the time.) > English is a tricksy language, why would someone with a limited > understanding of it think that grammar fixes are the best use of their > time and energy? > I can't help suspecting that this is a box-ticking exercise, where a > certain corporate culture has a standard requirement that engineers > must get X number of Linux / opensource commits in order to get > promoted, and this kind of mindless patch is the easiest way for them > to achieve that. > #endif If you really want to do real cleanup, consider joining kernel-janitors list. Learn from above, thanks. [1]: https://lore.kernel.org/netdev/30f2488d-9af3-fe8d-6e6f-713a7d38800b@gmail.com/
diff --git a/drivers/of/base.c b/drivers/of/base.c index 8e96862d312e..9b8507fe6f9b 100644 --- a/drivers/of/base.c +++ b/drivers/of/base.c @@ -1150,7 +1150,7 @@ const struct of_device_id *__of_match_node(const struct of_device_id *matches, /** * of_match_node - Tell if a device_node has a matching of_match structure - * @matches: array of of device match structures to search in + * @matches: array of device match structures to search in * @node: the of device structure to match against * * Low level utility function used by device matching. @@ -1175,7 +1175,7 @@ EXPORT_SYMBOL(of_match_node); * you pass will not be searched, only the next one * will; typically, you pass what the previous call * returned. of_node_put() will be called on it - * @matches: array of of device match structures to search in + * @matches: array of device match structures to search in * @match: Updated to point at the matches entry which matched * * Return: A node pointer with refcount incremented, use
Delete the redundant word 'of'. Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com> --- drivers/of/base.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)