| Message ID | 20220911111200.199182-3-krzysztof.kozlowski@linaro.org |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | pinctrl/arm64: qcom: fix some of Qualcomm pinctrl schema warnings | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 23 lines checked |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 9/11/22 14:11, Krzysztof Kozlowski wrote: > SD card pins do not have function, so do not require it: > > pinctrl@500000: sdc2-off-state: 'oneOf' conditional failed, one must be fixed: > 'pins' is a required property > 'bias-disable;' is a required property > 'clk-pins' does not match any of the regexes: 'pinctrl-[0-9]+' > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by: Iskren Chernev <iskren.chernev@gmail.com> > --- > .../bindings/pinctrl/qcom,sm6115-pinctrl.yaml | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm6115-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm6115-pinctrl.yaml > index 8a2b4767c7b6..28b29bf714b4 100644 > --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm6115-pinctrl.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm6115-pinctrl.yaml > @@ -69,7 +69,6 @@ patternProperties: > description: > Pinctrl node's client devices use subnodes for desired pin configuration. > Client device subnodes use below standard properties. > - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" > > properties: > pins: > @@ -121,6 +120,16 @@ patternProperties: > required: > - pins > > + allOf: > + - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" > + - if: > + properties: > + pins: > + pattern: "^gpio([0-9]|[1-9][0-9]|10[0-9]|11[0-2])$" > + then: > + required: > + - function > + > additionalProperties: false > > allOf:
On Sun, 11 Sep 2022 13:11:22 +0200, Krzysztof Kozlowski wrote: > SD card pins do not have function, so do not require it: > > pinctrl@500000: sdc2-off-state: 'oneOf' conditional failed, one must be fixed: > 'pins' is a required property > 'bias-disable;' is a required property > 'clk-pins' does not match any of the regexes: 'pinctrl-[0-9]+' > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../bindings/pinctrl/qcom,sm6115-pinctrl.yaml | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > Acked-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm6115-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm6115-pinctrl.yaml index 8a2b4767c7b6..28b29bf714b4 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm6115-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm6115-pinctrl.yaml @@ -69,7 +69,6 @@ patternProperties: description: Pinctrl node's client devices use subnodes for desired pin configuration. Client device subnodes use below standard properties. - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" properties: pins: @@ -121,6 +120,16 @@ patternProperties: required: - pins + allOf: + - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" + - if: + properties: + pins: + pattern: "^gpio([0-9]|[1-9][0-9]|10[0-9]|11[0-2])$" + then: + required: + - function + additionalProperties: false allOf:
SD card pins do not have function, so do not require it: pinctrl@500000: sdc2-off-state: 'oneOf' conditional failed, one must be fixed: 'pins' is a required property 'bias-disable;' is a required property 'clk-pins' does not match any of the regexes: 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- .../bindings/pinctrl/qcom,sm6115-pinctrl.yaml | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-)