| Message ID | 20220910194237.10142-16-Sergey.Semin@baikalelectronics.ru |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | EDAC/mc/synopsys: Various fixes and cleanups | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success | |
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Sat, 10 Sep 2022 22:42:33 +0300, Serge Semin wrote: > The DT-schema name and the corresponding generic compatible string look > inappropriate in the current DW uMCTL2 DDRC DT-bindings: > 1. DT-schema name contains undefined vendor-prefix. It's supposed to be > "snps", not "synopsys". > 2. DT-schema name has "ecc" suffix. That is a device property, and has > nothing to do with the controller actual name. > 3. The controller name is different. It's DW uMCTL2 DDRC. Just DDRC > doesn't identify the IP-core in subject. > 4. There is no much point in using the IP-core version in the device name > since it can be retrieved from the corresponding device CSR. Moreover the > DW uMCTL2 DDRC driver doesn't differentiate the IP-core version at the > current state. > > In order to fix all the inconsistencies described above we suggest to > rename the DT-schema to "snps,dw-umctl2-ddrc.yaml", deprecate the > compatible string "snps,ddrc-3.80a" and define a new generic device > name as "snps,dw-umctl2-ddrc". > > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> > > --- > > Changelog v2: > - This is a new patch created on v2 by detaching the DT-schema renaming > from the previous patch in the series. (@Krzysztof) > - Fix the compatible string name so one would match the new DT-schema > name. > --- > .../{synopsys,ddrc-ecc.yaml => snps,dw-umctl2-ddrc.yaml} | 7 +++++-- > MAINTAINERS | 1 + > 2 files changed, 6 insertions(+), 2 deletions(-) > rename Documentation/devicetree/bindings/memory-controllers/{synopsys,ddrc-ecc.yaml => snps,dw-umctl2-ddrc.yaml} (83%) > Reviewed-by: Rob Herring <robh@kernel.org>
On Sat, 10 Sep 2022 22:42:33 +0300, Serge Semin wrote: > The DT-schema name and the corresponding generic compatible string look > inappropriate in the current DW uMCTL2 DDRC DT-bindings: > 1. DT-schema name contains undefined vendor-prefix. It's supposed to be > "snps", not "synopsys". > 2. DT-schema name has "ecc" suffix. That is a device property, and has > nothing to do with the controller actual name. > 3. The controller name is different. It's DW uMCTL2 DDRC. Just DDRC > doesn't identify the IP-core in subject. > 4. There is no much point in using the IP-core version in the device name > since it can be retrieved from the corresponding device CSR. Moreover the > DW uMCTL2 DDRC driver doesn't differentiate the IP-core version at the > current state. > > [...] Applied, thanks! [15/19] dt-bindings: memory: snps: Use more descriptive device name https://git.kernel.org/krzk/linux-mem-ctrl/c/9f60675a0f2e72f7967cc534f1c97f6da3b47392 Best regards,
diff --git a/Documentation/devicetree/bindings/memory-controllers/synopsys,ddrc-ecc.yaml b/Documentation/devicetree/bindings/memory-controllers/snps,dw-umctl2-ddrc.yaml similarity index 83% rename from Documentation/devicetree/bindings/memory-controllers/synopsys,ddrc-ecc.yaml rename to Documentation/devicetree/bindings/memory-controllers/snps,dw-umctl2-ddrc.yaml index 0be8ecc73d1a..9212dfe6e956 100644 --- a/Documentation/devicetree/bindings/memory-controllers/synopsys,ddrc-ecc.yaml +++ b/Documentation/devicetree/bindings/memory-controllers/snps,dw-umctl2-ddrc.yaml @@ -1,7 +1,7 @@ # SPDX-License-Identifier: GPL-2.0-only %YAML 1.2 --- -$id: http://devicetree.org/schemas/memory-controllers/synopsys,ddrc-ecc.yaml# +$id: http://devicetree.org/schemas/memory-controllers/snps,dw-umctl2-ddrc.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# title: Synopsys DesignWare Universal Multi-Protocol Memory Controller @@ -24,8 +24,11 @@ description: | properties: compatible: oneOf: - - description: Synopsys DW uMCTL2 DDR controller v3.80a + - deprecated: true + description: Synopsys DW uMCTL2 DDR controller v3.80a const: snps,ddrc-3.80a + - description: Synopsys DW uMCTL2 DDR controller + const: snps,dw-umctl2-ddrc - description: Xilinx ZynqMP DDR controller v2.40a const: xlnx,zynqmp-ddrc-2.40a diff --git a/MAINTAINERS b/MAINTAINERS index 40e1a146ca61..357230710ed9 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3087,6 +3087,7 @@ W: http://wiki.xilinx.com T: git https://github.com/Xilinx/linux-xlnx.git F: Documentation/devicetree/bindings/i2c/cdns,i2c-r1p10.yaml F: Documentation/devicetree/bindings/i2c/xlnx,xps-iic-2.00.a.yaml +F: Documentation/devicetree/bindings/memory-controllers/snps,dw-umctl2-ddrc.yaml F: Documentation/devicetree/bindings/memory-controllers/xlnx,zynq-ddrc-a05.yaml F: Documentation/devicetree/bindings/spi/xlnx,zynq-qspi.yaml F: arch/arm/mach-zynq/
The DT-schema name and the corresponding generic compatible string look inappropriate in the current DW uMCTL2 DDRC DT-bindings: 1. DT-schema name contains undefined vendor-prefix. It's supposed to be "snps", not "synopsys". 2. DT-schema name has "ecc" suffix. That is a device property, and has nothing to do with the controller actual name. 3. The controller name is different. It's DW uMCTL2 DDRC. Just DDRC doesn't identify the IP-core in subject. 4. There is no much point in using the IP-core version in the device name since it can be retrieved from the corresponding device CSR. Moreover the DW uMCTL2 DDRC driver doesn't differentiate the IP-core version at the current state. In order to fix all the inconsistencies described above we suggest to rename the DT-schema to "snps,dw-umctl2-ddrc.yaml", deprecate the compatible string "snps,ddrc-3.80a" and define a new generic device name as "snps,dw-umctl2-ddrc". Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> --- Changelog v2: - This is a new patch created on v2 by detaching the DT-schema renaming from the previous patch in the series. (@Krzysztof) - Fix the compatible string name so one would match the new DT-schema name. --- .../{synopsys,ddrc-ecc.yaml => snps,dw-umctl2-ddrc.yaml} | 7 +++++-- MAINTAINERS | 1 + 2 files changed, 6 insertions(+), 2 deletions(-) rename Documentation/devicetree/bindings/memory-controllers/{synopsys,ddrc-ecc.yaml => snps,dw-umctl2-ddrc.yaml} (83%)