| Message ID | 20220907121629.54330-1-alexander.sverdlin@nokia.com |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | [v2] of: irq: Report individual failures in of_irq_init() | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 9 lines checked |
| robh/patch-applied | fail | build log |
On Wed, 07 Sep 2022 14:16:29 +0200, Alexander A Sverdlin wrote: > From: Alexander Sverdlin <alexander.sverdlin@nokia.com> > > New pr_err(), a copy of preceeding pr_debug(), faciliates debugging. > > This change was inspired by a long lasting debugging of the > octeon_irq_init_ciu() which fails completely silently and leaves the > interrupt controller half-way configured which in turn had very non-obvious > effects. > > Signed-off-by: Alexander Sverdlin <alexander.sverdlin@nokia.com> > --- > > Changelog: > v2: > * Kept existing pr_debug() on Rob's request > > drivers/of/irq.c | 3 +++ > 1 file changed, 3 insertions(+) > Applied, thanks!
diff --git a/drivers/of/irq.c b/drivers/of/irq.c index d22f605..2bac44f 100644 --- a/drivers/of/irq.c +++ b/drivers/of/irq.c @@ -592,6 +592,9 @@ void __init of_irq_init(const struct of_device_id *matches) ret = desc->irq_init_cb(desc->dev, desc->interrupt_parent); if (ret) { + pr_err("%s: Failed to init %pOF (%p), parent %p\n", + __func__, desc->dev, desc->dev, + desc->interrupt_parent); of_node_clear_flag(desc->dev, OF_POPULATED); kfree(desc); continue;