| Message ID | 20220906095943.60296-1-alexander.sverdlin@nokia.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | of: irq: Report individual failures in of_irq_init() | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | fail | build log |
On Tue, Sep 6, 2022 at 4:59 AM Alexander A Sverdlin <alexander.sverdlin@nokia.com> wrote: > > From: Alexander Sverdlin <alexander.sverdlin@nokia.com> > > Rewrite pr_debug() as pr_err() to faciliate debugging. > > This change was inspired by a long lasting debugging of the > octeon_irq_init_ciu() which fails completely silently and leaves the > interrupt controller half-way configured which in turn had very non-obvious > effects. With this, if a node skipped completely won't be obvious. Please keep the debug line and just add the error print. > > Signed-off-by: Alexander Sverdlin <alexander.sverdlin@nokia.com> > --- > drivers/of/irq.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/of/irq.c b/drivers/of/irq.c > index d22f605..45e4392 100644 > --- a/drivers/of/irq.c > +++ b/drivers/of/irq.c > @@ -586,12 +586,12 @@ void __init of_irq_init(const struct of_device_id *matches) > > of_node_set_flag(desc->dev, OF_POPULATED); > > - pr_debug("of_irq_init: init %pOF (%p), parent %p\n", > - desc->dev, > - desc->dev, desc->interrupt_parent); > ret = desc->irq_init_cb(desc->dev, > desc->interrupt_parent); > if (ret) { > + pr_err("%s: Failed to init %pOF (%p), parent %p\n", > + __func__, desc->dev, desc->dev, > + desc->interrupt_parent); > of_node_clear_flag(desc->dev, OF_POPULATED); > kfree(desc); > continue; > -- > 2.10.2 >
diff --git a/drivers/of/irq.c b/drivers/of/irq.c index d22f605..45e4392 100644 --- a/drivers/of/irq.c +++ b/drivers/of/irq.c @@ -586,12 +586,12 @@ void __init of_irq_init(const struct of_device_id *matches) of_node_set_flag(desc->dev, OF_POPULATED); - pr_debug("of_irq_init: init %pOF (%p), parent %p\n", - desc->dev, - desc->dev, desc->interrupt_parent); ret = desc->irq_init_cb(desc->dev, desc->interrupt_parent); if (ret) { + pr_err("%s: Failed to init %pOF (%p), parent %p\n", + __func__, desc->dev, desc->dev, + desc->interrupt_parent); of_node_clear_flag(desc->dev, OF_POPULATED); kfree(desc); continue;