| Message ID | 20220831074923.3085937-2-peng.fan@oss.nxp.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | arm64: dts: imx93: add several nodes | expand |
On 31/08/2022 10:49, Peng Fan (OSS) wrote: > From: Peng Fan <peng.fan@nxp.com> > > Add binding doc for i.MX9 blk_ctrl_ns_aonmix and blk_ctrl_wakeupmix > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > --- > .../bindings/soc/imx/fsl,imx9-syscon.yaml | 37 +++++++++++++++++++ > 1 file changed, 37 insertions(+) > create mode 100644 Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml > > diff --git a/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml b/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml > new file mode 100644 > index 000000000000..90c5e354f86c > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml Filename: fsl,imx93-syscon.yaml > @@ -0,0 +1,37 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/soc/imx/fsl,imx9-syscon.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: NXP i.MX9 Platforms System Controller bindings s/bindings// > + > +maintainers: > + - Peng Fan <peng.fan@nxp.com> > + Does not look like you tested the bindings. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). You miss here select. > +properties: > + compatible: > + oneOf: Drop oneOf, unless you already have patch adding something more? > + - items: > + - enum: > + - fsl,imx93-aonmix-ns-syscfg > + - fsl,imx93-wakeupmix-syscfg > + - const: syscon > + > + reg: > + maxItems: 1 > + > +required: > + - compatible > + - reg Best regards, Krzysztof
Hi Krzysztof, > Subject: Re: [PATCH V2 1/8] dt-bindings: soc: imx: add binding for i.MX9 > syscon > > On 31/08/2022 10:49, Peng Fan (OSS) wrote: > > From: Peng Fan <peng.fan@nxp.com> > > > > Add binding doc for i.MX9 blk_ctrl_ns_aonmix and blk_ctrl_wakeupmix > > > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > > --- > > .../bindings/soc/imx/fsl,imx9-syscon.yaml | 37 +++++++++++++++++++ > > 1 file changed, 37 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml > > > > diff --git > > a/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml > > b/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml > > new file mode 100644 > > index 000000000000..90c5e354f86c > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml > > Filename: fsl,imx93-syscon.yaml There are more i.MX9 SoCs in the coming days, I am thinking to let this yaml could cover i.MX9[X]. So should I use fsl,imx93-syscon.yaml for now, and rename to fsl,imx9-syscon.yaml in future? > > > @@ -0,0 +1,37 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) %YAML 1.2 > > +--- > > +$id: > "https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevic > etree.org%2Fschemas%2Fsoc%2Fimx%2Ffsl%2Cimx9- > syscon.yaml%23&data=05%7C01%7Cpeng.fan%40nxp.com%7C9dec9a > aefa1e4c992bd708da8b259c6a%7C686ea1d3bc2b4c6fa92cd99c5c301635%7 > C0%7C0%7C637975290892739302%7CUnknown%7CTWFpbGZsb3d8eyJWIjoi > MC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C30 > 00%7C%7C%7C&sdata=TvEdbjOMcDosQr5Q82t4aaO7KHJDn5YcSA%2B > 9XDjj8%2Fc%3D&reserved=0" > > +$schema: > "https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevic > etree.org%2Fmeta- > schemas%2Fcore.yaml%23&data=05%7C01%7Cpeng.fan%40nxp.com% > 7C9dec9aaefa1e4c992bd708da8b259c6a%7C686ea1d3bc2b4c6fa92cd99c5c3 > 01635%7C0%7C0%7C637975290892739302%7CUnknown%7CTWFpbGZsb3d > 8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0% > 3D%7C3000%7C%7C%7C&sdata=0G8y17uvPiZ22xChJCmlTWFX6Tl%2Fq > G2kXF2bSUXDBaI%3D&reserved=0" > > + > > +title: NXP i.MX9 Platforms System Controller bindings > > s/bindings// Drop "bindings" in V3. > > > + > > +maintainers: > > + - Peng Fan <peng.fan@nxp.com> > > + > > Does not look like you tested the bindings. Please run `make > dt_binding_check` (see Documentation/devicetree/bindings/writing- > schema.rst for instructions). > > You miss here select. There is no error when I ran dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml make ARCH=arm64 DT_CHECKER_FLAGS=-m dt_binding_check LINT Documentation/devicetree/bindings CHKDT Documentation/devicetree/bindings/processed-schema.json SCHEMA Documentation/devicetree/bindings/processed-schema.json DTEX Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.example.dts DTC Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.example.dtb CHECK Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.example.dtb > > > +properties: > > + compatible: > > + oneOf: > > Drop oneOf, unless you already have patch adding something more? Ok, drop in v3. Thanks, Peng. > > > + - items: > > + - enum: > > + - fsl,imx93-aonmix-ns-syscfg > > + - fsl,imx93-wakeupmix-syscfg > > + - const: syscon > > + > > + reg: > > + maxItems: 1 > > + > > +required: > > + - compatible > > + - reg > > > Best regards, > Krzysztof
On 31/08/2022 10:49, Peng Fan (OSS) wrote: > From: Peng Fan <peng.fan@nxp.com> > > Add binding doc for i.MX9 blk_ctrl_ns_aonmix and blk_ctrl_wakeupmix > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > --- > .../bindings/soc/imx/fsl,imx9-syscon.yaml | 37 +++++++++++++++++++ > 1 file changed, 37 insertions(+) > create mode 100644 Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml > > diff --git a/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml b/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml > new file mode 100644 > index 000000000000..90c5e354f86c > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml > @@ -0,0 +1,37 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/soc/imx/fsl,imx9-syscon.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" One more - drop the quotes both lines above. Best regards, Krzysztof
On 31/08/2022 10:57, Peng Fan wrote: > Hi Krzysztof, > >> Subject: Re: [PATCH V2 1/8] dt-bindings: soc: imx: add binding for i.MX9 >> syscon >> >> On 31/08/2022 10:49, Peng Fan (OSS) wrote: >>> From: Peng Fan <peng.fan@nxp.com> >>> >>> Add binding doc for i.MX9 blk_ctrl_ns_aonmix and blk_ctrl_wakeupmix >>> >>> Signed-off-by: Peng Fan <peng.fan@nxp.com> >>> --- >>> .../bindings/soc/imx/fsl,imx9-syscon.yaml | 37 +++++++++++++++++++ >>> 1 file changed, 37 insertions(+) >>> create mode 100644 >>> Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml >>> >>> diff --git >>> a/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml >>> b/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml >>> new file mode 100644 >>> index 000000000000..90c5e354f86c >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml >> >> Filename: fsl,imx93-syscon.yaml > > There are more i.MX9 SoCs in the coming days, I am thinking to let this yaml > could cover i.MX9[X]. If you guarantee that you or someone else will add here more of such, then it can stay. (...) >> Does not look like you tested the bindings. Please run `make >> dt_binding_check` (see Documentation/devicetree/bindings/writing- >> schema.rst for instructions). >> >> You miss here select. > > There is no error when I ran dt_binding_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml > make ARCH=arm64 DT_CHECKER_FLAGS=-m dt_binding_check > LINT Documentation/devicetree/bindings > CHKDT Documentation/devicetree/bindings/processed-schema.json > SCHEMA Documentation/devicetree/bindings/processed-schema.json > DTEX Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.example.dts > DTC Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.example.dtb > CHECK Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.example.dtb Eh, you're right, I cannot reproduce the error. Something change in the schema and custom select seems not needed for this case, but I cannot identify what exactly changed. Best regards, Krzysztof
On 8/31/2022 5:15 PM, Krzysztof Kozlowski wrote: > On 31/08/2022 10:49, Peng Fan (OSS) wrote: >> From: Peng Fan <peng.fan@nxp.com> >> >> Add binding doc for i.MX9 blk_ctrl_ns_aonmix and blk_ctrl_wakeupmix >> >> Signed-off-by: Peng Fan <peng.fan@nxp.com> >> --- >> .../bindings/soc/imx/fsl,imx9-syscon.yaml | 37 +++++++++++++++++++ >> 1 file changed, 37 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml >> >> diff --git a/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml b/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml >> new file mode 100644 >> index 000000000000..90c5e354f86c >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml >> @@ -0,0 +1,37 @@ >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: "http://devicetree.org/schemas/soc/imx/fsl,imx9-syscon.yaml#" >> +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > > One more - drop the quotes both lines above. There will be dtbs_check error. I updated schema with: pip3 install git+https://github.com/devicetree-org/dt-schema.git@main So it is ok the drop the two quotes above? Is there any new update in dt-schema that not landed in repo? Thanks, Peng. > > Best regards, > Krzysztof
On 31/08/2022 13:08, Peng Fan wrote: > > > On 8/31/2022 5:15 PM, Krzysztof Kozlowski wrote: >> On 31/08/2022 10:49, Peng Fan (OSS) wrote: >>> From: Peng Fan <peng.fan@nxp.com> >>> >>> Add binding doc for i.MX9 blk_ctrl_ns_aonmix and blk_ctrl_wakeupmix >>> >>> Signed-off-by: Peng Fan <peng.fan@nxp.com> >>> --- >>> .../bindings/soc/imx/fsl,imx9-syscon.yaml | 37 +++++++++++++++++++ >>> 1 file changed, 37 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml b/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml >>> new file mode 100644 >>> index 000000000000..90c5e354f86c >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml >>> @@ -0,0 +1,37 @@ >>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: "http://devicetree.org/schemas/soc/imx/fsl,imx9-syscon.yaml#" >>> +$schema: "http://devicetree.org/meta-schemas/core.yaml#" >> >> One more - drop the quotes both lines above. > > There will be dtbs_check error. I updated schema with: > pip3 install git+https://github.com/devicetree-org/dt-schema.git@main > > So it is ok the drop the two quotes above? Is there > any new update in dt-schema that not landed in repo? This is something new to me, can you paste the error? Best regards, Krzysztof
On 8/31/2022 8:54 PM, Krzysztof Kozlowski wrote: > On 31/08/2022 13:08, Peng Fan wrote: >> >> >> On 8/31/2022 5:15 PM, Krzysztof Kozlowski wrote: >>> On 31/08/2022 10:49, Peng Fan (OSS) wrote: >>>> From: Peng Fan <peng.fan@nxp.com> >>>> >>>> Add binding doc for i.MX9 blk_ctrl_ns_aonmix and blk_ctrl_wakeupmix >>>> >>>> Signed-off-by: Peng Fan <peng.fan@nxp.com> >>>> --- >>>> .../bindings/soc/imx/fsl,imx9-syscon.yaml | 37 +++++++++++++++++++ >>>> 1 file changed, 37 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml >>>> >>>> diff --git a/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml b/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml >>>> new file mode 100644 >>>> index 000000000000..90c5e354f86c >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml >>>> @@ -0,0 +1,37 @@ >>>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >>>> +%YAML 1.2 >>>> +--- >>>> +$id: "http://devicetree.org/schemas/soc/imx/fsl,imx9-syscon.yaml#" >>>> +$schema: "http://devicetree.org/meta-schemas/core.yaml#" >>> >>> One more - drop the quotes both lines above. >> >> There will be dtbs_check error. I updated schema with: >> pip3 install git+https://github.com/devicetree-org/dt-schema.git@main >> >> So it is ok the drop the two quotes above? Is there >> any new update in dt-schema that not landed in repo? > > This is something new to me, can you paste the error? I have renamed the file to "fsl,imx93-syscon.yaml" $DT_SCHEMA_FILES=Documentation/devicetree/bindings/soc/imx/fsl,imx93-syscon.yaml make ARCH=arm64 DT_CHECKER_FLAGS=-m dtbs_check LINT Documentation/devicetree/bindings CHKDT Documentation/devicetree/bindings/processed-schema.json ./Documentation/devicetree/bindings/soc/imx/fsl,imx93-syscon.yaml: error checking schema file SCHEMA Documentation/devicetree/bindings/processed-schema.json Thanks, Peng. > > Best regards, > Krzysztof
On 31/08/2022 16:41, Peng Fan wrote: > > > On 8/31/2022 8:54 PM, Krzysztof Kozlowski wrote: >> On 31/08/2022 13:08, Peng Fan wrote: >>> >>> >>> On 8/31/2022 5:15 PM, Krzysztof Kozlowski wrote: >>>> On 31/08/2022 10:49, Peng Fan (OSS) wrote: >>>>> From: Peng Fan <peng.fan@nxp.com> >>>>> >>>>> Add binding doc for i.MX9 blk_ctrl_ns_aonmix and blk_ctrl_wakeupmix >>>>> >>>>> Signed-off-by: Peng Fan <peng.fan@nxp.com> >>>>> --- >>>>> .../bindings/soc/imx/fsl,imx9-syscon.yaml | 37 +++++++++++++++++++ >>>>> 1 file changed, 37 insertions(+) >>>>> create mode 100644 Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml b/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml >>>>> new file mode 100644 >>>>> index 000000000000..90c5e354f86c >>>>> --- /dev/null >>>>> +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml >>>>> @@ -0,0 +1,37 @@ >>>>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >>>>> +%YAML 1.2 >>>>> +--- >>>>> +$id: "http://devicetree.org/schemas/soc/imx/fsl,imx9-syscon.yaml#" >>>>> +$schema: "http://devicetree.org/meta-schemas/core.yaml#" >>>> >>>> One more - drop the quotes both lines above. >>> >>> There will be dtbs_check error. I updated schema with: >>> pip3 install git+https://github.com/devicetree-org/dt-schema.git@main >>> >>> So it is ok the drop the two quotes above? Is there >>> any new update in dt-schema that not landed in repo? >> >> This is something new to me, can you paste the error? > > I have renamed the file to "fsl,imx93-syscon.yaml" > > $DT_SCHEMA_FILES=Documentation/devicetree/bindings/soc/imx/fsl,imx93-syscon.yaml > make ARCH=arm64 DT_CHECKER_FLAGS=-m dtbs_check > > LINT Documentation/devicetree/bindings > CHKDT Documentation/devicetree/bindings/processed-schema.json > ./Documentation/devicetree/bindings/soc/imx/fsl,imx93-syscon.yaml: error > checking schema file > SCHEMA Documentation/devicetree/bindings/processed-schema.json Hm, not much of an actual message. Most - or almost all - bindings do not have quotes, you know... This is something with your setup because above error is not reproducible. Best regards, Krzysztof
On 8/31/2022 9:45 PM, Krzysztof Kozlowski wrote: > On 31/08/2022 16:41, Peng Fan wrote: >> >> >> On 8/31/2022 8:54 PM, Krzysztof Kozlowski wrote: >>> On 31/08/2022 13:08, Peng Fan wrote: >>>> >>>> >>>> On 8/31/2022 5:15 PM, Krzysztof Kozlowski wrote: >>>>> On 31/08/2022 10:49, Peng Fan (OSS) wrote: >>>>>> From: Peng Fan <peng.fan@nxp.com> >>>>>> >>>>>> Add binding doc for i.MX9 blk_ctrl_ns_aonmix and blk_ctrl_wakeupmix >>>>>> >>>>>> Signed-off-by: Peng Fan <peng.fan@nxp.com> >>>>>> --- >>>>>> .../bindings/soc/imx/fsl,imx9-syscon.yaml | 37 +++++++++++++++++++ >>>>>> 1 file changed, 37 insertions(+) >>>>>> create mode 100644 Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml >>>>>> >>>>>> diff --git a/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml b/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml >>>>>> new file mode 100644 >>>>>> index 000000000000..90c5e354f86c >>>>>> --- /dev/null >>>>>> +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml >>>>>> @@ -0,0 +1,37 @@ >>>>>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >>>>>> +%YAML 1.2 >>>>>> +--- >>>>>> +$id: "http://devicetree.org/schemas/soc/imx/fsl,imx9-syscon.yaml#" >>>>>> +$schema: "http://devicetree.org/meta-schemas/core.yaml#" >>>>> >>>>> One more - drop the quotes both lines above. >>>> >>>> There will be dtbs_check error. I updated schema with: >>>> pip3 install git+https://github.com/devicetree-org/dt-schema.git@main >>>> >>>> So it is ok the drop the two quotes above? Is there >>>> any new update in dt-schema that not landed in repo? >>> >>> This is something new to me, can you paste the error? >> >> I have renamed the file to "fsl,imx93-syscon.yaml" >> >> $DT_SCHEMA_FILES=Documentation/devicetree/bindings/soc/imx/fsl,imx93-syscon.yaml >> make ARCH=arm64 DT_CHECKER_FLAGS=-m dtbs_check >> >> LINT Documentation/devicetree/bindings >> CHKDT Documentation/devicetree/bindings/processed-schema.json >> ./Documentation/devicetree/bindings/soc/imx/fsl,imx93-syscon.yaml: error >> checking schema file >> SCHEMA Documentation/devicetree/bindings/processed-schema.json > > Hm, not much of an actual message. Most - or almost all - bindings do > not have quotes, you know... > > This is something with your setup because above error is not reproducible. I got something wrong in my side, my bad. It passes check now. Thanks, Peng. > > Best regards, > Krzysztof
diff --git a/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml b/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml new file mode 100644 index 000000000000..90c5e354f86c --- /dev/null +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml @@ -0,0 +1,37 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/soc/imx/fsl,imx9-syscon.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#" + +title: NXP i.MX9 Platforms System Controller bindings + +maintainers: + - Peng Fan <peng.fan@nxp.com> + +properties: + compatible: + oneOf: + - items: + - enum: + - fsl,imx93-aonmix-ns-syscfg + - fsl,imx93-wakeupmix-syscfg + - const: syscon + + reg: + maxItems: 1 + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + anomix_ns_gpr: syscon@44210000 { + compatible = "fsl,imx93-aonmix-ns-syscfg", "syscon"; + reg = <0x44210000 0x1000>; + }; + +...