| Message ID | 20220830134613.1564059-1-oliver@schinagl.nl |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | [v4] dt-bindings: leds: Expand LED_COLOR_ID definitions | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 2 warnings, 13 lines checked |
| robh/patch-applied | success |
Ho Olliver, Thanks for the update. On 8/30/22 15:46, Olliver Schinagl wrote: > In commit 853a78a7d6c7 (dt-bindings: leds: Add LED_COLOR_ID definitions, > Sun Jun 9 20:19:04 2019 +0200) the most basic color definitions where > added. However, there's a little more very common LED colors. > > While the documentation states 'add what is missing', engineers tend to > be lazy and will just use what currently exists. So this patch will take > (a) list from online retailers [0], [1], [2] and use the common LED colors from > there, this being reasonable as this is what is currently available to purchase. > > Note, that LIME seems to be the modern take to 'Yellow-green' or > 'Yellowish-green' from some older datasheets. > > [0]: https://www.digikey.com/en/products/filter/led-lighting-color/125 > [1]: https://eu.mouser.com/c/optoelectronics/led-lighting/led-emitters/standard-leds-smd > [2]: https://nl.farnell.com/en-NL/c/optoelectronics-displays/led-products/standard-single-colour-leds-under-75ma > > Signed-off-by: Olliver Schinagl <oliver@schinagl.nl> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > Changes since v3: Fix typo in purple; Fix whitespacing > No changes since v2: Re-send with the proper e-mails. > Changes since v1: Unbreak existing definitions. > include/dt-bindings/leds/common.h | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/include/dt-bindings/leds/common.h b/include/dt-bindings/leds/common.h > index 3be89a7c20a9..9a0d33d027ff 100644 > --- a/include/dt-bindings/leds/common.h > +++ b/include/dt-bindings/leds/common.h > @@ -33,7 +33,12 @@ > #define LED_COLOR_ID_MULTI 8 /* For multicolor LEDs */ > #define LED_COLOR_ID_RGB 9 /* For multicolor LEDs that can do arbitrary color, > so this would include RGBW and similar */ > -#define LED_COLOR_ID_MAX 10 > +#define LED_COLOR_ID_PURPLE 10 > +#define LED_COLOR_ID_ORANGE 11 > +#define LED_COLOR_ID_PINK 12 > +#define LED_COLOR_ID_CYAN 13 > +#define LED_COLOR_ID_LIME 14 > +#define LED_COLOR_ID_MAX 15 > > /* Standard LED functions */ > /* Keyboard LEDs, usually it would be input4::capslock etc. */ Acked-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Hei Olliver, Am Tue, Aug 30, 2022 at 03:46:13PM +0200 schrieb Olliver Schinagl: > In commit 853a78a7d6c7 (dt-bindings: leds: Add LED_COLOR_ID definitions, > Sun Jun 9 20:19:04 2019 +0200) the most basic color definitions where > added. However, there's a little more very common LED colors. > > While the documentation states 'add what is missing', engineers tend to > be lazy and will just use what currently exists. So this patch will take > (a) list from online retailers [0], [1], [2] and use the common LED colors from > there, this being reasonable as this is what is currently available to purchase. > > Note, that LIME seems to be the modern take to 'Yellow-green' or > 'Yellowish-green' from some older datasheets. > > [0]: https://www.digikey.com/en/products/filter/led-lighting-color/125 > [1]: https://eu.mouser.com/c/optoelectronics/led-lighting/led-emitters/standard-leds-smd > [2]: https://nl.farnell.com/en-NL/c/optoelectronics-displays/led-products/standard-single-colour-leds-under-75ma > > Signed-off-by: Olliver Schinagl <oliver@schinagl.nl> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > Changes since v3: Fix typo in purple; Fix whitespacing > No changes since v2: Re-send with the proper e-mails. > Changes since v1: Unbreak existing definitions. > include/dt-bindings/leds/common.h | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/include/dt-bindings/leds/common.h b/include/dt-bindings/leds/common.h > index 3be89a7c20a9..9a0d33d027ff 100644 > --- a/include/dt-bindings/leds/common.h > +++ b/include/dt-bindings/leds/common.h > @@ -33,7 +33,12 @@ > #define LED_COLOR_ID_MULTI 8 /* For multicolor LEDs */ > #define LED_COLOR_ID_RGB 9 /* For multicolor LEDs that can do arbitrary color, > so this would include RGBW and similar */ > -#define LED_COLOR_ID_MAX 10 > +#define LED_COLOR_ID_PURPLE 10 > +#define LED_COLOR_ID_ORANGE 11 > +#define LED_COLOR_ID_PINK 12 > +#define LED_COLOR_ID_CYAN 13 > +#define LED_COLOR_ID_LIME 14 > +#define LED_COLOR_ID_MAX 15 Looks good to me. Acked-by: Alexander Dahl <ada@thorsis.com> Greets Alex > > /* Standard LED functions */ > /* Keyboard LEDs, usually it would be input4::capslock etc. */ > -- > 2.37.2 >
On Tue, 30 Aug 2022 15:46:13 +0200, Olliver Schinagl wrote: > In commit 853a78a7d6c7 (dt-bindings: leds: Add LED_COLOR_ID definitions, > Sun Jun 9 20:19:04 2019 +0200) the most basic color definitions where > added. However, there's a little more very common LED colors. > > While the documentation states 'add what is missing', engineers tend to > be lazy and will just use what currently exists. So this patch will take > (a) list from online retailers [0], [1], [2] and use the common LED colors from > there, this being reasonable as this is what is currently available to purchase. > > Note, that LIME seems to be the modern take to 'Yellow-green' or > 'Yellowish-green' from some older datasheets. > > [0]: https://www.digikey.com/en/products/filter/led-lighting-color/125 > [1]: https://eu.mouser.com/c/optoelectronics/led-lighting/led-emitters/standard-leds-smd > [2]: https://nl.farnell.com/en-NL/c/optoelectronics-displays/led-products/standard-single-colour-leds-under-75ma > > Signed-off-by: Olliver Schinagl <oliver@schinagl.nl> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > Changes since v3: Fix typo in purple; Fix whitespacing > No changes since v2: Re-send with the proper e-mails. > Changes since v1: Unbreak existing definitions. > include/dt-bindings/leds/common.h | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > Applied, thanks!
diff --git a/include/dt-bindings/leds/common.h b/include/dt-bindings/leds/common.h index 3be89a7c20a9..9a0d33d027ff 100644 --- a/include/dt-bindings/leds/common.h +++ b/include/dt-bindings/leds/common.h @@ -33,7 +33,12 @@ #define LED_COLOR_ID_MULTI 8 /* For multicolor LEDs */ #define LED_COLOR_ID_RGB 9 /* For multicolor LEDs that can do arbitrary color, so this would include RGBW and similar */ -#define LED_COLOR_ID_MAX 10 +#define LED_COLOR_ID_PURPLE 10 +#define LED_COLOR_ID_ORANGE 11 +#define LED_COLOR_ID_PINK 12 +#define LED_COLOR_ID_CYAN 13 +#define LED_COLOR_ID_LIME 14 +#define LED_COLOR_ID_MAX 15 /* Standard LED functions */ /* Keyboard LEDs, usually it would be input4::capslock etc. */