| Message ID | 20220829082200.241653-3-vigneshr@ti.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | arm64: dts: ti: Add support for AM62A family of SoCs | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 2 errors, 0 warnings, 6 lines checked |
| robh/patch-applied | success |
On 29/08/2022 11:21, Vignesh Raghavendra wrote: > Add pinctrl macros for AM62AX SoCs. These macro definitions are similar > to that of previous platforms, but adding new definitions to avoid any > naming confusions in the SoC dts files. > > checkpatch insists the following error exists: > ERROR: Macros with complex values should be enclosed in parentheses > > However, we do not need parentheses enclosing the values for this > macro as we do intend it to generate two separate values as has been > done for other similar platforms. > > Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com> > --- > include/dt-bindings/pinctrl/k3.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/dt-bindings/pinctrl/k3.h b/include/dt-bindings/pinctrl/k3.h > index a5204ab91d3e..97cd2e39efa4 100644 > --- a/include/dt-bindings/pinctrl/k3.h > +++ b/include/dt-bindings/pinctrl/k3.h > @@ -44,4 +44,6 @@ > #define AM62X_IOPAD(pa, val, muxmode) (((pa) & 0x1fff)) ((val) | (muxmode)) > #define AM62X_MCU_IOPAD(pa, val, muxmode) (((pa) & 0x1fff)) ((val) | (muxmode)) > > +#define AM62AX_IOPAD(pa, val, muxmode) (((pa) & 0x1fff)) ((val) | (muxmode)) > +#define AM62AX_MCU_IOPAD(pa, val, muxmode) (((pa) & 0x1fff)) ((val) | (muxmode)) Alphabetical order, so maybe before AM642? Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Mon, Aug 29, 2022 at 10:22 AM Vignesh Raghavendra <vigneshr@ti.com> wrote: > Add pinctrl macros for AM62AX SoCs. These macro definitions are similar > to that of previous platforms, but adding new definitions to avoid any > naming confusions in the SoC dts files. > > checkpatch insists the following error exists: > ERROR: Macros with complex values should be enclosed in parentheses > > However, we do not need parentheses enclosing the values for this > macro as we do intend it to generate two separate values as has been > done for other similar platforms. > > Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com> Acked-by: Linus Walleij <linus.walleij@linaro.org> I suppose you will merge this through the ARM SoC tree. Yours, Linus Walleij
On 30/08/22 15:23, Krzysztof Kozlowski wrote: > On 29/08/2022 11:21, Vignesh Raghavendra wrote: >> Add pinctrl macros for AM62AX SoCs. These macro definitions are similar >> to that of previous platforms, but adding new definitions to avoid any >> naming confusions in the SoC dts files. >> >> checkpatch insists the following error exists: >> ERROR: Macros with complex values should be enclosed in parentheses >> >> However, we do not need parentheses enclosing the values for this >> macro as we do intend it to generate two separate values as has been >> done for other similar platforms. >> >> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com> >> --- >> include/dt-bindings/pinctrl/k3.h | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/include/dt-bindings/pinctrl/k3.h b/include/dt-bindings/pinctrl/k3.h >> index a5204ab91d3e..97cd2e39efa4 100644 >> --- a/include/dt-bindings/pinctrl/k3.h >> +++ b/include/dt-bindings/pinctrl/k3.h >> @@ -44,4 +44,6 @@ >> #define AM62X_IOPAD(pa, val, muxmode) (((pa) & 0x1fff)) ((val) | (muxmode)) >> #define AM62X_MCU_IOPAD(pa, val, muxmode) (((pa) & 0x1fff)) ((val) | (muxmode)) >> >> +#define AM62AX_IOPAD(pa, val, muxmode) (((pa) & 0x1fff)) ((val) | (muxmode)) >> +#define AM62AX_MCU_IOPAD(pa, val, muxmode) (((pa) & 0x1fff)) ((val) | (muxmode)) > > Alphabetical order, so maybe before AM642? > These macros are ordered chronologically, will add a patch to reorder alphabetically to avoid confusion. > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > Best regards, > Krzysztof
diff --git a/include/dt-bindings/pinctrl/k3.h b/include/dt-bindings/pinctrl/k3.h index a5204ab91d3e..97cd2e39efa4 100644 --- a/include/dt-bindings/pinctrl/k3.h +++ b/include/dt-bindings/pinctrl/k3.h @@ -44,4 +44,6 @@ #define AM62X_IOPAD(pa, val, muxmode) (((pa) & 0x1fff)) ((val) | (muxmode)) #define AM62X_MCU_IOPAD(pa, val, muxmode) (((pa) & 0x1fff)) ((val) | (muxmode)) +#define AM62AX_IOPAD(pa, val, muxmode) (((pa) & 0x1fff)) ((val) | (muxmode)) +#define AM62AX_MCU_IOPAD(pa, val, muxmode) (((pa) & 0x1fff)) ((val) | (muxmode)) #endif
Add pinctrl macros for AM62AX SoCs. These macro definitions are similar to that of previous platforms, but adding new definitions to avoid any naming confusions in the SoC dts files. checkpatch insists the following error exists: ERROR: Macros with complex values should be enclosed in parentheses However, we do not need parentheses enclosing the values for this macro as we do intend it to generate two separate values as has been done for other similar platforms. Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com> --- include/dt-bindings/pinctrl/k3.h | 2 ++ 1 file changed, 2 insertions(+)