| Message ID | 20220826091142.262325-1-j-choudhary@ti.com |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | [RESEND] dt-bindings: crypto: ti,sa2ul: drop dma-coherent property | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 29 lines checked |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Fri, 26 Aug 2022 14:41:42 +0530, Jayesh Choudhary wrote: > crypto driver itself is not dma-coherent. It is the dmaengine > that moves data and the buffers are to be mapped to the > dmaengine provider. So this property should be dropped. > > Fixes: 2ce9a7299bf6 ('dt-bindings: crypto: Add TI SA2UL crypto accelerator documentation') > Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com> > --- > > Resending the patch as it got ACK-ed but did not get MERGED. > (https://lore.kernel.org/all/2935fd8e-ceda-fec9-db47-65d3ec142e32@linaro.org/) > We get some warnings which are expected. I will post the dt-node > fixes once this patch gets merged. > > .../devicetree/bindings/crypto/ti,sa2ul.yaml | 13 ------------- > 1 file changed, 13 deletions(-) > Applied, thanks!
diff --git a/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml b/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml index 02f47c2e7998..0c15fefb6671 100644 --- a/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml +++ b/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml @@ -35,8 +35,6 @@ properties: - const: rx1 - const: rx2 - dma-coherent: true - "#address-cells": const: 2 @@ -72,16 +70,6 @@ required: - dmas - dma-names -if: - properties: - compatible: - enum: - - ti,j721e-sa2ul - - ti,am654-sa2ul -then: - required: - - dma-coherent - additionalProperties: false examples: @@ -95,5 +83,4 @@ examples: dmas = <&main_udmap 0xc000>, <&main_udmap 0x4000>, <&main_udmap 0x4001>; dma-names = "tx", "rx1", "rx2"; - dma-coherent; };
crypto driver itself is not dma-coherent. It is the dmaengine that moves data and the buffers are to be mapped to the dmaengine provider. So this property should be dropped. Fixes: 2ce9a7299bf6 ('dt-bindings: crypto: Add TI SA2UL crypto accelerator documentation') Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com> --- Resending the patch as it got ACK-ed but did not get MERGED. (https://lore.kernel.org/all/2935fd8e-ceda-fec9-db47-65d3ec142e32@linaro.org/) We get some warnings which are expected. I will post the dt-node fixes once this patch gets merged. .../devicetree/bindings/crypto/ti,sa2ul.yaml | 13 ------------- 1 file changed, 13 deletions(-)