| Message ID | 20220823145649.3118479-11-robh@kernel.org |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | dt-bindings: display: Add missing (unevaluated|additional)Properties on child nodes | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 23/08/2022 17:56, Rob Herring wrote: > In order to ensure only documented properties are present, node schemas > must have unevaluatedProperties or additionalProperties set to false > (typically). > > Signed-off-by: Rob Herring <robh@kernel.org> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
Hi Rob, Thank you for the patch. On Tue, Aug 23, 2022 at 09:56:42AM -0500, Rob Herring wrote: > In order to ensure only documented properties are present, node schemas > must have unevaluatedProperties or additionalProperties set to false > (typically). > > Signed-off-by: Rob Herring <robh@kernel.org> Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > --- > Documentation/devicetree/bindings/display/arm,komeda.yaml | 1 + > Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml | 1 + > Documentation/devicetree/bindings/display/msm/gpu.yaml | 1 + > .../bindings/display/samsung/samsung,exynos7-decon.yaml | 1 + > .../devicetree/bindings/display/samsung/samsung,fimd.yaml | 1 + > 5 files changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/arm,komeda.yaml b/Documentation/devicetree/bindings/display/arm,komeda.yaml > index 9f4aade97f10..3ad3eef89ca8 100644 > --- a/Documentation/devicetree/bindings/display/arm,komeda.yaml > +++ b/Documentation/devicetree/bindings/display/arm,komeda.yaml > @@ -58,6 +58,7 @@ properties: > patternProperties: > '^pipeline@[01]$': > type: object > + additionalProperties: false > description: > clocks > > diff --git a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > index 3a8614e0f627..84aafcbf0919 100644 > --- a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > @@ -51,6 +51,7 @@ properties: > properties: > port@0: > $ref: /schemas/graph.yaml#/$defs/port-base > + unevaluatedProperties: false > description: | > For LVDS encoders, port 0 is the parallel input > For LVDS decoders, port 0 is the LVDS input > diff --git a/Documentation/devicetree/bindings/display/msm/gpu.yaml b/Documentation/devicetree/bindings/display/msm/gpu.yaml > index 3397bc31d087..0179c816fa6d 100644 > --- a/Documentation/devicetree/bindings/display/msm/gpu.yaml > +++ b/Documentation/devicetree/bindings/display/msm/gpu.yaml > @@ -81,6 +81,7 @@ properties: > > zap-shader: > type: object > + additionalProperties: false > description: | > For a5xx and a6xx devices this node contains a memory-region that > points to reserved memory to store the zap shader that can be used to > diff --git a/Documentation/devicetree/bindings/display/samsung/samsung,exynos7-decon.yaml b/Documentation/devicetree/bindings/display/samsung/samsung,exynos7-decon.yaml > index 969bd8c563a5..dec1c9058876 100644 > --- a/Documentation/devicetree/bindings/display/samsung/samsung,exynos7-decon.yaml > +++ b/Documentation/devicetree/bindings/display/samsung/samsung,exynos7-decon.yaml > @@ -37,6 +37,7 @@ properties: > > i80-if-timings: > type: object > + additionalProperties: false > description: timing configuration for lcd i80 interface support > properties: > cs-setup: > diff --git a/Documentation/devicetree/bindings/display/samsung/samsung,fimd.yaml b/Documentation/devicetree/bindings/display/samsung/samsung,fimd.yaml > index 5d5cc220f78a..7593938601bb 100644 > --- a/Documentation/devicetree/bindings/display/samsung/samsung,fimd.yaml > +++ b/Documentation/devicetree/bindings/display/samsung/samsung,fimd.yaml > @@ -40,6 +40,7 @@ properties: > > i80-if-timings: > type: object > + additionalProperties: false > description: | > Timing configuration for lcd i80 interface support. > The parameters are defined as::
On 23/08/2022 17:56, Rob Herring wrote: > In order to ensure only documented properties are present, node schemas > must have unevaluatedProperties or additionalProperties set to false > (typically). > > Signed-off-by: Rob Herring <robh@kernel.org> > --- > Documentation/devicetree/bindings/display/arm,komeda.yaml | 1 + > Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml | 1 + > Documentation/devicetree/bindings/display/msm/gpu.yaml | 1 + Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> # msm > .../bindings/display/samsung/samsung,exynos7-decon.yaml | 1 + > .../devicetree/bindings/display/samsung/samsung,fimd.yaml | 1 + > 5 files changed, 5 insertions(+)
On Tue, 23 Aug 2022 09:56:42 -0500, Rob Herring wrote: > In order to ensure only documented properties are present, node schemas > must have unevaluatedProperties or additionalProperties set to false > (typically). > > Signed-off-by: Rob Herring <robh@kernel.org> > --- > Documentation/devicetree/bindings/display/arm,komeda.yaml | 1 + > Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml | 1 + > Documentation/devicetree/bindings/display/msm/gpu.yaml | 1 + > .../bindings/display/samsung/samsung,exynos7-decon.yaml | 1 + > .../devicetree/bindings/display/samsung/samsung,fimd.yaml | 1 + > 5 files changed, 5 insertions(+) > Applied, thanks!
diff --git a/Documentation/devicetree/bindings/display/arm,komeda.yaml b/Documentation/devicetree/bindings/display/arm,komeda.yaml index 9f4aade97f10..3ad3eef89ca8 100644 --- a/Documentation/devicetree/bindings/display/arm,komeda.yaml +++ b/Documentation/devicetree/bindings/display/arm,komeda.yaml @@ -58,6 +58,7 @@ properties: patternProperties: '^pipeline@[01]$': type: object + additionalProperties: false description: clocks diff --git a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml index 3a8614e0f627..84aafcbf0919 100644 --- a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml +++ b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml @@ -51,6 +51,7 @@ properties: properties: port@0: $ref: /schemas/graph.yaml#/$defs/port-base + unevaluatedProperties: false description: | For LVDS encoders, port 0 is the parallel input For LVDS decoders, port 0 is the LVDS input diff --git a/Documentation/devicetree/bindings/display/msm/gpu.yaml b/Documentation/devicetree/bindings/display/msm/gpu.yaml index 3397bc31d087..0179c816fa6d 100644 --- a/Documentation/devicetree/bindings/display/msm/gpu.yaml +++ b/Documentation/devicetree/bindings/display/msm/gpu.yaml @@ -81,6 +81,7 @@ properties: zap-shader: type: object + additionalProperties: false description: | For a5xx and a6xx devices this node contains a memory-region that points to reserved memory to store the zap shader that can be used to diff --git a/Documentation/devicetree/bindings/display/samsung/samsung,exynos7-decon.yaml b/Documentation/devicetree/bindings/display/samsung/samsung,exynos7-decon.yaml index 969bd8c563a5..dec1c9058876 100644 --- a/Documentation/devicetree/bindings/display/samsung/samsung,exynos7-decon.yaml +++ b/Documentation/devicetree/bindings/display/samsung/samsung,exynos7-decon.yaml @@ -37,6 +37,7 @@ properties: i80-if-timings: type: object + additionalProperties: false description: timing configuration for lcd i80 interface support properties: cs-setup: diff --git a/Documentation/devicetree/bindings/display/samsung/samsung,fimd.yaml b/Documentation/devicetree/bindings/display/samsung/samsung,fimd.yaml index 5d5cc220f78a..7593938601bb 100644 --- a/Documentation/devicetree/bindings/display/samsung/samsung,fimd.yaml +++ b/Documentation/devicetree/bindings/display/samsung/samsung,fimd.yaml @@ -40,6 +40,7 @@ properties: i80-if-timings: type: object + additionalProperties: false description: | Timing configuration for lcd i80 interface support. The parameters are defined as::
In order to ensure only documented properties are present, node schemas must have unevaluatedProperties or additionalProperties set to false (typically). Signed-off-by: Rob Herring <robh@kernel.org> --- Documentation/devicetree/bindings/display/arm,komeda.yaml | 1 + Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml | 1 + Documentation/devicetree/bindings/display/msm/gpu.yaml | 1 + .../bindings/display/samsung/samsung,exynos7-decon.yaml | 1 + .../devicetree/bindings/display/samsung/samsung,fimd.yaml | 1 + 5 files changed, 5 insertions(+)